Thanks Robert,
I like what you did. spotless suppots checkstyle formatter, so, I can
use a modified odl_checks.xml.
I will update the PR accordingly.
Regards
JB
On 01/12/2018 10:02, Robert Varga wrote:
On 30/11/2018 15:50, Jean-Baptiste Onofré wrote:
Hi Lukasz,
I tried to use the
On 30/11/2018 15:50, Jean-Baptiste Onofré wrote:
> Hi Lukasz,
>
> I tried to use the "standard" style supported by spotless. It's also
> possible to use a custom eclipse formatter.
FWIW, in ODL we started off with Google formatting (if I remember
correctly, it's 5+ years now), but decided to
Hi Lukasz,
I tried to use the "standard" style supported by spotless. It's also
possible to use a custom eclipse formatter.
Does it what you are proposing ?
I can do that if you think it's a better way.
Thanks
Regards
JB
On 30/11/2018 14:26, Łukasz Dywicki wrote:
> I'm not entirely sure if
I'm not entirely sure if style which gets promoted is not too "wide". I
love approach as it reduces to bare minimum fights between IDEs and
their way of ordering imports and so on and makes PR review process just
simpler.
Some points for formatter and verbosity of some elements:
1. Two extra tabs
Hi JB,
It's good for me, I think we could apply it now.
regards,
François Papon
fpa...@apache.org
Le 23/11/2018 à 09:19, Jean-Baptiste Onofré a écrit :
> Hi guys,
>
> Thoughts about spotless ?
>
> https://github.com/apache/karaf/pull/648
>
> I will update the PR today.
>
> Agree to apply
Hi guys,
Thoughts about spotless ?
https://github.com/apache/karaf/pull/648
I will update the PR today.
Agree to apply spotless or we just avoid this for now ? Shall I start a
formal vote ?
Thanks !
Regards
JB
On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
> Hi team,
>
> I created a PR
Hello
czw., 8 lis 2018 o 20:31 Francois Papon
napisał(a):
> Hi JB,
>
> The plugins works well (just tested on Vineyard) and I can see that we
> can add the license header in the plugin configuration :
>
>
>
>/* Licensed under Apache-2.0 */
>
Hi,
yes, I also planned to test XML formatting.
For license header, it's one or another (content or file). I will do
with content, using the complete content we should (with all ASF legal
stuff).
Regards
JB
On 08/11/2018 12:19, Francois Papon wrote:
> Hi JB,
>
> The plugins works well (just
Hi,
why not?
it's worth a try.
regards, achim
Am Do., 8. Nov. 2018 um 20:31 Uhr schrieb Francois Papon <
francois.pa...@openobject.fr>:
> Hi JB,
>
> The plugins works well (just tested on Vineyard) and I can see that we
> can add the license header in the plugin configuration :
>
>
>
Thank you! :)
regards
Grzegorz Grzybek
czw., 8 lis 2018 o 08:45 Jean-Baptiste Onofré napisał(a):
> Hi guys,
>
> I updated the PR to use a 4 spaces indent style.
>
> Regards
> JB
>
> On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
> > Hi team,
> >
> > I created a PR
Hi JB,
The plugins works well (just tested on Vineyard) and I can see that we
can add the license header in the plugin configuration :
/* Licensed under Apache-2.0 */
${basedir}/license-header
Should we add this ?
regards,
François Papon
fpa...@apache.org
Le
Hi guys,
I updated the PR to use a 4 spaces indent style.
Regards
JB
On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
> Hi team,
>
> I created a PR (https://github.com/apache/karaf/pull/648) to enable
> spotless in Karaf.
>
> Spotless is code style checker but also formatter.
>
> The
Hi,
the overall idea sounds, good. I'd also would like to have at least 4
spaces for a tab for the indention :)
regards, Achim
Am Mi., 7. Nov. 2018 um 08:46 Uhr schrieb Jean-Baptiste Onofré <
j...@nanthrax.net>:
> Thanks for the update Robert.
>
> That's why I postponed a bit findbugs/spotbugs
Thanks for the update Robert.
That's why I postponed a bit findbugs/spotbugs ;) I'm not super
confidant in the generated reports ;)
Let's start with spotless first ;)
Regards
JB
On 07/11/2018 08:00, Robert Varga wrote:
> On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
>> Hi team,
>
> Hello
On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
> Hi team,
Hello JB,
[...]
> On the other hand, I was planning to add findbugs maven plugin as well.
findbugs is dead, spotbugs is its replacement. A word of caution: it's
null analysis leaves quite a bit to be desired, as it simply does not
Hi Greg,
Yes it's fully configurable.
In the PR I'm using the default Google format, which use 2 spaces by
default. I can use a different formatter (eclipse, or google with the
same style we have today).
Let me update the PR.
Regards
JB
On 07/11/2018 06:48, Grzegorz Grzybek wrote:
> Hello
>
Hello
Wait - 2 spaces? -1 for that. Is this configurable?
I've never seen project using two spaces (maybe in some
JavaScript/TypeScript ones). I'm generally +1 for this kind of
checker/formatter, but such huge one-time change breaks "diffability". I
would like to have this profile available, but
Hi JB,
It sounds very good for me :)
thanks!
François Papon
fpa...@apache.org
Le 07/11/2018 à 08:43, Jean-Baptiste Onofré a écrit :
> Hi team,
>
> I created a PR (https://github.com/apache/karaf/pull/648) to enable
> spotless in Karaf.
>
> Spotless is code style checker but also formatter.
>
>
Hi team,
I created a PR (https://github.com/apache/karaf/pull/648) to enable
spotless in Karaf.
Spotless is code style checker but also formatter.
The spotless profile I added in the PR check the style and the style can
be automatically fixed using mvn spotless:apply -Pspotless.
I think it
19 matches
Mail list logo
