[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206206#comment-16206206
]
ASF subversion and git services commented on KNOX-1064:
---
Commit 7b401
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192952#comment-16192952
]
Phil Zampino commented on KNOX-1064:
[~smore], thanks for the commit. I've filed KNOX-1
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192936#comment-16192936
]
ASF subversion and git services commented on KNOX-1064:
---
Commit 7b401
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192931#comment-16192931
]
Sandeep More commented on KNOX-1064:
I was able to test the patch and it works as expec
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192082#comment-16192082
]
Sandeep More commented on KNOX-1064:
Great, thanks Phil, I will take a look at it later
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190014#comment-16190014
]
Phil Zampino commented on KNOX-1064:
1. It could be a ConcurrentHashMap, but do you see
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190015#comment-16190015
]
Phil Zampino commented on KNOX-1064:
1. It could be a ConcurrentHashMap, but do you see
1. It could be a ConcurrentHashMap, but do you see a reason why it ought to be?
Instances of this class are not handled by multiple threads concurrently.
2. Since AmbariComponent is only used by the Ambari service discovery
implementation, there is no need to expose them outside of the package.
[
https://issues.apache.org/jira/browse/KNOX-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189905#comment-16189905
]
Sandeep More commented on KNOX-1064:
Great, thanks for the patch Phil, sorry for the de
