Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review110442 --- Ship it! Ship It! - Rajat Khandelwal On Dec. 15, 2015, 8:29 a.m

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- (Updated Dec. 15, 2015, 2:59 a.m.) Review request for lens. Changes ---

Re: Review Request 40761: Query Completion email missing for some queries

> On Dec. 14, 2015, 1:44 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, > > line 140 > > > > > > Missing space here too. Checkstyle runs as part of "

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review110227 --- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNot

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- (Updated Dec. 14, 2015, 11:50 a.m.) Review request for lens. Changes ---

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review110176 --- lens-server-api/src/main/java/org/apache/lens/server/api/events/As

Re: Review Request 40761: Query Completion email missing for some queries

> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote: > > Can you add unit tests? Added one test case for AyncListener pool creation and thread naming. Our initail analysis that if QueryEndNotifier.process(QueryEnded) fails with some exception , the AyncEventListener thread may exit i

Re: Review Request 40761: Query Completion email missing for some queries

> On Nov. 28, 2015, 8:53 a.m., Ajay Yadava wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 115 > > > > > > It will be useful to log the exception/error as

Re: Review Request 40761: Query Completion email missing for some queries

> On Dec. 7, 2015, 7:48 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 97 > > > > > > Remove commented code. Thought it would be h

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- (Updated Dec. 14, 2015, 4:10 a.m.) Review request for lens. Changes ---

Re: Review Request 40761: Query Completion email missing for some queries

> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java, > > line 115 > > > > > > Should we add error counters for kn

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review109128 --- lens-server-api/src/main/java/org/apache/lens/server/api/events/As

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review108283 --- Can you add unit tests? lens-server-api/src/main/java/org/apache/

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- (Updated Nov. 28, 2015, 12:46 p.m.) Review request for lens. Changes ---

Re: Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/#review108254 --- lens-server-api/src/main/java/org/apache/lens/server/api/events/As

Review Request 40761: Query Completion email missing for some queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40761/ --- Review request for lens. Bugs: LENS-887 https://issues.apache.org/jira/brow