Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-04 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/ --- Review request for lens. Bugs: LENS-1257 https://issues.apache.org/jira/bro

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-04 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/#review144737 --- lens-server/src/main/java/org/apache/lens/server/BaseLensService.

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-04 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/#review144754 --- lens-server/src/main/java/org/apache/lens/server/session/SessionR

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-04 Thread Lavkesh Lahngir
> On Aug. 4, 2016, 1:05 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 271 > > > > > > You don't need to get query service here. This should

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-08 Thread Rajat Khandelwal
> On Aug. 4, 2016, 6:35 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 271 > > > > > > You don't need to get query service here. This should

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-08 Thread Lavkesh Lahngir
> On Aug. 4, 2016, 1:05 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 271 > > > > > > You don't need to get query service here. This should

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-08 Thread Rajat Khandelwal
> On Aug. 4, 2016, 6:35 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 271 > > > > > > You don't need to get query service here. This should

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/ --- (Updated Aug. 8, 2016, 2:13 p.m.) Review request for lens. Changes --- R

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/ --- (Updated Aug. 8, 2016, 2:39 p.m.) Review request for lens. Changes --- A

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/ --- (Updated Aug. 9, 2016, 6:01 a.m.) Review request for lens. Changes --- D

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

2016-08-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/#review145184 --- Ship it! Ship It! - Rajat Khandelwal On Aug. 9, 2016, 11:31