Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/#review145313 --- Ship it! Ship It! - Rajat Khandelwal On Aug. 9, 2016, 5:46 p

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-09 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 9, 2016, 12:16 p.m.) Review request for lens. Bugs: LENS-1265

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-09 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 9, 2016, 12:15 p.m.) Review request for lens. Changes ---

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/#review145181 --- lens-server-api/src/main/java/org/apache/lens/server/api/session/

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 8, 2016, 12:42 p.m.) Review request for lens. Bugs: LENS-1265

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 8, 2016, 12:16 p.m.) Review request for lens. Bugs: LENS-1265

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 8, 2016, 9:51 a.m.) Review request for lens. Bugs: LENS-1265

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 8, 2016, 9:51 a.m.) Review request for lens. Changes --- r

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-08 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/#review145072 --- lens-server/src/main/java/org/apache/lens/server/scheduler/Schedu

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-08 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- (Updated Aug. 8, 2016, 8:31 a.m.) Review request for lens. Bugs: LENS-1265

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-05 Thread Lavkesh Lahngir
On Aug. 5, 2016, 5:51 a.m., Lavkesh Lahngir wrote: > > No tests are updated or added. Can we add tests? > > Lavkesh Lahngir wrote: > There are no addiotional functionalities in this change. I think we can add tests for session conf. - Lavkesh

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-05 Thread Lavkesh Lahngir
> On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java, > > line 88 > > > > > > This would require changes in specs. > >

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-05 Thread Lavkesh Lahngir
> On Aug. 5, 2016, 5:51 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java, > > line 71 > > > > > > we should call sessionService.openSessi

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-05 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/#review144898 --- lens-server/src/main/java/org/apache/lens/server/scheduler/Schedu

Re: Review Request 50814: Various Bug fixes and log messages.

2016-08-04 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/#review144875 --- No tes lens-server/src/main/java/org/apache/lens/server/schedule

Review Request 50814: Various Bug fixes and log messages.

2016-08-04 Thread Lavkesh Lahngir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/ --- Review request for lens. Bugs: LENS-1265 https://issues.apache.org/jira/bro