[Snowdrift-dev] [PATCH] Use appStripe as stripe client in handlers

2017-07-10 Thread fr33domlover
From: fr33domlover This is a new version of the patch, it uses runStripe in appStripe. It avoids the StripeClient mess but still has a type error due to StripeRunner being having the 'forall io' thing. The errors can be fixed using type annotations probably, but using

Re: [Snowdrift-dev] [PATCH] Use appStripe as stripe client in handlers

2017-07-10 Thread fr33domlover
I tried replacing all the 'StripeClient' with the actual type. It gives exactly the same type error. So, no harm in having the type alias. pgpK943rc6S5J.pgp Description: OpenPGP digital signature ___ Dev mailing list Dev@lists.snowdrift.coop

Re: [Snowdrift-dev] [PATCH] Use appStripe as stripe client in handlers

2017-07-10 Thread fr33domlover
On Mon, 10 Jul 2017 18:44:44 -0700 Bryan Richter wrote: > To whom it may concern: > > fr33domlover and I know this doesn't compile.. it was submitted for > discussion. > > Now, on with the discussing: > > On Tue, Jul 11, 2017 at 03:57:31AM +0300, fr33domlover wrote: > >

Re: [Snowdrift-dev] [PATCH] Use appStripe as stripe client in handlers

2017-07-10 Thread Bryan Richter
To whom it may concern: fr33domlover and I know this doesn't compile.. it was submitted for discussion. Now, on with the discussing: On Tue, Jul 11, 2017 at 03:57:31AM +0300, fr33domlover wrote: > From: fr33domlover > > --- > crowdmatch/crowdmatch.cabal| 3

[Snowdrift-dev] [PATCH] Use appStripe as stripe client in handlers

2017-07-10 Thread fr33domlover
From: fr33domlover --- crowdmatch/crowdmatch.cabal| 3 ++- crowdmatch/src/Crowdmatch.hs | 32 +++- website/src/AppDataTypes.hs| 6 ++ website/src/Handler/PaymentInfo.hs | 11 ++- website/src/Handler/Util.hs

Re: [Snowdrift-dev] [PATCH] Add a real Stripe runner to crowdmatch test module, using test key

2017-07-10 Thread Bryan Richter
On Tue, Jul 11, 2017 at 01:43:49AM +0300, fr33domlover wrote: > From: fr33domlover > > The runner isn't being used, I just added it there so that we can start > writing tests with it. May wish to move it to a TestImport module once > we split crowdmatch tests into

Re: [Snowdrift-dev] [PATCH] Override Stripe secret key in test settings

2017-07-10 Thread Bryan Richter
On Tue, Jul 11, 2017 at 01:05:28AM +0300, fr33domlover wrote: > From: fr33domlover > > --- > website/config/test-settings.yml | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/website/config/test-settings.yml > b/website/config/test-settings.yml >

Re: [Snowdrift-dev] my weekend dev progress and next steps

2017-07-10 Thread Bryan Richter
On Mon, Jul 10, 2017 at 09:34:56PM +0200, tuxayo wrote: > Hi, thanks for these news :) ! > > On 2017-07-10 02:28, Bryan Richter wrote: > > Other steps and potential work are here: > > > > https://git.snowdrift.coop/groups/sd/issues=label_priority Oops, missed a #!%$ sigil. ;) Try:

[Snowdrift-dev] [PATCH] Add a real Stripe runner to crowdmatch test module, using test key

2017-07-10 Thread fr33domlover
From: fr33domlover The runner isn't being used, I just added it there so that we can start writing tests with it. May wish to move it to a TestImport module once we split crowdmatch tests into multiple modules. --- crowdmatch/crowdmatch.cabal | 1 +

[Snowdrift-dev] [PATCH] Override Stripe secret key in test settings

2017-07-10 Thread fr33domlover
From: fr33domlover --- website/config/test-settings.yml | 9 + 1 file changed, 9 insertions(+) diff --git a/website/config/test-settings.yml b/website/config/test-settings.yml index b2d43ca..ded169e 100644 --- a/website/config/test-settings.yml +++

Re: [Snowdrift-dev] my weekend dev progress and next steps

2017-07-10 Thread tuxayo
Hi, thanks for these news :) ! On 2017-07-10 02:28, Bryan Richter wrote: > Other steps and potential work are here: > > https://git.snowdrift.coop/groups/sd/issues=label_priority This ↑ link goes 404 Cheers, -- tuxayo ___ Dev mailing list