Fwd: git master and Serializable

2021-12-14 Thread Gary Gregory
I think we should drop implementing Serializable on anything for 3.0.0. A la Effective Java #85. Gary

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
+1 Minor hassle with log4j-Cassandra discussed elsewhere. Gary On Tue, Dec 14, 2021, 13:28 Ralph Goers wrote: > My +1 > > Ralph > > > On Dec 14, 2021, at 11:26 AM, Remko Popma wrote: > > > > +1 very light validation but ran a simple test program against the > binaries > > > > On Wed, Dec 15,

Re: [VOTE] Release Log4j Kotlin API 1.2.0-rc1

2021-12-14 Thread Gary Gregory
I run 'mvn apache-rat:check' from the command line as part of a review. A generated site also includes a RAT report. Gary On Tue, Dec 14, 2021 at 11:30 AM Matt Sicker wrote: > Where is that? On the generated site? > -- > Matt Sicker > > > On Dec 14, 2021, a

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
FTR, here the crash, even after updating FailSafe to the current 3.0.0-M5: # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00010805ec4c, pid=27510, tid=0x3d03 # # JRE version: OpenJDK Runtime Environment (8.0_312) (build 1.8.0_31

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
Fails all the time :-( from that point on using 'mvn clean install -V -rf log4j-cassandra', digging... On Tue, Dec 14, 2021 at 11:00 AM Gary Gregory wrote: > My local build got further but failed dramatically: > > [INFO] Apache Log4j Cassandra . F

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
readPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [ERROR] at java.lang.Thread.run(Thread.java:748) Gary On Tue, Dec 14, 2021 at 10:46 AM Gary Gregory wrote: > On Tue, Dec 14, 2021 at 10:42 AM Ralph Goers > wrote: > >> Great. But I still need to back port the security fix.

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
On Tue, Dec 14, 2021 at 10:42 AM Ralph Goers wrote: > Great. But I still need to back port the security fix. > Sure, I just want it to build here as a sanity check (my sanity that is), I know yours is good :-) Gary > > Ralph > > > On Dec 14, 2021, at 8:36 AM,

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
This problem was a red herring for me, my ${java:runtime} string was wrapping due to length and the test did not account for that. I updated the branch and I am building locally to see if I can go through a whole build... Gary On Tue, Dec 14, 2021 at 6:06 AM Gary Gregory wrote: > Af

Re: Remove JMSAppender, JMSSink, SocketSerevr, SocketNode, ..., chainsaw, and ship it as 1.2.18

2021-12-14 Thread Gary Gregory
On Tue, Dec 14, 2021 at 9:54 AM Remko Popma wrote: > On Tue, Dec 14, 2021 at 11:44 PM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > > >My understanding is it requires an extremely > > >old JDK. > > >Have you actually tried building the project to see if this is true? > > > > I was

Re: [VOTE] Release Log4j 2.12.2-rc1

2021-12-14 Thread Gary Gregory
After checking out the tag (git status says 'HEAD detached at log4j-2.12.2-rc1') and running 'mvn clean install' with Java 8 and Maven 3.8.4, I get: [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.351 s - in org.apache.logging.log4j.MarkerMixInJsonTest [INFO] [INFO] Results

Re: [VOTE] Release Log4j Kotlin API 1.2.0-rc1

2021-12-14 Thread Gary Gregory
Should JQuery's copyright be in the NOTICE file? On Tue, Dec 14, 2021 at 5:45 AM Gary Gregory wrote: > Hi all, > > mvn apache-rat:check fails > > JQuery is included in the checkout of the tag. Is that a problem? > > Gary > > On Tue, Dec 14, 2021 at 12:38 AM Ma

Re: [VOTE] Release Log4j Kotlin API 1.2.0-rc1

2021-12-14 Thread Gary Gregory
Hi all, mvn apache-rat:check fails JQuery is included in the checkout of the tag. Is that a problem? Gary On Tue, Dec 14, 2021 at 12:38 AM Matt Sicker wrote: > This is a vote to release Log4j Kotlin API version 1.2.0, the next version > of the Kotlin facade for Log4j2. > > Please download, te

Re: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class

2021-12-13 Thread Gary Gregory
Never mind, that hard reference is from 2 days ago... BUT... if someone decides to apply this command to a current version, not so good. Gary On Mon, Dec 13, 2021 at 2:51 PM Gary Gregory wrote: > Wouldn't this be better: > > diff --git > a/log4j-core/src/main/java/org/apache/l

Re: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class

2021-12-13 Thread Gary Gregory
p.put(entry.getKey().toLowerCase(), ReflectionUtil.instantiate(clazz)); } } catch (final Throwable t) { ? On Mon, Dec 13, 2021 at 2:48 PM Gary Gregory wrote: > zip -q -d log4j-core-*.jar > org/apache/logging/log4j/core/lookup/JndiLookup.class > > This can't b

zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class

2021-12-13 Thread Gary Gregory
zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class This can't be right, can it? We have a hard reference to that class in org.apache.logging.log4j.core.lookup.Interpolator Should we really recommend this? Gary

Re: [GitHub] [logging-log4j2] sushain-pandit commented on pull request #608: Restrict LDAP access via JNDI

2021-12-13 Thread Gary Gregory
1.2 has been EOL for years so it has not received any attention, but the JMS Appender is the only one that uses the JNDI API in 1.2, so it should be OK otherwise. Gary On Mon, Dec 13, 2021 at 10:55 AM GitBox wrote: > > sushain-pandit commented on pull request #608: > URL: > https://github.com/a

Re: [VOTE] Release Log4j 2.16.0-rc1

2021-12-13 Thread Gary Gregory
Depending on the RM's availability, I think we can proceed here. Gary On Mon, Dec 13, 2021 at 10:30 AM Gary Gregory wrote: > Depending on the RM's availability > > On Mon, Dec 13, 2021 at 8:04 AM Gary Gregory > wrote: > >> +1 >> >> mvn clean pa

Re: [VOTE] Release Log4j 2.16.0-rc1

2021-12-13 Thread Gary Gregory
Depending on the RM's availability On Mon, Dec 13, 2021 at 8:04 AM Gary Gregory wrote: > +1 > > mvn clean package > mvn apache-rat:check > > Is this command 'wrong'? > mvn revapi:check -pl log4j-api > I get errors. > > My Maven toolchain file c

Re: [VOTE] Release Log4j 2.16.0-rc1

2021-12-13 Thread Gary Gregory
+1 mvn clean package mvn apache-rat:check Is this command 'wrong'? mvn revapi:check -pl log4j-api I get errors. My Maven toolchain file contains mappings for Java 8, 11, 17. Same failure as before on Windows 10 and Java 8 in the restricted JNDI test. Could be something odd with my set up I supp

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-13 Thread Gary Gregory
JNDI is commonly used to configure JMS and JDBC. Gary On Mon, Dec 13, 2021 at 4:12 AM Volkan Yazıcı wrote: > Thanks so much for your understanding Ralph, it is very important for me. > > For one, message lookups are nothing but a plethora of vulnerabilities. I > think everybody agrees on this.

Re: [logging-log4j2] branch release-2.x updated: Remove SetUtils from core.

2021-12-13 Thread Gary Gregory
+return new String[0]; This should be a constant. Gary On Mon, Dec 13, 2021 at 6:35 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > vy pushed a commit to branch release-2.x > in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git >

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Gary Gregory
ust the JNDI > change? > > > > On Dec 13, 2021, at 11:06, Gary Gregory wrote: > > > > Should we proceed with 2.15.1 or cancel it and go to 2.16.0 straight > away? > > > > Gary > > > >> On Sun, Dec 12, 2021, 20:40 Remko Popma wrote: > &

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Gary Gregory
Should we proceed with 2.15.1 or cancel it and go to 2.16.0 straight away? Gary On Sun, Dec 12, 2021, 20:40 Remko Popma wrote: > I am also okay with removing Message Lookups from 2.x. > A release with that change should be called 2.16.0 though, not 2.15.1 or > 2.15.2. > > Also it makes sense to

Re: [logging-log4j2] branch rel created (now 4456909)

2021-12-12 Thread Gary Gregory
g from > being deleted. Of course, now I can’t find the documentation on it. > > Ralph > > > On Dec 12, 2021, at 11:51 AM, Gary Gregory > wrote: > > > > If this is supposed to be a release branch, why not call it 'release'. > > Calling it 'rel'

Re: [logging-log4j2] branch rel created (now 4456909)

2021-12-12 Thread Gary Gregory
If this is supposed to be a release branch, why not call it 'release'. Calling it 'rel' seems confusing especially when we have a special immutable 'root' tag already called 'rel' in all Apache repos. The abbreviation for tags is also silly IMO, it just obfuscates what should be obvious. Gary On

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Gary Gregory
ner.java:210) Frorm the command line I can do an 'nslookup apache.org' and I get info back. I can 'ping apache.org', so DNS at the OS level seems OK. Gary On Sun, Dec 12, 2021 at 10:51 AM Gary Gregory wrote: > Also, on Windows 10 and Java 8: > > [ERROR] Failures:

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Gary Gregory
Also, on Windows 10 and Java 8: [ERROR] Failures: [ERROR] JndiRestrictedLookupTest.testDnsLookup:154 No DNS data returned [INFO] [ERROR] Tests run: 2244, Failures: 1, Errors: 0, Skipped: 11 [INFO] Does anyone else get that? Gary On Sun, Dec 12, 2021 at 9:07 AM Gary Gregory wrote: >

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Gary Gregory
+1 *- I cannot get revapi:check to work on the log4j-api module due to some weird maven dependency issue I cannot resolve, may someone confirm that this check passes?* - Apache RAT check OK - mvn clean package Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /usr/local/C

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-11 Thread Gary Gregory
I'll review in the morning (EST). Gary On Sat, Dec 11, 2021, 23:02 Matt Sicker wrote: > If possible, let’s try to get this vote done over the next 24 hours. > > Matt Sicker > > > On Dec 11, 2021, at 21:48, Matt Sicker wrote: > > > > This is a vote to release Log4j 2.15.1, the next version of

Re: Removing message lookups in master

2021-12-10 Thread Gary Gregory
I agree with Remko, we should not drop look ups altogether, they are too useful. Dropping them from parameter parsing is ok at first glance. Gary On Fri, Dec 10, 2021, 05:50 Remko Popma wrote: > I would say no. Lookups are very powerful and useful. > We could consider removing JNDI lookups. > >

Re: [VOTE] Release Log4j 2.15.0-rc2

2021-12-09 Thread Gary Gregory
Manni-Bucau. > • LOG4J2-3054: BasicContextSelector hasContext and shutdown take > the default context into account > • LOG4J2-2940: Slf4j implementations walk the stack at most once > rather than twice to determine the caller's class loader. > • LOG4J2-2965:

Re: SetUtils

2021-12-09 Thread Gary Gregory
Sounds good. Gary On Thu, Dec 9, 2021, 11:02 Volkan Yazıcı wrote: > SetUtils is only used by log4j-web, yet it is in log4j-core. I want to mark > it as deprecated in release-2.x and remove it in master. Objections? >

Re: changes.xml

2021-12-09 Thread Gary Gregory
5.3.3 -> > 5.3.5 > - org.tukaani:xz 1.8 -> > 1.9 > > > On Wed, Dec 8, 2021 at 11:09 PM Apache wrote: > > > I tried that. Somehow the whole description got removed. Even if

Re: changes.xml

2021-12-08 Thread Gary Gregory
If you refer to https://logging.staged.apache.org/log4j/2.x/changes-report.html#a2.15.0 I'm not sure what we can do unless there is special sauce to use in changes.xml. Are we supposed to use HTML in a changes.xml entry? That would be simple enough. Gary On Tue, Dec 7, 2021 at 5:05 PM Ralph Goers

Re: [VOTE] Release Log4j 2.15.0-rc1

2021-12-07 Thread Gary Gregory
g of nanoseconds in JsonTemplateLayout. > • LOG4J2-3087: Fix race in JsonTemplateLayout where a timestamp > could end up unquoted. Thanks to Anton Klarén. > • LOG4J2-3070: Ensure EncodingPatternConverter#handlesThrowable is > implemented. Thanks to Romain Manni-Bucau.

Re: [VOTE] Release Log4j 2.15.0-rc1

2021-12-07 Thread Gary Gregory
Gotcha. On Tue, Dec 7, 2021 at 3:27 PM Matt Sicker wrote: > Run maven using Java 8. The build doesn’t specify requirements on that, so > the default JDK is used, not a specific toolchain entry. > > Matt Sicker > > > On Dec 7, 2021, at 14:25, Gary Gregory wrote: > >

Re: [VOTE] Release Log4j 2.15.0-rc1

2021-12-07 Thread Gary Gregory
G4J2-3075: Fix formatting of nanoseconds in JsonTemplateLayout. > > • LOG4J2-3087: Fix race in JsonTemplateLayout where a timestamp > could end up unquoted. Thanks to Anton Klarén. > > • LOG4J2-3070: Ensure EncodingPatternConverter#handlesThrowable is > implemented. T

Re: Unexpected concurrent LoggerContext initialization

2021-11-10 Thread Gary Gregory
Should this test be added to the repo with a TODO comment? Gary On Mon, Nov 8, 2021, 07:09 Volkan Yazıcı wrote: > Hello! Does anybody have an idea why the following test fails for > CONCURRENT execution mode, whereas it works for SAME_THREAD? > > import org.apache.logging.log4j.Level; > import

Re: How to inject a dependency into a custom filter.

2021-10-22 Thread Gary Gregory
Why not reuse the feature that lets log4j automatically reload a configuration file if it detects the file has changed? Then we only have to consider what kind of configuration is needed. Gary On Fri, Oct 22, 2021, 02:18 Adwait Kumar Singh < theadvaitkumarsi...@gmail.com> wrote: > This is a sam

Re: Marker design issue

2021-10-20 Thread Gary Gregory
Ah, no, I won't do that as the example code below only uses deprecated methods. I'll keep using setParents(Marker). Gary On Tue, Oct 19, 2021, 12:57 Gary Gregory wrote: > Thanks for getting back to me Ralph. I'll try the API pattern you provided. > > Gary > >

Re: Marker design issue

2021-10-19 Thread Gary Gregory
ularly fast. > Having to traverse > multiple parent hierarchies would make it even slower. As it is, I suspect > Markers aren’t > used that heavily so trying to make it even fancier seems like overkill. > > Ralph > > > > On Oct 19, 2021, at 6:55 AM, Gary Gre

Marker design issue

2021-10-19 Thread Gary Gregory
Hi All, I get bit by this every time I try to make my markers "fancy" so I took the time this go around to open up a discussion :-) I want markers: Bob.children.John Bob.children.Jimmy Alice.children.Rose Alice.children.Sue (Never mind Alice.chidren.Bob) I want to turn off only "Bob.children" b

Re: maven-shaded-log4j-transformer

2021-10-15 Thread Gary Gregory
Here it is: https://github.com/apache/logging-log4j-tools Gary On Fri, Oct 15, 2021, 14:12 Ralph Goers wrote: > Yeah, that makes sense. It is less specific than just Maven plugins. > > Ralph > > > On Oct 15, 2021, at 9:51 AM, Gary Gregory > wrote: > > > > I

Re: maven-shaded-log4j-transformer

2021-10-15 Thread Gary Gregory
> they are all doable. > > I am also in favor of using GitHub all the way down: GitHub Issues for > > issue tracking, GitHub Actions for CI/CD (yes, even CD!), GitHub pages > for > > publishing the Maven-generated site, etc. > > > > > >> On Fri, Oct 1

Re: maven-shaded-log4j-transformer

2021-10-15 Thread Gary Gregory
Hi Ed, Your files must have the Apache License header comment, otherwise running 'mvn apache-rat:check' will fail. Gary On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin wrote: > Hello dear log4j team > > Volkan Yazıcı asked me to make maven-shaded-log4j-transformer >

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-15 Thread Gary Gregory
I've had to use this plugin in the past. I'm glad to hear of this agreement!: -) Gary On Fri, Oct 15, 2021, 06:42 Volkan Yazıcı wrote: > I have gotten in touch with the author of the > maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly > accepted to contribute this plugin i

Re: PR Build Failures

2021-09-13 Thread Gary Gregory
I've not seen this type of error before, looks like something went wrong with jubit reports. Gary On Mon, Sep 13, 2021, 13:38 Carter Kozak wrote: > Hi all, > > Does anyone know why our PR builds recently began to fail posting status > after successfully running the build? > > > Posting status '

Re: Missing commits on the master branch

2021-09-13 Thread Gary Gregory
I must have gotten side tracked and not ported to master. Sorry about that. Please go ahead, on planes today... Gary On Mon, Sep 13, 2021, 13:59 Carter Kozak wrote: > In cherry-picking a change from release-2.x to master I ran into some > conflicts because > https://github.com/apache/logging-lo

Re: Why does Logger class provide a bunch of info methods beside the varargs mthod?

2021-09-06 Thread Gary Gregory
When you call a var argument method, Java creates an array for your arguments, which might be considered wasteful in some use cases (like in a loop). Providing APIs with "unrolled" arguments avoids this creating and filling this array. Gary On Mon, Sep 6, 2021, 08:51 jingguo yao wrote: > org.a

Re: The diff between XSDs in master and release-2.x

2021-08-29 Thread Gary Gregory
I don't think there is a real reason... Gary On Wed, Aug 25, 2021, 11:03 Volkan Yazıcı wrote: > Log4j-config.xsd in master is substantially more complete compared to the > one in release-2.x. Is there a reason why we did not backport these changes > from master to release-2.x? >

Re: Log levels on a schedule

2021-08-21 Thread Gary Gregory
What about adding a level attribute to the existing TimeFilter? Gary On Mon, May 3, 2021, 14:30 Ralph Goers wrote: > I don’t understand. The TimeFilter filters totally based on time. We would > need to create a new TimeThresholdFilter. > > Ralph > > > On May 3, 2021, at 1

Re: Log levels on a schedule

2021-08-21 Thread Gary Gregory
Time filter looks good! Gary On Mon, May 3, 2021, 14:30 Ralph Goers wrote: > I don’t understand. The TimeFilter filters totally based on time. We would > need to create a new TimeThresholdFilter. > > Ralph > > > On May 3, 2021, at 10:45 AM, Gary Gregory > wrote: > &

Re: [general] Recommended event log storage?

2021-08-03 Thread Gary Gregory
I've implemented storage of log events in various proprietary products through both the JDBC Appender to MySQL and MsSQL and the MongoDb 3 and 4 Appenders. Works like a charm. The database logging is quite customized using the Log4j map message infrastructure. Gary On Tue, Aug 3, 2021, 12:50 Matt

Re: Putting a ribbon onto 2.15.0

2021-07-29 Thread Gary Gregory
The only thing I want to do but have not taken the time to do (and might not) is to create something (a filter I think) to put log levels on a schedule; see the thread "Log levels on a schedule". So if not in 2.15.0, then in 2.16.0 ;-) Gary On Tue, Jul 27, 2021 at 2:50 AM Volkan Yazıcı wrote: >

Re: Log4j master branch

2021-07-11 Thread Gary Gregory
are running with Java 8. > > Ralph > > > On Jul 10, 2021, at 1:04 PM, Gary Gregory > wrote: > > > > I'm exasperated by our build on the master branch; JPMS feels like the > > iceberg that will sink Java. > > > > I can build release-2.x nice

Re: Log4j master branch

2021-07-10 Thread Gary Gregory
I'm exasperated by our build on the master branch; JPMS feels like the iceberg that will sink Java. I can build release-2.x nicely with 'mvn clean package' If I do that on master I get: ... [INFO] Reactor Summary for Apache Log4j 2 3.0.0-SNAPSHOT: [INFO] [INFO] Apache Log4j 2

Re: LOG4J2-3121 config modified at run-time may trigger incomplete MBean re-initialization due to InstanceAlreadyExistsException (#547)

2021-07-09 Thread Gary Gregory
I commented :-) G On Fri, Jul 9, 2021, 10:19 Volkan Yazıcı wrote: > Gentlemen, you look to be the ones who got their hands most dirty with > jmx/Server. PR looks simple and legit to me. That said, I would appreciate > it if you can take a second look and merge it. > > On Fri, Jul 9, 2021 at 4:0

Re: Any plans to release log4j TCP server?

2021-07-04 Thread Gary Gregory
To be honest, getting stuff from a mobile device to the backend seems like > the only > real use case for a log4j logging service. There are too many good options > already for log > aggregation of backend services. > > Ralph > > > > > On Jul 4, 2021, at 10:51 AM

Re: Any plans to release log4j TCP server?

2021-07-04 Thread Gary Gregory
re a kind gift to anyone who happens to find > them. > > On Tue, Jun 29, 2021, 20:46 Gary Gregory wrote: > > > FWIW, we use the server at work to listen to JSON log events. There is > > definitely value there. > > > > Gary > > > > On Tue, Jun 29, 2021

Re: Any plans to release log4j TCP server?

2021-06-29 Thread Gary Gregory
FWIW, we use the server at work to listen to JSON log events. There is definitely value there. Gary On Tue, Jun 29, 2021, 13:29 Ralph Goers wrote: > Right now the server is more or less a sample we expect you will want to > copy and modify, > so releasing it doesn’t have a lot of value. > > On

Re: Any plans to release log4j TCP server?

2021-06-29 Thread Gary Gregory
I would like that as well, but I am short on time as well. Gary On Tue, Jun 29, 2021, 11:43 Константин Кракович wrote: > Hi Team, > > Could you please let me know if you have plans to release TCP server from > logging-log4j-tools project? > > > Best regards, > Kostyantyn >

Re: Code clean-ups

2021-06-28 Thread Gary Gregory
Well said Volkan. Arturo, we appreciate your interest but you might want to refocus your involvment per Volkan's comments. Gary On Mon, Jun 28, 2021, 03:22 Volkan Yazıcı wrote: > Hello Arturo, > > Even though we appreciate your contributions for code clean-ups in master > of Log4j very much, i

Tweet from Volkan Yazıcı (@yazicivo)

2021-06-16 Thread Gary Gregory
Volkan Yazıcı (@yazicivo) tweeted at 3:34 PM on Sun, Jun 13, 2021: Do you know of a Bazel ninja who can migrate Log4j's Maven builds? I can offer €2k (and maybe more) for such a service. (https://twitter.com/yazicivo/status/1404160220025217027?s=03) How do we maintain something like this? Sounds l

Re: Online Drinks #2

2021-06-13 Thread Gary Gregory
FYI, the 20th is father's day. Gary On Sun, Jun 13, 2021, 15:51 Volkan Yazıcı wrote: > I would like to ring the bell for organizing the 2nd edition of this > fabulous event > . I > have > created a Doodle

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Gary Gregory
; > 1. Confusion over where a particular component can be found. > > > 2. Although unlikely, it is possible a change in log4j-api or > log4j-core > > > could > > > break something in one of the other modules and we wouldn’t find out > > > immediately as we do today.

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Gary Gregory
y On Fri, Jun 11, 2021, 10:42 Volkan Yazıcı wrote: > Gary, I thought you were on board with breaking up into separate projects. > What do you propose instead? > > On Fri, Jun 11, 2021 at 12:22 PM Gary Gregory > wrote: > > > From my POV, this will create an incomprehensi

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Gary Gregory
ompletely breaking backward > > compatibility. > > They imply that some kind of compatibility is broken, which we are doing > > by > > requiring coding changes to Plugins to compile with 3.0. This means we > > need to > > leave in any classes or methods that

Re: Breaking up modules into separate sub-projects

2021-06-10 Thread Gary Gregory
These are all IMOs of course, YMMV: - What's the rush to 3.0? - I'm all for breaking up the core and other artifacts into more artifacts based on their dependencies requirement such that depending on Log4j 3 does not "suck in the world", for example, I should be able to depend on a currently non-e

Fwd: Apache Log4j is part of the Mars 2020 Helicopter mission

2021-06-04 Thread Gary Gregory
-- Forwarded message - From: Gary Gregory Date: Fri, Jun 4, 2021, 11:27 Subject: Apache Log4j is part of the Mars 2020 Helicopter mission To: Log4J Developers List , Sally Khudairi < sallykhuda...@yahoo.com> Hi Sally and All, My GitHub profile was adorned with a new badge

Re: [VOTE] Release Apache Chainsaw 2.1.0

2021-06-02 Thread Gary Gregory
On Tue, Jun 1, 2021 at 11:37 PM Matt Sicker wrote: > > The NOTICE file still has a copyright from 2007, but that was already > a problem in the previous release, so that can be fixed in another > release. Also, it looks like you didn't commit the source archives to > svn yet? As a reminder, Apach

Re: [VOTE] Release Apache Commons IO 2.9.0 based on RC1

2021-05-22 Thread Gary Gregory
Oops, thanks for catching that! Gary On Sat, May 22, 2021, 13:35 Ralph Goers wrote: > I don’t think the Commons PMC would be too happy if the Logging PMC > started voting on its releases. ;-) > > Ralph > > > On May 22, 2021, at 10:09 AM, Gary Gregory wrote: > > &

[VOTE] Release Apache Commons IO 2.9.0 based on RC1

2021-05-22 Thread Gary Gregory
Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Gary Gregory, Release Manager (using key 86fdc7e2a11262cb) For following is intended as a helper and refresher for reviewers. Validating a release candidate =

Re: Log levels on a schedule

2021-05-03 Thread Gary Gregory
; opt for the second approach. > > Ralph > > > On May 3, 2021, at 5:33 AM, Gary Gregory wrote: > > > > I just had an interesting request: Debug logging produces a ton of > output > > and what is being debugged only happens in a specific time window. Ho

Log levels on a schedule

2021-05-03 Thread Gary Gregory
I just had an interesting request: Debug logging produces a ton of output and what is being debugged only happens in a specific time window. How can we configure debug logging to enable in a time window...? Any thoughts on this? Can a TimeFilter be configured to only filter debug events? Gary

Re: Javac/Maven issues issues

2021-05-01 Thread Gary Gregory
Minor comment: Now that IBM provides Java 11 on the i Series, I suspect that I will see more interest from my day job about Java 11 since for us Java everyone must include IBM hardware. Gary On Wed, Apr 28, 2021, 03:14 Ralph Goers wrote: > I just thought I would update you that I have created

Re: [VOTE] Release log4cxx 0.12.0-RC2

2021-05-01 Thread Gary Gregory
FYI the repo of record should be an Apache repo, not a GitHub repo. Gary On Sat, May 1, 2021, 17:07 Robert Middleton wrote: > This is a vote to release log4cxx 0.12.0. This is RC2. This vote > supersedes the original vote. > > Please download, test, and cast your votes on the log4j developer

Re: Quarterly project status updates - please check in

2021-05-01 Thread Gary Gregory
Yes of course, pardon my typo, I meant NOT... Gary On Sat, May 1, 2021, 16:02 Ralph Goers wrote: > It does NOT require the boards attention. > > Ralph > > > On May 1, 2021, at 10:22 AM, Gary Gregory > wrote: > > > > JPMS: Worth mentioning FTR as a growing pai

Re: Quarterly project status updates - please check in

2021-05-01 Thread Gary Gregory
JPMS: Worth mentioning FTR as a growing pain but requiring board attention. Gary On Sat, May 1, 2021, 13:11 Ralph Goers wrote: > Not sure it is worth mentioning in the board report but I have been > working on getting Log4j master to fully support JPMS without a lot of > success. > > Ralph > >

Re: Log4j core

2021-04-13 Thread Gary Gregory
I thought I already did a lot of that moving around of code to new modules in master a long time ago, I might be remembering wrong, AFK ATM. Gary On Tue, Apr 13, 2021, 12:17 Matt Sicker wrote: > The SQL code is all related to JDBC and related appenders which could go in > their own module. The

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-05 Thread Gary Gregory
Nothing in Commons requires more than Java 8. JPMS support is done as one offs here and there with automatic module names. I don't see it getting better and really supporting JPMS until a component requires Java 11, the next LTS version after 8. That might not be for a while... IBM does not suppor

Re: Master is merged

2021-04-03 Thread Gary Gregory
Great news, thank you Ralph! Gary On Sat, Apr 3, 2021, 01:50 Ralph Goers wrote: > I’ve merged the Java 11 changes to the master branch. To summarize: > Toolchains are no longer required. > Java11 (or later?) is required to build and run. However, I have only > tried with Java 11. > Log4j-api an

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-25 Thread Gary Gregory
The 2 postfix gives me flashbacks of Microsoft COM interfaces! :-p putObject is less shudder inducing than put2... for me at least. Gary On Thu, Mar 25, 2021, 01:08 Remko Popma wrote: > Haha! > putObject? > > > > > On Mar 25, 2021, at 11:39, Ralph Goers > wrote: > > > > I’m sure that will dr

Re: release-2.x EventLogger

2021-03-24 Thread Gary Gregory
On Wed, Mar 24, 2021 at 5:03 PM Carter Kozak wrote: > > The flake appears to be resolved, just as mysteriously as it appeared. That, or you have special powers ;-) G > > -Carter > > On Wed, Mar 24, 2021, at 10:28, Carter Kozak wrote: > > Any ideas why org.apache.logging.log4j.EventLoggerTest.st

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-24 Thread Gary Gregory
I thought this had to do with limiting garbage retention? On Wed, Mar 24, 2021, 03:39 Volkan Yazıcı wrote: > Hello, > > Adding non-String-typed value support to MapMessage was also something on > my radar too. But this PR replacing String with Object in two lines seems > too good to be true to m

Re: The Logging Services PMC is pleased to announce our newest PMC member, Robert Middleton!

2021-03-22 Thread Gary Gregory
Welcome aboard Robert! Gary On Mon, Mar 22, 2021, 04:15 Volkan Yazıcı wrote: > Welcome aboard Robert! > > On Mon, Mar 22, 2021 at 2:31 AM Matt Sicker wrote: > > > The PMC has recently invited Robert to join the PMC which he has > > accepted. Please join me in welcoming our newest PMC member!

Re: [VOTE] Announce EOL for Java 6 and Java 7

2021-03-15 Thread Gary Gregory
+1 Gary PS: publicizing the links gives me an impression of support. On Mon, Mar 15, 2021, 02:05 Ralph Goers wrote: > This is a vote to announce Log4j 2 will no longer support Java 6 or Java > 7. We will remove the download links for Log4j 2.3 and 2.12.1 from the web > site and future release

Re: [Discuss] EOL of Java 6 and 7

2021-03-13 Thread Gary Gregory
f Java users are using > > Java 8. Java 11 is at about 36%. The only problem here is that Java 12 or > > newer is 12% and Java 7 or older is 15% That totals 132% so I really have > > no idea what to make of these numbers. > > > > Ralph > > > >> On Ma

Re: [Discuss] EOL of Java 6 and 7

2021-03-13 Thread Gary Gregory
That's fine with me. FWIW: At work, what is holding us back moving from Java 8 to 11 is that IBM does not support a production level Java 11 on the i/Series yet (EA only IIRC). Gary On Sat, Mar 13, 2021 at 5:28 PM Ralph Goers wrote: > > Log4j 2.3 was the last Log4j 2 release to support Java 6.

Re: [apache/logging-log4j2] ensure EncodingPatternConverter#handlesThrowable is implemented (#473)

2021-03-09 Thread Gary Gregory
It's not innocent of failing the build though ;-) I did not look closer than noticing that the GitHub builds failed. Gary On Tue, Mar 9, 2021 at 3:46 PM Volkan Yazıcı wrote: > > The patch "seems" legit to me, but I don't know much about pattern > converters. > It is a pretty innocent looking sma

Re: Revamping website design and logo

2021-03-09 Thread Gary Gregory
Also a while back we had a logo contest and from then on changed the logo with every release. All the logos might be in git somewhere... Gary On Tue, Mar 9, 2021 at 4:34 PM Gary Gregory wrote: > > The ASF has graphics people that Apache-fy logos and such, I think you > just need to

Re: Revamping website design and logo

2021-03-09 Thread Gary Gregory
The ASF has graphics people that Apache-fy logos and such, I think you just need to email the marketing list. Gary On Tue, Mar 9, 2021 at 4:18 PM Volkan Yazıcı wrote: > > I have been tinkering for a while chipping in €500 from my pocket to revamp > Log4j logo and website. I personally think it w

Re: Parallelization of PluginManager#collectPlugins()

2021-03-08 Thread Gary Gregory
We do have a thread pool factory that decorates thread names with "log4j" IIRC... On Mon, Mar 8, 2021 at 4:29 PM Volkan Yazıcı wrote: > > Do we have a Log4j-specific ExecutorService somewhere we can hook into > PluginManager? > > On Mon, Mar 8, 2021 at 10:24 PM Carter Kozak wrote: > > > Please d

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Gary Gregory
log4j in log4j-web to be > >> turned off and provide a ServletContextListener > >> "Log4jShutdownOnContextDestroyedListener" to stop log4j. Register the > >> listener at the top of web.xml to ensure the shutdown happens last. > Thanks > >> t

Re: [VOTE] Release Log4j 2.14.1-rc1

2021-03-07 Thread Gary Gregory
916: Avoid redundant Kafka producer instantiation causing > thread leaks. Thanks to wuqian0808. > • LOG4J2-2967: Fix JsonTemplateLayout index based parameter > resolution when messages contain too few parameters. > • LOG4J2-2976: JdbcAppender composes an incorrect INS

Re: FastDateParser

2021-02-25 Thread Gary Gregory
ar. Gary > > On Wed, Feb 24, 2021 at 5:42 PM Gary Gregory > wrote: > > > Voila: > > > > org.apache.logging.log4j.core.util.datetime (Java 16) > > > > org.apache.logging.log4j.core.util.datetime.FastDateParserTest > > > > > > > testLocale

Re: FastDateParser

2021-02-24 Thread Gary Gregory
Sorry about the formatting copied on Windows/emailed/Pasted on Mac in gmail. Corporate policies... G On Wed, Feb 24, 2021 at 12:18 PM Ralph Goers wrote: > > Formatting sucks but thanks! > > Ralph > > > On Feb 24, 2021, at 9:42 AM, Gary Gregory

Re: FastDateParser

2021-02-24 Thread Gary Gregory
Voila: org.apache.logging.log4j.core.util.datetime (Java 16) org.apache.logging.log4j.core.util.datetime.FastDateParserTest testLocales_Long_AD(org.apache.logging.log4j.core.util.datetime.FastDateParserTest) java.lang.AssertionError: sr__#Cyrl н. е./2003/фебруар/0009/0007//00/по подне/недељ

Re: LOG4J2-2975 What to do with SLF4J 2.0.0 LoggingEventAware

2021-02-24 Thread Gary Gregory
I have no problem telling people that I use Log4j and that they should stop using slf4j. I've been bitten by slf4j breaking compatibility in to many debugging sessions. Upgrading from one slf4j version to the next is like stepping into a minefield blindfolded wearing earplugs. Gary On Wed, Feb 2

Re: FastDateParser

2021-02-24 Thread Gary Gregory
In 2.x git, the datetime package fails 9 tests under Java 16 EA 36. On Wed, Feb 24, 2021, 01:49 Ralph Goers wrote: > Gary, > > As you know our FastDateParser was borrowed from Apache Commons and > modified for our purposes. You picked up bug fixes from Apache Commons > several years ago. > > I n

Re: Removing GelfLayout

2021-02-18 Thread Gary Gregory
FYI, at my day job, one major hurdle to updating one of our projects to Log4j 2 are configuration files. This task is in progress. The less pain, the better. In our case, our tooling is responsible for programmatically updating these files. I do NOT want to have to sell this task AGAIN for updating

<    1   2   3   4   5   6   7   8   9   10   >