[log4j] Spotless integration

2023-03-06 Thread Benoit Lacelle
Hello, Following Piotr P. Karwasz advice, I follow-up here a conversation from https://github.com/apache/logging-log4j2/issues/1317 The main reason for my presence here is as author of Cleanthat ( https://github.com/solven-eu/cleanthat) a Java linting engine. I'm a contributor in Spotless, a mul

Re: [log4j] Spotless integration

2023-03-08 Thread Volkan Yazıcı
Thanks so much for bringing this to our attention Benoit. I agree that we should pave the contribution road and make it as least painless as possible. I am in favor of removing the ratchet from Spotless and doing a bing bang. Since such a PR would practically not be reviewable, I guess ideally a c

Re: [log4j] Spotless integration

2023-03-08 Thread Piotr P. Karwasz
Hi Benoit, On Tue, 7 Mar 2023 at 08:46, Benoit Lacelle wrote: > Log4J2 team may decide to drop ratchetFrom feature, it would lead to a > massive refactoring. I would not advise doing so. I think this is the way we should go. Ratcheting has two disadvantages: * it doesn't work outside of a Git

Re: [log4j] Spotless integration

2023-03-09 Thread Piotr P. Karwasz
Hi Volkan, On Wed, 8 Mar 2023 at 21:07, Volkan Yazıcı wrote: > I am in favor of removing the ratchet from Spotless and doing a bing bang. > Since such a PR would practically not be reviewable, I guess ideally a > committer or PMC member should do that. Once the commit lands, we can skim > through

Re: [log4j] Spotless integration

2023-03-11 Thread Benoit Lacelle
About dropping `ratchetFrom`, it is totally legitimate in my perspective. `ratchetFrom` is often a good way to wire Spotless, delaying the big-bang until the project is happy with spotless configuration. > I am not against using other Github applications, especially if their code is ASL. > What do