[jira] [Commented] (LUCENE-5618) DocValues updates send wrong fieldinfos to codec producers

2014-05-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001008#comment-14001008 ] Shai Erera commented on LUCENE-5618: Thanks Rob! bq. My only concern (which can be a

Re: Consolidate IndexWriter.deleteDocuments()

2014-05-17 Thread Shai Erera
Opened https://issues.apache.org/jira/browse/LUCENE-5679. On Sat, May 17, 2014 at 11:38 AM, Michael McCandless < luc...@mikemccandless.com> wrote: > +1 > > Mike McCandless > > http://blog.mikemccandless.com > > > On Fri, May 16, 2014 at 7:03 PM, Chris Hostetter > wrote: > > > > : I was looking

[jira] [Created] (LUCENE-5679) Consolidate IndexWriter.deleteDocuments()

2014-05-17 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5679: -- Summary: Consolidate IndexWriter.deleteDocuments() Key: LUCENE-5679 URL: https://issues.apache.org/jira/browse/LUCENE-5679 Project: Lucene - Core Issue Type: Imp

[jira] [Commented] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000997#comment-14000997 ] ASF subversion and git services commented on LUCENE-5650: - Commit

[jira] [Commented] (SOLR-5079) Create ngroups for pivot faceting

2014-05-17 Thread Brett Lucey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000993#comment-14000993 ] Brett Lucey commented on SOLR-5079: --- I don't think this patch would work (as is) if the d

[jira] [Commented] (SOLR-5854) facet.limit can limit the output of facet.pivot when facet.sort is on

2014-05-17 Thread Brett Lucey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000992#comment-14000992 ] Brett Lucey commented on SOLR-5854: --- Hmn. I think you might be using the facet.sort para

[jira] [Commented] (LUCENE-5666) Add UninvertingReader

2014-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000961#comment-14000961 ] David Smiley commented on LUCENE-5666: -- Ok, I see that now; it's good. > Add Uninve

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Attachment: LUCENE-5678.patch New patch, now fixes RateLimiter and nukes BufferedIndexOutput.

[jira] [Commented] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000902#comment-14000902 ] ASF subversion and git services commented on LUCENE-5650: - Commit

[jira] [Commented] (LUCENE-5675) "ID postings format"

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000896#comment-14000896 ] ASF subversion and git services commented on LUCENE-5675: - Commit

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Attachment: LUCENE-5678.patch New patch to make sure BufferedOutputStream is flushed on close(

[jira] [Commented] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir

2014-05-17 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000889#comment-14000889 ] Ryan Ernst commented on LUCENE-5650: Sorry about that. The nocommit was left by mist

[jira] [Commented] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000888#comment-14000888 ] ASF subversion and git services commented on LUCENE-5650: - Commit

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Attachment: LUCENE-5678.patch Hi, I cleaned up most of the code. This now makes BufferedIndex

[jira] [Commented] (SOLR-5650) When mixing adds and deletes, it appears there is a corner case where peersync can bring back a deleted update.

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000891#comment-14000891 ] ASF subversion and git services commented on SOLR-5650: --- Commit 15955

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Attachment: LUCENE-5678.patch > Investigate to use FileoutputStream instead of RandomAccessFil

[jira] [Commented] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000885#comment-14000885 ] Michael McCandless commented on LUCENE-5678: Indexing perf of new patch looks

[jira] [Commented] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000867#comment-14000867 ] Michael McCandless commented on LUCENE-5678: I tested index time for full Wik

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Attachment: (was: LUCENE-5678.patch) > Investigate to use FileoutputStream instead of Rand

[jira] [Commented] (LUCENE-5675) "ID postings format"

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000850#comment-14000850 ] ASF subversion and git services commented on LUCENE-5675: - Commit

[jira] [Comment Edited] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000801#comment-14000801 ] Uwe Schindler edited comment on LUCENE-5678 at 5/17/14 5:56 PM: ---

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Description: We no longer allow seeking in IndexOutput, so there is no need to use RandomAcce

Re:

2014-05-17 Thread Yonik Seeley
On Sat, May 17, 2014 at 12:11 PM, Tom Burton-West wrote: > I understand its expensive, but it appears that it is not freeing up memory > after each debugQuery is run. That seems like it should be avoidable (I say > that without having looked at the code). Should I open a JIRA about a > possible

Re:

2014-05-17 Thread Tom Burton-West
Thanks Mikhail, I understand its expensive, but it appears that it is not freeing up memory after each debugQuery is run. That seems like it should be avoidable (I say that without having looked at the code). Should I open a JIRA about a possible memory leak? Tom On Sat, May 17, 2014 at 8:20

[jira] [Commented] (SOLR-5970) Create collection API always has status 0

2014-05-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000814#comment-14000814 ] Mark Miller commented on SOLR-5970: --- Collections API responses really need an overhaul I

[jira] [Updated] (SOLR-2809) searcher leases

2014-05-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-2809: --- Attachment: SOLR-2809.patch OK, here's a proof-of-concept lease manager that implements the core func

[jira] [Updated] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5678: -- Attachment: LUCENE-5678.patch Very simple patch. [~mikemccand]: It would be good to compare p

[jira] [Created] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput

2014-05-17 Thread Uwe Schindler (JIRA)
Uwe Schindler created LUCENE-5678: - Summary: Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput Key: LUCENE-5678 URL: https://issues.apache.org/jira/browse/LUCENE-5678 Pr

[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000794#comment-14000794 ] ASF subversion and git services commented on LUCENE-4371: - Commit

[jira] [Resolved] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-4371. - Resolution: Fixed Fix Version/s: 5.0 > consider refactoring slicer to indexinput.slice >

[jira] [Resolved] (LUCENE-5677) Simplify position handling in DefaultIndexingChain

2014-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-5677. - Resolution: Fixed Fix Version/s: 5.0 4.9 > Simplify position handling

[jira] [Commented] (LUCENE-5666) Add UninvertingReader

2014-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000784#comment-14000784 ] Robert Muir commented on LUCENE-5666: - I think you missed the point. it does not have

[jira] [Commented] (LUCENE-5677) Simplify position handling in DefaultIndexingChain

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000786#comment-14000786 ] ASF subversion and git services commented on LUCENE-5677: - Commit

[jira] [Commented] (LUCENE-5666) Add UninvertingReader

2014-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000782#comment-14000782 ] David Smiley commented on LUCENE-5666: -- Oh, right. I'll repost it here for everyone

[jira] [Commented] (LUCENE-5677) Simplify position handling in DefaultIndexingChain

2014-05-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000783#comment-14000783 ] ASF subversion and git services commented on LUCENE-5677: - Commit

Re: [JENKINS] Lucene-Solr-trunk-Linux (32bit/jdk1.7.0_55) - Build # 10320 - Failure!

2014-05-17 Thread Robert Muir
Test bug: i committed a fix. On Sat, May 17, 2014 at 8:12 AM, Policeman Jenkins Server wrote: > Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/10320/ > Java: 32bit/jdk1.7.0_55 -client -XX:+UseG1GC > > 1 tests failed. > REGRESSION: > org.apache.lucene.uninverting.TestFieldCacheVsD

[jira] [Updated] (LUCENE-5677) Simplify position handling in DefaultIndexingChain

2014-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-5677: Attachment: LUCENE-5677.patch Slightly tweaked patch: just handles the offsets with the same logic

Re:

2014-05-17 Thread Mikhail Khludnev
For Sure. Lucene's explain is really expensive and is not purposed for production use, but only for rare troubleshooting. As a mitigation measure you can scroll result set by small portions more efficient like Hoss recently explained at SearchHub. In such kind of problems, usually it's possible to

[jira] [Updated] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-4371: Attachment: LUCENE-4371.patch Added missing \@Override By the way, i noticed something when refac

[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000748#comment-14000748 ] Uwe Schindler commented on LUCENE-4371: --- bq. What javadocs? This is not a public cl

[JENKINS] Lucene-Solr-trunk-Linux (32bit/jdk1.7.0_55) - Build # 10320 - Failure!

2014-05-17 Thread Policeman Jenkins Server
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/10320/ Java: 32bit/jdk1.7.0_55 -client -XX:+UseG1GC 1 tests failed. REGRESSION: org.apache.lucene.uninverting.TestFieldCacheVsDocValues.testHugeBinaryValues Error Message: Stack Trace: java.lang.AssertionError at __randomi

Re: svn commit: r1595425 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java

2014-05-17 Thread Robert Muir
it was my bug, i recently added these tests On Sat, May 17, 2014 at 4:32 AM, Michael McCandless wrote: > Grrr, thanks Rob. > > Mike McCandless > > http://blog.mikemccandless.com > > > On Sat, May 17, 2014 at 1:22 AM, wrote: >> Author: rmuir >> Date: Sat May 17 05:22:33 2014 >> New Revision:

[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000737#comment-14000737 ] Robert Muir commented on LUCENE-4371: - {quote} We should add @Override here, because

[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000722#comment-14000722 ] Michael McCandless commented on LUCENE-4371: +1, this is an awesome simplific

[jira] [Commented] (LUCENE-5677) Simplify position handling in DefaultIndexingChain

2014-05-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000713#comment-14000713 ] Michael McCandless commented on LUCENE-5677: +1, much better! > Simplify pos

Re: Consolidate IndexWriter.deleteDocuments()

2014-05-17 Thread Michael McCandless
+1 Mike McCandless http://blog.mikemccandless.com On Fri, May 16, 2014 at 7:03 PM, Chris Hostetter wrote: > > : I was looking at IW.deleteDocs() API, and was wondering why do we have both > : deleteDocuments(Term) and deleteDocuments(Term...). Why can't we have just > : the vararg one? Same ap

[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000715#comment-14000715 ] Uwe Schindler commented on LUCENE-4371: --- Btw, thanks for hiding and making the conc

Re: svn commit: r1595425 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java

2014-05-17 Thread Michael McCandless
Grrr, thanks Rob. Mike McCandless http://blog.mikemccandless.com On Sat, May 17, 2014 at 1:22 AM, wrote: > Author: rmuir > Date: Sat May 17 05:22:33 2014 > New Revision: 1595425 > > URL: http://svn.apache.org/r1595425 > Log: > improve test > > Modified: > lucene/dev/branches/branch_4x/

[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000706#comment-14000706 ] Uwe Schindler commented on LUCENE-4371: --- Looks cool. I was a bit confused about By

[jira] [Commented] (LUCENE-5663) Fix FSDirectory.open API

2014-05-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000695#comment-14000695 ] Uwe Schindler commented on LUCENE-5663: --- I think the main problem here is just the

Re: BaseTokenStreamTestCase

2014-05-17 Thread Nitzan Shaked
Got it. Will do so, and amend my JIRA ticket to include this as well as tests. Thanks! On Sat, May 17, 2014 at 2:21 AM, Uwe Schindler wrote: > Hi, > > > > you have to capture state on the first token before inserting new ones. > When inserting a new token, **solely** call restoreState(); > cle