Re: [Lucene] Add javadoc for Lucene86PointsFormat class

Hi, David Here the link on my personal website to introduce index file .kdd&.kdi：https://www.amazingkoala.com.cn/Lucene_Document/IndexFile/2020/1104/175.html If it’s ok, I would like to rewrite it on

Re: Code reformatting

It is currently limited to a subset of the code - reformatted the code that's already formatted, so a no-ip. See exclusions in spotless.gradle. You need to add the module there and then perhaps limit to a single package so that the diff is not too overwhelming. On Tue, Dec 22, 2020 at 11:58 PM

Re: Code reformatting

I tried to use this on master for a particular module lucene/spatial-extras to see what happens. I ran "gw tidy" and it ran the tasks but did nothing discernable. Any clues what to do? ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Dec 22,

Re: Code reformatting

Yeah - those single-line comments that were broken are mostly because they were just too long to fit in a single line. Other blocks (with shorter single-line comments) were just fine. I've seen a couple other oddities resulting from //-type comments inside statements or right after variable

Re: Shared Storage -- BlobDirectory, SOLR-15051

Glad to hear there is interest! Atri Sharma intends to start helping as soon as there is code to show, which is today. The part of it that I think might be most subject to feedback is file listing tracking w/ dedupe... so I'll go slow there knowing there is feedback pending. Ishan: yeah I saw

Re: Code reformatting

Yes, that is what I saw; line breaking choices that are different than what I would manually have chosen. I don't mean to sound negative - this is a nice improvement that gets us away from having to fuss about indentation and other formatting. Even regarding these line breaks, it is sensible to

Re: [DISCUSS] SIP-12: Incremental Backup and Restore

Thanks for taking on this effort, Jason. I'll review and suggest more next year. My initial impression is that any non core functionality should remain outside Solr core as much as possible. I hope we can leverage modularity wherever possible. On Tue, 22 Dec, 2020, 10:34 pm Jason Gerlowski,

Re: Code reformatting

> It is fine, if there are conflicts and will juggle them :) If you try to merge directly, there will be conflicts. But if you do what I describe below, it should require no manual assistance and will ease the pain to literally zero effort. // get the latest changes (I assume origin points at

Re: Code reformatting

> I see it there - yes, it makes some occasional widows, and sometimes > fails to join up consecutive single-line comments (I think you > mentioned this elsewhere) but I can live with it :) I review those diffs manually (for now at least). Some things are indeed more verbose but I think they can

Re: [DISCUSS] SIP-12: Incremental Backup and Restore

Hey guys, Following up to make sure I understand the specifics you're suggesting. You're proposing that: 1. The brand new backup-related APIs (list-backups and delete-backup) be added in v2-form only. 2. Tweaks to existing backup-related APIs (create-backup, restore) be made in V2-form only. 3.

Re: Shared Storage -- BlobDirectory, SOLR-15051

Thanks for looking at this problem, David. I have some thoughts and ideas around the same, but I'll be in a better position to comment after the holidays. Focusing on chess these days  On Tue, 22 Dec, 2020, 10:17 pm Mike Drob, wrote: > Hi David, > > Thanks for sharing. I am sure I will have

Re: 8.8 Release

+1 Thanks Ishan for volunteering, much appreciated! -- Alessandro Benedetti Search Consultant, R Software Engineer, Director www.sease.io On Sat, 19 Dec 2020 at 19:21, Bruno Roustant wrote: > +1 Thanks for volunteering > > Le ven. 18 déc. 2020 à 01:41, Ishan

Re: Shared Storage -- BlobDirectory, SOLR-15051

Hi David, Thanks for sharing. I am sure I will have thoughts on this, but won’t be able to substantively comment until January. Just letting you know that there is interest and not to be discouraged if you get only silence for a while. Hopefully others will look and comment as well. Mike On

Re: Code reformatting

Hi Dawid, It is fine, if there are conflicts and will juggle them :) thanks for this effort, it is very cool! On Tue, Dec 22, 2020 at 5:04 PM Michael Sokolov wrote: > I see it there - yes, it makes some occasional widows, and sometimes > fails to join up consecutive single-line comments (I

Re: Code reformatting

I see it there - yes, it makes some occasional widows, and sometimes fails to join up consecutive single-line comments (I think you mentioned this elsewhere) but I can live with it :) On Tue, Dec 22, 2020 at 10:07 AM Dawid Weiss wrote: > > > Looks as if javadoc is likely to be the main

Shared Storage -- BlobDirectory, SOLR-15051

Hello, There's lots of exciting work going on in Solr at the moment, judging from the SIPs & some JIRA issues. I want to draw attention to my proposal for shared storage in SolrCloud that I call "BlobDirectory" -- SOLR-15051 [1]. It has a linked proposal document[2] in Google Docs. If any of

Re: Code reformatting

> Looks as if javadoc is likely to be the main challenge? Not really - it's all handled fairly well (automatically). I merged your changes to master branch and reformatted it locally, I'll merge back to master soon. Dawid - To

Re: Code reformatting

Hmm, I committed my outstanding PR with no conflicts, so I assume you didn't get the reformatting in yet; let me know if *I* can help :) -MIke On Tue, Dec 22, 2020 at 9:06 AM Michael Sokolov wrote: > > Thanks for the heads up. If you commit your changes first, I'll tackle the > reformatting

Re: Code reformatting

Thanks for the heads up. If you commit your changes first, I'll tackle the reformatting and let you know if I run into issues. Looks as if javadoc is likely to be the main challenge? On Tue, Dec 22, 2020, 8:56 AM Dawid Weiss wrote: > Hi Mike, Ignacio, > > Just wanted to let you know that I

Code reformatting

Hi Mike, Ignacio, Just wanted to let you know that I wanted to go through the rest of lucene-core reformatting soon-ish (I've done a lot on the branch already and a subset of packages ended on master too). This will touch packages which you've been working on recently. I don't think it'll be a