RE: getField vs getDeclaredField in analysis SPI

2021-09-06 Thread Uwe Schindler
Hi Alan, Would you open issue, I will take it!? Maybe also post your opinion about think fix #1 or fix #2 is better. I tend to go for fix #1. getDeclaredField() should theoretically be faster, but that won't matter here: If it goes the slow path (going up to superclass) it will fail anyways an

Re: getField vs getDeclaredField in analysis SPI

2021-09-06 Thread Alan Woodward
Thanks Uwe! > On 6 Sep 2021, at 13:11, Uwe Schindler wrote: > > Hi Alan, > >> LUCENE-9281 moved the `lookupSPIName` method from >> AbstractAnalysisFactory to AnalysisSPILoader; the method is mostly the same, >> but one line has been changed from Class.getField() to >> Class.getDeclaredField().

RE: getField vs getDeclaredField in analysis SPI

2021-09-06 Thread Uwe Schindler
Hi Alan, > LUCENE-9281 moved the `lookupSPIName` method from > AbstractAnalysisFactory to AnalysisSPILoader; the method is mostly the same, > but one line has been changed from Class.getField() to > Class.getDeclaredField(). > This can fall foul of the Security Manager, which wants a higher level

getField vs getDeclaredField in analysis SPI

2021-09-06 Thread Alan Woodward
Hi all, LUCENE-9281 moved the `lookupSPIName` method from AbstractAnalysisFactory to AnalysisSPILoader; the method is mostly the same, but one line has been changed from Class.getField() to Class.getDeclaredField(). This can fall foul of the Security Manager, which wants a higher level of perm