We should still add a project property and use it instead of tests.nightly.
this allows also users to enable errorprone.
We can initialize the default based on env back. The Jenkins ones you can see
here: https://jenkins.thetaphi.de/job/Lucene-main-Linux/34560/injectedEnvVars/
Uwe
Am 13. Mai
>
>
> Not sure why it was configured like that. The sysproo makes no sense to me
> (why only on nightly tests?).
>
Because errorprone is slw.
I would say: Let's add a separate project property like "cibuild=true". I
> can put that into Gradle property file on all nenks, too. So errorprone
>
Let's reconfigure GitHub Action to pass tests.nightly=true
Not sure why it was configured like that. The sysproo makes no sense to me (why
only on nightly tests?).
I would say: Let's add a separate project property like "cibuild=true". I can
put that into Gradle property file on all nenks,
Apologies for not fixing it myself - I had the time to look at the jenkins
log only. Maybe it'd be a good idea to run errorprone on github so that
this doesn't surprise people again.
D.
On Fri, May 13, 2022 at 7:25 PM Julie Tibshirani
wrote:
> I pushed a fix yesterday (both main and
Okay sorry I was confused about these override methods - they are
different because of the different access patterns in the sparse/dense
cases. Maybe the loss of history was unavoidable since we
moved/renamed the file, but I wish we could maintain it.
On Fri, May 13, 2022 at 1:45 PM GitBox
I pushed a fix yesterday (both main and branch_9x), sorry for the noise!
On Thu, May 12, 2022 at 11:03 PM Dawid Weiss wrote:
> This is errorprone-caused failure:
>
> > Task :lucene:core:compileTestJava FAILED
>
>
I think it would be good if we can get
https://issues.apache.org/jira/browse/SOLR-16194 into 8.11.2 I plan to work
on it this weekend. I'm hoping it will be a straightforward matter of
adding a check for existing collections.
On Fri, May 13, 2022 at 4:21 AM Anshum Gupta wrote:
> Yes please! I
+1 to back port. It will make things more consistent at least
On Thu, May 12, 2022, 11:36 AM GitBox wrote:
>
> jpountz commented on PR #859:
> URL: https://github.com/apache/lucene/pull/859#issuecomment-1125144256
>
>FWIW I found about this PR because it is in the 9.2 changelog on `main`
>
Yes please! I assumed that was already the case as both lists are copied :)
On Fri, May 13, 2022 at 12:47 AM Uwe Schindler wrote:
> Should we maybe also ask on the Lucene side if any backports to 8.11 would
> be good?
>
>
>
> Uwe
>
>
>
> -
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
Should we maybe also ask on the Lucene side if any backports to 8.11 would be
good?
Uwe
-
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: u...@thetaphi.de
From: Anshum Gupta
Sent: Friday, May 13, 2022 1:23 AM
To: d...@solr.apache.org
Cc:
This is errorprone-caused failure:
> Task :lucene:core:compileTestJava FAILED
/home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
warning: [LongFloatConversion] Conversion from long to float may
11 matches
Mail list logo
