Re: Lucene 9.7 release

2023-06-09 Thread Uwe Schindler
Hi, BTW, there was a slight change in APIJARs caused by this API change: https://github.com/openjdk/jdk/commit/5fc9b5787dc4d7f00d2c59288bc8d840fdf5b495 (this does not affect our code, but it was done 3 weeks ago). I hope something like this won't happen. I updated the PR, no code changes

Fix for vector math precision

2023-06-09 Thread Jonathan Ellis
Hi all, I ran into a bug where the cosine of a large vector taken with itself returned NaN. (Cosine of equal vectors should always be 1.) I put together a PR to do the internal math of the cosine function with double, before returning the result as a float:

Re: Lucene 9.7 release

2023-06-09 Thread Uwe Schindler
Let me merge and backport the java 21 map PR first. It has all new source directories and APIJAR files. For safety I will regenerate the 21 APIJAR with newest jdk build. Fyi, to regenerate you need to have an environment variable with jdk21 as autoprovisioning doesn't work. After that we can

Re: Lucene 9.7 release

2023-06-09 Thread Chris Hegarty
Hi, > On 9 Jun 2023, at 17:19, Uwe Schindler wrote: > > Hi, > > if possible I would like to get the Java 21 changes (MemorySegments and > Vector) into the release. I'd like to ask Chris who has better knowledge how > to proceed. If he suggests to wait maybe a week or 2, I'd suggest to wait

Scorer#getMinScore()

2023-06-09 Thread Marc D'Mello
Hi all, I was wondering why there is no Scorer#getMinScore() equivalent to Scorer#getMaxScore() (here ). I think it could potentially be useful for skipping when you have scoring functions

Re: Lucene 9.7 release

2023-06-09 Thread Michael Wechner
Thank you very much, Adrien! Am 09.06.23 um 18:20 schrieb Tomás Fernández Löbbe: +1 Thanks Adrien On Fri, Jun 9, 2023 at 9:19 AM Michael McCandless wrote: +1, thanks Adrien! Mike McCandless http://blog.mikemccandless.com On Fri, Jun 9, 2023 at 12:11 PM Patrick Zhai

Re: Lucene 9.7 release

2023-06-09 Thread Ignacio Vera
+1 On Fri, Jun 9, 2023 at 6:20 PM Tomás Fernández Löbbe wrote: > +1 > Thanks Adrien > > On Fri, Jun 9, 2023 at 9:19 AM Michael McCandless < > luc...@mikemccandless.com> wrote: > >> +1, thanks Adrien! >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Fri, Jun 9, 2023 at

Re: Lucene 9.7 release

2023-06-09 Thread Tomás Fernández Löbbe
+1 Thanks Adrien On Fri, Jun 9, 2023 at 9:19 AM Michael McCandless wrote: > +1, thanks Adrien! > > Mike McCandless > > http://blog.mikemccandless.com > > > On Fri, Jun 9, 2023 at 12:11 PM Patrick Zhai wrote: > >> +1, thank you Adrien! >> >> On Fri, Jun 9, 2023, 09:08 Adrien Grand wrote: >>

Re: Lucene 9.7 release

2023-06-09 Thread Uwe Schindler
Hi, if possible I would like to get the Java 21 changes (MemorySegments and Vector) into the release. I'd like to ask Chris who has better knowledge how to proceed. If he suggests to wait maybe a week or 2, I'd suggest to wait that time. Chris Hegarthy: Do you know if the API of JDK 21 is

Re: Lucene 9.7 release

2023-06-09 Thread Michael McCandless
+1, thanks Adrien! Mike McCandless http://blog.mikemccandless.com On Fri, Jun 9, 2023 at 12:11 PM Patrick Zhai wrote: > +1, thank you Adrien! > > On Fri, Jun 9, 2023, 09:08 Adrien Grand wrote: > >> Hello all, >> >> There is some good stuff that is scheduled for 9.7 already, I found the >>

Re: Lucene 9.7 release

2023-06-09 Thread Patrick Zhai
+1, thank you Adrien! On Fri, Jun 9, 2023, 09:08 Adrien Grand wrote: > Hello all, > > There is some good stuff that is scheduled for 9.7 already, I found the > following changes in the changelog that look especially interesting: > - Concurrent query rewrites for vector queries. > - Speedups

Lucene 9.7 release

2023-06-09 Thread Adrien Grand
Hello all, There is some good stuff that is scheduled for 9.7 already, I found the following changes in the changelog that look especially interesting: - Concurrent query rewrites for vector queries. - Speedups to vector indexing/search via integration of the Panama vector API. - Reduced

Re: [lucene] 01/04: Introduced the Word2VecSynonymFilter (#12169)

2023-06-09 Thread Alan Woodward
Hey Alessandro, I just spotted this going into 9.x which introduces some breaking changes to the QueryBuilder API (specifically, moving TermAndBoost to its own class). This will make upgrading 9.6 to 9.7 difficult as it means anything that extends QueryBuilder will need to change imports and