[jira] [Commented] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866830#comment-16866830 ] Adrien Grand commented on LUCENE-8867: -- Sorry, reading my comment again I realize it wasn't clear

[jira] [Commented] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866785#comment-16866785 ] Adrien Grand commented on LUCENE-8867: -- This is only an issue in the case that not all dimensions

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866782#comment-16866782 ] Adrien Grand commented on LUCENE-8769: -- It feels a bit wrong to me to implement support

[jira] [Commented] (LUCENE-8853) FileSwitchDirectory is broken if temp outputs are used

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866720#comment-16866720 ] Adrien Grand commented on LUCENE-8853: -- I had to change the random directory creation logic to only

[jira] [Resolved] (LUCENE-8796) Use exponential search in IntArrayDocIdSet advance method

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8796. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Use exponent

[jira] [Commented] (LUCENE-8856) Move Intervals query from sandbox to queries module

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866462#comment-16866462 ] Adrien Grand commented on LUCENE-8856: -- +1 > Move Intervals query from sandbox to queries mod

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866460#comment-16866460 ] Adrien Grand commented on LUCENE-8862: -- Right, but the benefit of doing it from within

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866456#comment-16866456 ] Adrien Grand commented on LUCENE-8811: -- +1 from me, I'd like [~romseygeek] to have a look

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866447#comment-16866447 ] Adrien Grand commented on LUCENE-8862: -- bq. your thought is that the memory tracker itself have

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866445#comment-16866445 ] Adrien Grand commented on LUCENE-8855: -- Would it be an option to use a visitor that assumes some

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866436#comment-16866436 ] Adrien Grand commented on LUCENE-8862: -- Could you pass the MemoryTrackerObject that you mentioned

[jira] [Commented] (LUCENE-8859) Add an option to load the completion suggester's FST off-heap

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866424#comment-16866424 ] Adrien Grand commented on LUCENE-8859: -- I don't think it would be too bad since reading the FST

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866364#comment-16866364 ] Adrien Grand commented on LUCENE-8862: -- I'd like to avoid adding new methods to the collector API

Re: Lucene/Solr Developer content

2019-06-17 Thread Adrien Grand
+1 On Mon, Jun 17, 2019 at 10:18 PM Jan Høydahl wrote: > > Hi devs, > > Today we have mainly two sources of developer documentation (apart from > Javadoc and refGuide): > > * The websites. Very short instructions and linking to WIKI for in-depth > * The old Moin wikis at wiki.apache.org with

[jira] [Commented] (LUCENE-8859) Add an option to load the completion suggester's FST off-heap

2019-06-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865884#comment-16865884 ] Adrien Grand commented on LUCENE-8859: -- I don't have objections to exposing this option. This makes

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865879#comment-16865879 ] Adrien Grand commented on LUCENE-8862: -- I see. Do we need a visitor at all, we could pass

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865859#comment-16865859 ] Adrien Grand commented on LUCENE-8862: -- One you have a visitor API, how would you implement per

Re: Use of JIRA fixVersion

2019-06-17 Thread Adrien Grand
+1 to Jan's proposal about not adding master when changes are also pushed to the previous major, I like the additional consistency with our CHANGES.txt. I'm less sure about requiring that the fix version is not set before resolving the issue, I have used this in combination with the blocker label

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865469#comment-16865469 ] Adrien Grand commented on LUCENE-8862: -- Memory accounting has a cost API-wise. Like queries, I

[jira] [Commented] (LUCENE-8766) Add Luwak as a lucene module

2019-06-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865402#comment-16865402 ] Adrien Grand commented on LUCENE-8766: -- [~romseygeek] FYI this seems to make the smoke tester a bit

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864245#comment-16864245 ] Adrien Grand commented on LUCENE-8855: -- I had the temptation to make Query implement Accountable

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863944#comment-16863944 ] Adrien Grand commented on LUCENE-8829: -- I'm fine with dropping the ability to set shard indices

[jira] [Created] (LUCENE-8860) LatLonShapeBoundingBoxQuery could make more decisions on inner nodes

2019-06-14 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8860: Summary: LatLonShapeBoundingBoxQuery could make more decisions on inner nodes Key: LUCENE-8860 URL: https://issues.apache.org/jira/browse/LUCENE-8860 Project: Lucene

[jira] [Commented] (LUCENE-8854) Can we do "doc at a time scoring" from the BKD tree for exact queries?

2019-06-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862456#comment-16862456 ] Adrien Grand commented on LUCENE-8854: -- I can't find the issue but I think we had discussions

Re: 8.1.2 bug fix release

2019-06-12 Thread Adrien Grand
No objections! Thanks for volunteering! On Wed, Jun 12, 2019 at 3:27 PM Đạt Cao Mạnh wrote: > > Hi, > > Just right after the 8.1.1 release has been published we’ve discovered a > serious bug in BasicAuthentication which affect all released versions of Solr > including 8.0, 8.1, 8.1.1. Details

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861964#comment-16861964 ] Adrien Grand commented on LUCENE-8811: -- In general this looks good to me, I'd like to give

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861861#comment-16861861 ] Adrien Grand commented on LUCENE-8839: -- I agree it is simple to do, but my feeling

[jira] [Updated] (LUCENE-8851) Test issue for Adrien - ignore

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8851: - Attachment: LUCENE-8851-6.patch Status: Open (was: Open) Attach LUCENE-8851-6.patch

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860697#comment-16860697 ] Adrien Grand commented on LUCENE-8829: -- bq. You mean that use docID based tie breaking iff

[jira] [Resolved] (LUCENE-8843) Only ignore IOException on dirs when invoking force

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8843. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) Thanks

[jira] [Updated] (LUCENE-8851) Test issue for Adrien - ignore

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8851: - Attachment: LUCENE-8851-5.patch > Test issue for Adrien - ign

[jira] [Commented] (LUCENE-8851) Test issue for Adrien - ignore

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860652#comment-16860652 ] Adrien Grand commented on LUCENE-8851: -- Using the "Comment" dialog for file LUCENE-88

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860649#comment-16860649 ] Adrien Grand commented on LUCENE-8829: -- bq. However, if setShardIndex = false, then that also

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860639#comment-16860639 ] Adrien Grand commented on LUCENE-8839: -- Ah, thanks for clarifying. I think some users will want

[jira] [Commented] (LUCENE-8851) Test issue for Adrien - ignore

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860627#comment-16860627 ] Adrien Grand commented on LUCENE-8851: -- Other comment. > Test issue for Adrien - ign

[jira] [Commented] (LUCENE-8851) Test issue for Adrien - ignore

2019-06-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860622#comment-16860622 ] Adrien Grand commented on LUCENE-8851: -- Comment 1. [^LUCENE-8851.patch] > Test issue for Adr

[jira] [Created] (LUCENE-8851) Test issue for Adrien - ignore

2019-06-11 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8851: Summary: Test issue for Adrien - ignore Key: LUCENE-8851 URL: https://issues.apache.org/jira/browse/LUCENE-8851 Project: Lucene - Core Issue Type: Bug

Re: No email notifications from JIRA when attaching a patch

2019-06-10 Thread Adrien Grand
e Schindler > Achterdiek 19, D-28357 Bremen > https://www.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Adrien Grand > > Sent: Monday, June 10, 2019 6:34 PM > > To: Lucene Dev > > Subject: Re: No email notifications fro

Re: No email notifications from JIRA when attaching a patch

2019-06-10 Thread Adrien Grand
; admin-level permissions to dig any deeper into why it’s not working for both > projects. > > Cassandra > On Jun 10, 2019, 3:26 AM -0500, Adrien Grand , wrote: > > Hello, > > It seems like attaching a patch doesn't trigger a notification to the > list. For inst

[jira] [Commented] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860111#comment-16860111 ] Adrien Grand commented on LUCENE-8829: -- The change makes sense to me logically but the API is a bit

[jira] [Resolved] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8362. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Add DocVa

[jira] [Resolved] (LUCENE-8815) Enable retrieving of feature values through a DoubleValues implementation

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8815. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Ena

[jira] [Resolved] (LUCENE-8834) Cache the SortedNumericDocValues.docValueCount() value whenever it is used in a loop

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8834. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Ca

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860017#comment-16860017 ] Adrien Grand commented on LUCENE-8769: -- I don't think AND support is really interesting, since

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859988#comment-16859988 ] Adrien Grand commented on LUCENE-8362: -- FYI I slightly modified your patch to give range values

[jira] [Issue Comment Deleted] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8769: - Comment: was deleted (was: FYI I slightly modified your patch to give range values a good cost

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859986#comment-16859986 ] Adrien Grand commented on LUCENE-8769: -- FYI I slightly modified your patch to give range values

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859854#comment-16859854 ] Adrien Grand commented on LUCENE-8362: -- Thanks Atri, this looks good in general. I only spotted one

No email notifications from JIRA when attaching a patch

2019-06-10 Thread Adrien Grand
Hello, It seems like attaching a patch doesn't trigger a notification to the list. For instance we got no email notification for the following update to LUCENE-8806:

[jira] [Commented] (LUCENE-8841) Explore Relevance Based Performance Benchmarks

2019-06-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859206#comment-16859206 ] Adrien Grand commented on LUCENE-8841: -- Yes that would be possible. > Explore Relevance Ba

[jira] [Commented] (LUCENE-8841) Explore Relevance Based Performance Benchmarks

2019-06-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859181#comment-16859181 ] Adrien Grand commented on LUCENE-8841: -- It used to be an Apache project. :) (Lucene subproject

[jira] [Resolved] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8825. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Improve Pr

[jira] [Commented] (LUCENE-8839) Add IndexSearcher Level Query Max Clause Count Limits

2019-06-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858703#comment-16858703 ] Adrien Grand commented on LUCENE-8839: -- I don't understand how the goal of this issue differs from

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-06-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858391#comment-16858391 ] Adrien Grand commented on LUCENE-8791: -- My concern is that we are introducing complexity for a use

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-06 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857376#comment-16857376 ] Adrien Grand commented on LUCENE-8362: -- Could we move it to the same package

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-06 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857375#comment-16857375 ] Adrien Grand commented on LUCENE-8825: -- Yes it's on my TODO list. I'm off today but I should

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857035#comment-16857035 ] Adrien Grand commented on LUCENE-8362: -- This looks good in general, some minor comments: - tests

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-06-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857019#comment-16857019 ] Adrien Grand commented on LUCENE-8150: -- No they are not, I removed the fixVersion. > Rem

[jira] [Updated] (LUCENE-8150) Remove references to segments.gen.

2019-06-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8150: - Fix Version/s: (was: master (9.0)) > Remove references to segments.

[jira] [Updated] (LUCENE-8150) Remove references to segments.gen.

2019-06-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8150: - Fix Version/s: (was: 8.1) > Remove references to segments.

Re: Enable Jenkins 7.7 jobs

2019-06-05 Thread Adrien Grand
Oops, sorry about that Cassandra. On Wed, Jun 5, 2019 at 3:35 PM Cassandra Targett wrote: > > The 8.1 Ref Guide isn’t out yet, so just like 8.0 that job needs to stay > enabled. I’ll re-enable it. > > Cassandra > On Jun 5, 2019, 8:25 AM -0500, Adrien Grand , wrote: >

Re: Enable Jenkins 7.7 jobs

2019-06-05 Thread Adrien Grand
I just disabled 7.7 and 8.1 jobs on ASF Jenkins. On Wed, Jun 5, 2019 at 12:57 PM Andrzej Białecki wrote: > > The same for 8.1 jobs, I think - thanks! > > On 5 Jun 2019, at 08:32, Jan Høydahl wrote: > > Steve, these jobs can be disabled again now. > > -- > Jan Høydahl, search solution architect

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856672#comment-16856672 ] Adrien Grand commented on LUCENE-8362: -- I'll have a look today. > Add DocValue supp

[jira] [Commented] (LUCENE-8825) Improve Print Info Of CheckHits

2019-06-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856658#comment-16856658 ] Adrien Grand commented on LUCENE-8825: -- +1 it looks useful to me > Improve Print Info Of CheckH

[jira] [Commented] (LUCENE-8819) org.apache.lucene.search.TestTopDocsMerge.testSort_1 failure

2019-06-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855970#comment-16855970 ] Adrien Grand commented on LUCENE-8819: -- TopDocs#merge has two use-cases, one is to merge results

[jira] [Commented] (LUCENE-8830) DefaultIndexingChain.getOrAddField method ignores omitNorms from FieldType

2019-06-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855964#comment-16855964 ] Adrien Grand commented on LUCENE-8830: -- The logic looks fine to me, the omitNorms flag is just set

Re: [Issue] omitNorms ignored in DefaultIndexingChain.getOrAddField method

2019-06-04 Thread Adrien Grand
The field is indeed initially created with omitNorms=false, but this gets fixed later in PerField#invert. Additionally I can't reproduce the bug you are describing: if I index documents with norms disabled, then I don't have norms in my index. On Sat, Jun 1, 2019 at 4:55 AM kai loofi wrote: > >

[jira] [Commented] (LUCENE-8796) Use exponential search in IntArrayDocIdSet advance method

2019-06-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855534#comment-16855534 ] Adrien Grand commented on LUCENE-8796: -- Hmm it's disappointing it's not making things noticeably

[jira] [Resolved] (LUCENE-8803) Provide a FieldComparator to allow sorting by a feature from a FeatureField

2019-06-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8803. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Prov

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-06-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855432#comment-16855432 ] Adrien Grand commented on LUCENE-8362: -- Thanks [~atris] I like how this is structured in general

Welcome Namgyu Kim as Lucene/Solr committer

2019-06-03 Thread Adrien Grand
Hi all, Please join me in welcoming Namgyu Kim as Lucene/ Solr committer! Kim has been helping address technical debt and fixing bugs in the last year, including a cleanup to our DutchAnalyzer[0] and improvements to the StoredFieldsVisitor API[1]. More recently he also started improving our

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-05-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850635#comment-16850635 ] Adrien Grand commented on LUCENE-8811: -- I'm wondering whether IndexSearcher could return

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-05-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850577#comment-16850577 ] Adrien Grand commented on LUCENE-8362: -- Thanks Atri. I missed the part about "exactly

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-05-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849507#comment-16849507 ] Adrien Grand commented on LUCENE-8362: -- This would be the right implementation indeed! >

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-05-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849445#comment-16849445 ] Adrien Grand commented on LUCENE-8362: -- I had a quick look. The code organization looks good

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-05-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848917#comment-16848917 ] Adrien Grand commented on LUCENE-8362: -- I like the approach, I'd just reduce visibility of new code

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-05-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848908#comment-16848908 ] Adrien Grand commented on LUCENE-8791: -- bq. Sometimes this set is not that small, Documents may

[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

2019-05-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848902#comment-16848902 ] Adrien Grand commented on LUCENE-8806: -- The change to correct. Regarding tests, could you have

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

2019-05-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847715#comment-16847715 ] Adrien Grand commented on LUCENE-8808: -- Sorry I don't. This is a hard problem. Your approach makes

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

2019-05-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847400#comment-16847400 ] Adrien Grand commented on LUCENE-8808: -- In general I'm reluctant to adding more configuration

[jira] [Resolved] (LUCENE-7386) Flatten nested disjunctions

2019-05-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-7386. -- Resolution: Fixed Fix Version/s: master (9.0) 8.1 > Flatten nes

[jira] [Commented] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

2019-05-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847343#comment-16847343 ] Adrien Grand commented on LUCENE-8810: -- Doing instanceof checks feels too fragile to me, this won't

[jira] [Commented] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

2019-05-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847320#comment-16847320 ] Adrien Grand commented on LUCENE-8810: -- I'm expecting that this would mostly be an issue for users

[jira] [Created] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-05-24 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8811: Summary: Add maximum clause count check to IndexSearcher rather than BooleanQuery Key: LUCENE-8811 URL: https://issues.apache.org/jira/browse/LUCENE-8811 Project

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

2019-05-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845828#comment-16845828 ] Adrien Grand commented on LUCENE-8808: -- I don't think it really fixes the problem, it only makes

Re: Segment names that are undergoing merge are not passed in the merge state

2019-05-22 Thread Adrien Grand
Why are you trying to delete files corresponding to the segments being merged? This is something that Lucene takes care of already, codecs shouldn't worry about it. On Wed, May 22, 2019 at 4:34 AM vamshi vijay wrote: > > Hi, > > I created my own Codec and I am trying to create new file format

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

2019-05-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845816#comment-16845816 ] Adrien Grand commented on LUCENE-8362: -- I agree this could be useful in conjunction

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

2019-05-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845802#comment-16845802 ] Adrien Grand commented on LUCENE-8808: -- Can you explain the use-case a bit more? What does it buy

Re: Distinct terms within a document for new Similarity class

2019-05-22 Thread Adrien Grand
yet. > > At least I know i should not search how to create a doc value anymore ! :) > > Thanks a lot for your help ! > Romaric > > Le 21/05/2019 à 22:23, Adrien Grand a écrit : > > Hi Romaric, > > Indeed similarities are not expected to create doc value fields,

Re: Distinct terms within a document for new Similarity class

2019-05-21 Thread Adrien Grand
If you have any advice that would be really helpful. > > Thanks. > Romaric > > Le 20/05/2019 à 12:16, Adrien Grand a écrit : > > Hi Romaric, > > > > You are right, computeNorm is the right place to compute and record > > the number of unique terms of a document.

[jira] [Resolved] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8757. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) Merged, thanks

[jira] [Resolved] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8805. -- Resolution: Fixed Fix Version/s: master (9.0) Thanks [~danmuzi], I just merged your

[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845009#comment-16845009 ] Adrien Grand commented on LUCENE-8807: -- As usual, thanks [~thetaphi] for taking care

[jira] [Commented] (LUCENE-8727) IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844817#comment-16844817 ] Adrien Grand commented on LUCENE-8727: -- I mentioned a shared priority queue in the description

[jira] [Commented] (LUCENE-8788) Order LeafReaderContexts by Estimated Number Of Hits

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844820#comment-16844820 ] Adrien Grand commented on LUCENE-8788: -- I think this is definitely worth exploring. It looks like

[jira] [Commented] (LUCENE-8788) Order LeafReaderContexts by Estimated Number Of Hits

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844796#comment-16844796 ] Adrien Grand commented on LUCENE-8788: -- Do I get your idea right that your plan is to select

[jira] [Commented] (LUCENE-8770) BlockMaxConjunctionScorer should support two-phase scorers

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844618#comment-16844618 ] Adrien Grand commented on LUCENE-8770: -- +1 > BlockMaxConjunctionScorer should support two-ph

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844595#comment-16844595 ] Adrien Grand commented on LUCENE-8757: -- [~atris] I think it is still not correct since the values

[jira] [Comment Edited] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844198#comment-16844198 ] Adrien Grand edited comment on LUCENE-8757 at 5/20/19 6:30 PM: --- Thanks

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844198#comment-16844198 ] Adrien Grand commented on LUCENE-8757: -- Thanks [~atris]. I think there is a bug

<    2   3   4   5   6   7   8   9   10   11   >