[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476032#comment-16476032
]
Bruno Roustant commented on SOLR-11865:
---
Great! I agree with all your points [~dsmiley].
Indeed
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475579#comment-16475579
]
Bruno Roustant edited comment on LUCENE-8292 at 5/15/18 9:57 AM
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475579#comment-16475579
]
Bruno Roustant commented on LUCENE-8292:
Actually there is also another related issue
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465887#comment-16465887
]
Bruno Roustant commented on LUCENE-8292:
[~dsmiley], if I create a subclass of FilterTermsEnum
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465767#comment-16465767
]
Bruno Roustant commented on LUCENE-8292:
I just realized that the current no-default-override
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462409#comment-16462409
]
Bruno Roustant edited comment on LUCENE-8292 at 5/3/18 1:08 PM:
Another
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462409#comment-16462409
]
Bruno Roustant commented on LUCENE-8292:
Another option would be to modify
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462394#comment-16462394
]
Bruno Roustant edited comment on LUCENE-8292 at 5/3/18 1:03 PM:
When
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462394#comment-16462394
]
Bruno Roustant commented on LUCENE-8292:
When looking at TermsEnum API, what I understand
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462368#comment-16462368
]
Bruno Roustant commented on LUCENE-8292:
1- "Not possible to override": I was
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated LUCENE-8292:
---
Attachment: LUCENE-8292.patch
0001-Fix-FilterLeafReader.FilterTermsEnum
Bruno Roustant created LUCENE-8292:
--
Summary: Fix FilterLeafReader.FilterTermsEnum to delegate all
seekExact methods
Key: LUCENE-8292
URL: https://issues.apache.org/jira/browse/LUCENE-8292
Project
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456470#comment-16456470
]
Bruno Roustant commented on SOLR-11865:
---
Actually the TrieSubsetMatcher introduced by the next patch
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450065#comment-16450065
]
Bruno Roustant edited comment on SOLR-11865 at 4/24/18 3:37 PM:
Sorry
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450065#comment-16450065
]
Bruno Roustant commented on SOLR-11865:
---
Sorry for the delay.
Yes, if you can take it from here
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426589#comment-16426589
]
Bruno Roustant commented on SOLR-11865:
---
New delta patch with the modification mentioned
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426589#comment-16426589
]
Bruno Roustant edited comment on SOLR-11865 at 4/5/18 7:44 AM:
---
New delta
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: SOLR-11865.patch
0003-Remove-exception-handlers-and-refactor
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: (was: SOLR-11865.patch)
> Refactor QueryElevationComponent to prepare qu
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: SOLR-11865.patch
0002-Refactor-QueryElevationComponent-after
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420620#comment-16420620
]
Bruno Roustant commented on SOLR-11865:
---
[~dsmiley] I uploaded a new patch. Is it better now
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: (was:
0002-Refactor-QueryElevationComponent-after-review.patch)
> Refac
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: (was: SOLR-11865.patch)
> Refactor QueryElevationComponent to prepare qu
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: (was:
0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: 0002-Refactor-QueryElevationComponent-after-review.patch
> Refac
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: (was: SOLR-11865.patch)
> Refactor QueryElevationComponent to prepare qu
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: SOLR-11865.patch
> Refactor QueryElevationComponent to prepare query sub
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420329#comment-16420329
]
Bruno Roustant commented on SOLR-11865:
---
11- subsetMatch flag in ElevatingQuery.
Yes, the idea
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420322#comment-16420322
]
Bruno Roustant edited comment on SOLR-11865 at 3/30/18 9:30 AM:
10
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420322#comment-16420322
]
Bruno Roustant commented on SOLR-11865:
---
10- seen.contains(id) == false.
I didn't know this Lucene
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420319#comment-16420319
]
Bruno Roustant commented on SOLR-11865:
---
9- Make the constructor of ElevatingQuery protected.
Done
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420317#comment-16420317
]
Bruno Roustant commented on SOLR-11865:
---
8- Use a UnaryOperator instead of IndexedValueProvider
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420313#comment-16420313
]
Bruno Roustant commented on SOLR-11865:
---
7- In parseExcludedMarkerFieldName
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420311#comment-16420311
]
Bruno Roustant commented on SOLR-11865:
---
6- Use {{localBoosts.addAll(boosted.keySet());}} at line
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420308#comment-16420308
]
Bruno Roustant commented on SOLR-11865:
---
5- Change comparator docVal (~line 1318) to use
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420301#comment-16420301
]
Bruno Roustant commented on SOLR-11865:
---
3- The indentation around line ~671 (contents
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420302#comment-16420302
]
Bruno Roustant commented on SOLR-11865:
---
4- No "Can be overridden by extending this class&qu
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420300#comment-16420300
]
Bruno Roustant commented on SOLR-11865:
---
2- ElevationProvider should be immutable and simplified
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420272#comment-16420272
]
Bruno Roustant commented on SOLR-11865:
---
1- InitializationExceptionHandler & LoadingExceptionHan
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385824#comment-16385824
]
Bruno Roustant commented on LUCENE-8159:
Ok. I'll let you guys decide whether to discard
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380407#comment-16380407
]
Bruno Roustant edited comment on LUCENE-8159 at 2/28/18 2:58 PM
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380407#comment-16380407
]
Bruno Roustant commented on LUCENE-8159:
[~rcmuir] could you be a little more explicit?
Without
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378373#comment-16378373
]
Bruno Roustant edited comment on LUCENE-8159 at 2/27/18 11:29 AM
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378373#comment-16378373
]
Bruno Roustant edited comment on LUCENE-8159 at 2/27/18 10:44 AM
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378373#comment-16378373
]
Bruno Roustant edited comment on LUCENE-8159 at 2/27/18 10:42 AM
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378373#comment-16378373
]
Bruno Roustant commented on LUCENE-8159:
{quote}I's rather like to expose an expert constructor
[
https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated LUCENE-8159:
---
Attachment: LUCENE-8159.patch
0001-Add-a-copy-constructor-in-AutomatonQuery
Bruno Roustant created LUCENE-8159:
--
Summary: Add a copy constructor in AutomatonQuery to copy directly
the compiled automaton
Key: LUCENE-8159
URL: https://issues.apache.org/jira/browse/LUCENE-8159
[
https://issues.apache.org/jira/browse/SOLR-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11866:
--
Attachment: SOLR-11866.patch
0001-New-SubsetMatchElevationProvider
Bruno Roustant created SOLR-11866:
-
Summary: Support efficient subset matching in query elevation rules
Key: SOLR-11866
URL: https://issues.apache.org/jira/browse/SOLR-11866
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-11865:
--
Attachment: SOLR-11865.patch
0001-Refactor-QueryElevationComponent-to-introduce
Bruno Roustant created SOLR-11865:
-
Summary: Refactor QueryElevationComponent to prepare query subset
matching
Key: SOLR-11865
URL: https://issues.apache.org/jira/browse/SOLR-11865
Project: Solr
Bruno Roustant created SOLR-6613:
Summary: TextField.analyzeMultiTerm should not throw exception
when analyzer returns no term
Key: SOLR-6613
URL: https://issues.apache.org/jira/browse/SOLR-6613
[
https://issues.apache.org/jira/browse/SOLR-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-6613:
-
Attachment: TestTextField.java
TextField.analyzeMultiTerm should not throw exception when
[
https://issues.apache.org/jira/browse/SOLR-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-6613:
-
Description:
In TextField.analyzeMultiTerm()
at line
try {
if (!source.incrementToken
101 - 155 of 155 matches
Mail list logo
