Github user jimczi commented on the issue:
https://github.com/apache/lucene-solr/pull/496
> should I close this PR
Sure, the status is tracked in the jira
[issue](https://issues.apache.org/jira/browse/LUCENE-8463) which is marked as
resolved for 7.7 and 8.0 (mas
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233798310
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java ---
@@ -1903,9 +1903,6 @@ public void testRangeOptimizesIfAllPointsMatch
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233796997
--- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
---
@@ -844,7 +844,7 @@ public BulkScorer bulkScorer(LeafReaderContext
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233797436
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java ---
@@ -234,12 +234,12 @@ public void testConjunction() throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233796946
--- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
---
@@ -766,7 +766,7 @@ public ScorerSupplier scorerSupplier
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233148192
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -70,7 +120,7 @@ public TwoPhaseIterator twoPhaseIterator
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233149418
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232836836
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -49,15 +100,27 @@ public ConstantScoreScorer(Weight weight
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232993082
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -49,15 +100,27 @@ public ConstantScoreScorer(Weight weight
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232840495
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232835412
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -49,15 +100,27 @@ public ConstantScoreScorer(Weight weight
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232841345
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232991616
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,18 @@ public void setScorer(Scorable scorer) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232800133
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,18 @@ public void setScorer(Scorable scorer) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232800760
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,18 @@ public void setScorer(Scorable scorer) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232311732
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -70,7 +98,7 @@ public TwoPhaseIterator twoPhaseIterator
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232199647
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232193904
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232184501
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232179098
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r231992930
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r231986364
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r231992058
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/480#discussion_r226211884
--- Diff: lucene/CHANGES.txt ---
@@ -123,6 +123,10 @@ Changes in Runtime Behavior
* LUCENE-8505: IndexWriter#addIndices will now fail if the target
Github user jimczi commented on the issue:
https://github.com/apache/lucene-solr/pull/384
> If we really want to insist that every component be cranky when
mistreated, then perhaps we could have toAutomaton not close the
inputTokenStream so that we can delegate that from CGF's cl
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191673559
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191594957
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191573460
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191572617
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -119,27 +147,19 @@ public boolean
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191549617
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilterFactory.java
---
@@ -0,0 +1,61
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191546661
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191548433
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -31,80 +33,106 @@
import
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191551707
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/NRTSuggesterBuilder.java
---
@@ -43,6 +44,9 @@
* in the output
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191549169
--- Diff:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ConcatenateGraphFilter.java
---
@@ -119,27 +147,19 @@ public boolean
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191551615
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/NRTSuggesterBuilder.java
---
@@ -43,6 +44,9 @@
* in the output
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165576425
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/OffsetsEnum.java
---
@@ -124,34 +123,122 @@ public PostingsEnum
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165372379
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/OffsetsEnum.java
---
@@ -124,34 +123,122 @@ public PostingsEnum
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165370877
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldHighlighter.java
---
@@ -158,121 +143,58 @@ public Object
38 matches
Mail list logo
