Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/531
Alright?
I'm confused since I thought PathHierarchyTokenizerFactory is the agreed
upon method of querying paths.
Perhaps it might not cut it for this feature though?
In any
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/531
Perhaps we could test whether "foo" is a defined field in the current
collection?
I'll try and test this on Sunday as I have got to go.
I personally prefer keeping the A
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/531
> I wonder... hmmm... maybe the nest path should always start with a '/'?
It would seem more correct since paths in general usually start with one, and
it would also make impl
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/531
I'll add another test-case then.
> I wonder... hmmm... maybe the nest path should always start with a '/'?
It would seem more correct since paths in general usually s
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/531
> I think a solution is to build an OR query where one clause has a */
prepended to it, and the other has nothing modified and so matches the term
exactly. WDYT?
Yes that se
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/531
SOLR-12768
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-12768
Alternatively you can review and apply these
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r237364758
--- Diff:
solr/core/src/test/org/apache/solr/cloud/AtomicUpdateBlockShardedTest.java ---
@@ -130,7 +130,7 @@ public void doNestedInplaceUpdateTest
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/455
I rebased using the latest master.
I also changed the tests so _root_ is not hard-coded into childless
documents, since SOLR-5211 was committed to master and ensures this behaviour
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r236074413
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestRandomFlRTGCloud.java ---
@@ -70,6 +70,9 @@
/** Always included in fl so we can
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235613814
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestCloudPseudoReturnFields.java ---
@@ -194,7 +194,7 @@ public void testAllRealFields() throws
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235247891
--- Diff: solr/core/src/test/org/apache/solr/BlockUpdateTest.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235012194
--- Diff: solr/core/src/test/org/apache/solr/BlockUpdateTest.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234882891
--- Diff: solr/core/src/test/org/apache/solr/search/TestReload.java ---
@@ -36,13 +36,13 @@ public void testGetRealtimeReload() throws Exception
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234882621
--- Diff:
solr/core/src/test/org/apache/solr/search/TestPseudoReturnFields.java ---
@@ -126,7 +126,7 @@ public void testAllRealFields() throws
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234872041
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -194,20 +197,33 @@ public String getHashableId() {
return
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234639274
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -975,6 +976,14 @@ private void updateDocOrDocValues
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234636103
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -975,6 +976,14 @@ private void updateDocOrDocValues
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/501
SOLR-5211
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-5211
Alternatively you can review and apply these
Github user moshebla commented on the pull request:
https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31114379
Perhaps a better name for it would be "isNestedUpdate".
This method checks whether the update chang
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228734114
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -609,9 +618,11 @@ public static SolrInputDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228032204
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -262,6 +263,11 @@ private void flattenAnonymous(List
unwrappedDocs
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r226858107
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -59,39 +52,147 @@ public void before
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223741723
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223359889
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223355907
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223355767
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223336215
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/455
Currently the following update operations are supported for child documents:
- add
- set
- remove
---
-
To
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r219034542
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1184,7 +1196,16 @@ protected boolean versionAdd
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/455
Currently Some Solr Core tests do not pass.
I will work on those, since this is a WIP.
The test that concerns me the most is ConvertedLegacyTest, which fails only
if VersionInfo
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/455
SOLR-12638
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-12638
Alternatively you can review and apply these
Github user moshebla closed the pull request at:
https://github.com/apache/lucene-solr/pull/443
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
Closing this PR as it was committed to master in commit
e4f256be15ca44f12a4aecb32c13d1ab2617cc00
---
-
To unsubscribe, e
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
Pushed a commit ensuring the context is set for child transformers only if
it was not set previously.
---
-
To unsubscribe
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214892512
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -132,6 +134,12 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214573620
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java ---
@@ -1831,7 +1831,7 @@ public void testChildDoctransformer
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214569199
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java ---
@@ -1831,7 +1831,7 @@ public void testChildDoctransformer
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214569119
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java ---
@@ -114,4 +114,27 @@ public void transform(SolrDocument doc
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
BTW, I was skimming through DocTransformer, and noticed
DocTransformer#needsSolrIndexSearcher.
Shouldn't this return true for ChildDocTransformer, since it searches the
docId provid
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214531907
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -131,6 +131,12 @@ public void transform(SolrDocument
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
I tried bypassing the stack overflow error from the original commit.
Hope this is good enough.
---
-
To unsubscribe, e
Github user moshebla commented on the pull request:
https://github.com/apache/lucene-solr/commit/da0856f1dc41b7ea85ce71801900d63c06422db2#commitcomment-30344758
In
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java:
In
solr/core/src/java/org
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
Oops. There's a problem with this commit.
I'm on it!
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214048597
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -106,9 +107,12 @@ public DocTransformer create
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214041147
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -297,6 +297,35 @@ public void
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/443
SOLR-12722: add fl param to ChildDocTransformer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-12722
Github user moshebla closed the pull request at:
https://github.com/apache/lucene-solr/pull/416
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
was commited in commit 5a0e7a615a9b1e7ac97c6b0f9e5604dcc1aeb03f
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213543737
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -124,10 +124,11 @@ public void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213321225
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -109,9 +109,14 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213319927
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -99,6 +96,9 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213306038
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -109,9 +109,14 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213270075
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r213202931
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -238,6 +238,17 @@ public void
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
Fixed SOLRJ tests which failed limit assertion for ChildDocTransformer
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
Rebased on master to include DocFetcher improvements,
which helped remove some boilerplate code.
---
-
To unsubscribe
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211599253
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211519256
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -264,7 +309,7 @@ private static Object
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211505124
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -264,7 +309,7 @@ private static Object
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211495503
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211108109
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -87,7 +87,12 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210482225
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -87,7 +87,12 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210475699
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -291,4 +302,15 @@ private static String
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I added extra logic to return as soon as we are able to determine that the
root doc has no child documents.
---
-
To
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210309845
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -227,27 +225,28 @@ private static String
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I have simplified the calcDocIdToIterateFrom method, and tests seem to pass
:)
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210294082
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -224,9 +225,29 @@ private static String
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210291464
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210288829
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210287119
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210285891
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210263030
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r210262386
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -81,8 +81,8 @@ private void
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
It has been a while since I last worked on this,
and after the merge with your branch some comments were overwritten.
Do you remember what changes are still needed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209862802
--- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml ---
@@ -567,7 +567,17
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I hope this is in a good enough shape for review.
There was an overlap between this ticket and the XMLLoader, so I hope I did
not miss anything
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208932604
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208813471
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208813169
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208807039
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208507249
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -32,7 +32,7 @@
import
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208507038
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -242,10 +242,10 @@ private void
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r208506508
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
---
@@ -66,34 +66,34 @@ public void testAllParams
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
I was thinking it is a bit more efficient, but I guess that small gain in
performance does not justify the exposure of a more internal API
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
Hopefully your previous requests were addressed in these commits.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r208123138
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -208,7 +179,13 @@ public static void escape(String str, Writer out,
String
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r208121420
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,82 +102,56 @@ public final static void writeXML(Writer out, String
tag
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207909827
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,83 +102,53 @@ public final static void writeXML(Writer out, String
tag
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207906914
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -208,7 +179,13 @@ public static void escape(String str, Writer out,
String
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
Hopefully the new method names are clear enough.
I naming is not one of my strong points. :worried:
---
-
To
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207892278
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
---
@@ -453,7 +454,12 @@ public SolrInputDocument readDoc(XMLStreamReader
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207885809
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -118,16 +122,16 @@ public final static void writeUnescapedXML(Writer
out
Github user moshebla closed the pull request at:
https://github.com/apache/lucene-solr/pull/410
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/410
Closing this as it was merged.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207776740
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
---
@@ -404,6 +404,7 @@ public SolrInputDocument readDoc(XMLStreamReader
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207737277
--- Diff: solr/core/src/test/org/apache/solr/update/AddBlockUpdateTest.java
---
@@ -501,6 +501,73 @@ public void testXML() throws IOException
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/430
SOLR-12485: support labelled children in xml documents
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-12485
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r206846562
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r206184346
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r206034965
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java
---
@@ -168,35 +172,57 @@ private static
1 - 100 of 191 matches
Mail list logo
