Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r97372920
--- Diff: lucene/ivy-versions.properties ---
@@ -36,7 +34,7 @@ com.google.inject.guice.version = 3.0
/com.google.inject.extensions/guice-servlet
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r92703928
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/io/ops/GreaterThanOperation.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85965892
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -32,6 +32,7 @@
+https://repository.apache.org/content/repositories
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
@joel-bernstein if you push to the `jira/solr-8593` branch it should update
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
https://github.com/apache/lucene-solr/tree/jira/solr-8593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
This is on `apache/lucene-solr` already. It is branch `jira/solr-8593`. I
opened the PR just so I could comment on some of the files.
---
If your project is set up for it, you can reply to
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Filter is needed for the Lucene query parsing piece. The rules aren't
completely correct. Some issues with `is not` and others that need to add some
tests for. It does compile though and
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
@joel-bernstein FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476962
--- Diff: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ---
@@ -80,228 +70,24 @@ private void delete() throws Exception {
@Test
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476827
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/JDBCStreamTest.java
---
@@ -354,8 +354,8 @@ public void
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85477095
--- Diff: solr/core/src/java/org/apache/solr/handler/SQLHandler.java ---
@@ -126,30 +101,46 @@ public void handleRequestBody(SolrQueryRequest req
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476697
--- Diff: lucene/ivy-versions.properties ---
@@ -36,7 +34,7 @@ com.google.inject.guice.version = 3.0
/com.google.inject.extensions/guice-servlet
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476761
--- Diff:
solr/core/src/java/org/apache/calcite/config/CalciteConnectionProperty.java ---
@@ -0,0 +1,182 @@
+/*
--- End diff --
This
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476652
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -32,6 +32,7 @@
+https://repository.apache.org/content/repositories
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476907
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java ---
@@ -223,7 +223,7 @@ public void open() throws IOException
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476713
--- Diff: lucene/ivy-versions.properties ---
@@ -99,6 +98,13 @@ io.netty.netty-all.version = 4.0.36.Final
/org.apache.ant/ant = 1.8.2
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85477051
--- Diff: solr/core/src/java/org/apache/solr/handler/sql/LimitStream.java
---
@@ -0,0 +1,89 @@
+/*
--- End diff --
Not sure this class
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476668
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -50,6 +51,7 @@
+
--- End diff --
Need
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476724
--- Diff: lucene/ivy-versions.properties ---
@@ -99,6 +98,13 @@ io.netty.netty-all.version = 4.0.36.Final
/org.apache.ant/ant = 1.8.2
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476784
--- Diff: solr/core/src/java/org/apache/solr/handler/SQLHandler.java ---
@@ -126,30 +101,46 @@ public void handleRequestBody(SolrQueryRequest req
GitHub user risdenk opened a pull request:
https://github.com/apache/lucene-solr/pull/104
Jira/solr 8593
Creating this PR just so I can leave a few comments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/lucene-solr jira
21 matches
Mail list logo
