[GitHub] [lucene-solr] atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

2019-08-23 Thread GitBox
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524513296 Thanks @tflobbe ! This is an automated message

[GitHub] [lucene-solr] atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

2019-08-22 Thread GitBox
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524185726 @tflobbe Thanks. I was slightly unsure about whether these sections actually need an immutable copy of the origi

[GitHub] [lucene-solr] atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

2019-08-22 Thread GitBox
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524171873 @tflobbe Thanks, for some reason, my grep command missed those ones. Updated the PR with the same.

[GitHub] [lucene-solr] atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

2019-08-22 Thread GitBox
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524158067 Gentle Ping This is an automated message from t

[GitHub] [lucene-solr] atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf

2019-08-05 Thread GitBox
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-518528938 Any thoughts on this? Seems safe enough to merge? --