mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504617369
Merged into upstream master branch.
Updated CHANGES:
```
+* LUCENE-8778: Define
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504519715
Thanks, I will push it to master soon.
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504019096
Hi,
just from curiosity I've googled for a while if we can handle case
insensitive lookup
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496878927
Hi @uschindler,
this PR passed all tests & precommit. If the changes in
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496000812
Just a quick note:
A few times I nearly committed the `__pycache__` directory, so I added
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743
It is not related to this issue, but I'd like to add this line to the
gitignore file. I
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-494882383
"NAME" field and Javadoc tags were added to all tokenizers/filters so this
passes unit tests. I
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-489340583
I updated the branch: refine the catch clause and safety checks in the SPI
loader; use camel
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as
static final fields and document the names
URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-486757857
To begin with, I only changed char filters for design review.
