[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-06 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217559403 We only have the needs of an hdfs client for shipping. I filed an issue to shrink that. Making a whole new contrib, extending the test running time, making the

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-06 Thread romseygeek
Github user romseygeek commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217531618 @markrmiller I don't think we need to make people jump through any more hoops, and HDFS integration would stay as part of the core distribution, but moving it

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217233476 I filed https://issues.apache.org/jira/browse/SOLR-9075 to look at shrinking the hdfs client dependency jars. --- If your project is set up for it, you can

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217231828 I'm not currently for this change. HDFS is currently built in and supported first class. I don't see a need to make anyone that wants to use it jump any more

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r62206298 --- Diff: solr/core/src/java/org/apache/solr/update/UpdateHandler.java --- @@ -200,4 +187,16 @@ public void registerOptimizeCallback(

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r62205397 --- Diff: solr/core/src/test/org/apache/solr/cloud/ShardSplitTest.java --- @@ -57,7 +57,6 @@ import static

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r62204058 --- Diff: solr/core/ivy.xml --- @@ -61,15 +61,6 @@ - - - - - --- End diff

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r62203539 --- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java --- @@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src, String

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-01 Thread dsmiley
Github user dsmiley commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-216055389 I'm +1 to the overall notion of this but I haven't reviewed the code. I'm surprised Hadoop dependencies made it into Solr-core in the first place. --- If your

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-04-28 Thread tomjon
GitHub user tomjon opened a pull request: https://github.com/apache/lucene-solr/pull/34 Move hdfs stuff out into a new contrib An attempt to move hdfs/Hadoop related classes out of core SOLR into a new contrib, and reduce the size of SOLR core by thus removing some of the Hadoop