[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r195698769 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/Lookup.java --- @@ -53,7 +53,7 @@ public final Object

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r195689810 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/InputIterator.java --- @@ -34,7 +34,7 @@ public interface

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user mikemccand commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r195387148 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/Lookup.java --- @@ -53,7 +53,7 @@ public final Object highlightKey;

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user mikemccand commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r195386599 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/InputIterator.java --- @@ -34,7 +34,7 @@ public interface InputIterator

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user nvnmandadhi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r194259193 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/BlendedInfixSuggester.java --- @@ -200,7 +201,13 @@ protected

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r194254789 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/BlendedInfixSuggester.java --- @@ -200,7 +201,13 @@ protected

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

Github user nvnmandadhi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r194210584 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/BlendedInfixSuggester.java --- @@ -200,7 +201,13 @@ protected

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/398 Lucene 8343 data type migration Different approach, data type migration to fix the bugs : 1) Weight for the Document dictionary moved to Long from long 2)