[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-20 Thread cbismuth
Github user cbismuth closed the pull request at: https://github.com/apache/lucene-solr/pull/495 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-16 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r234132506 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Softw

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-16 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r234125357 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Softwa

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233838293 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java --- @@ -1903,9 +1903,6 @@ public void testRangeOptimizesIfAllPointsMatch(

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233838178 --- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java --- @@ -844,7 +844,7 @@ public BulkScorer bulkScorer(LeafReaderContext conte

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233838241 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java --- @@ -234,12 +234,12 @@ public void testConjunction() throws IOExcep

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233838121 --- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java --- @@ -766,7 +766,7 @@ public ScorerSupplier scorerSupplier(LeafReaderConte

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233798310 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java --- @@ -1903,9 +1903,6 @@ public void testRangeOptimizesIfAllPointsMatch()

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233796997 --- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java --- @@ -844,7 +844,7 @@ public BulkScorer bulkScorer(LeafReaderContext context

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233797436 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java --- @@ -234,12 +234,12 @@ public void testConjunction() throws IOExcepti

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-15 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233796946 --- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java --- @@ -766,7 +766,7 @@ public ScorerSupplier scorerSupplier(LeafReaderContext

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-14 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233397063 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Softw

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-14 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233396998 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Softw

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-14 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233374738 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -70,7 +120,7 @@ public TwoPhaseIterator twoPhaseIterator() {

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233148824 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233148192 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -70,7 +120,7 @@ public TwoPhaseIterator twoPhaseIterator() {

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r233149418 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232835412 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -49,15 +100,27 @@ public ConstantScoreScorer(Weight weight, float

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232841345 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232993082 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -49,15 +100,27 @@ public ConstantScoreScorer(Weight weight, float

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232840495 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-13 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232836836 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -49,15 +100,27 @@ public ConstantScoreScorer(Weight weight, float

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232324465 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -70,7 +98,7 @@ public TwoPhaseIterator twoPhaseIterator() {

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232311732 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -70,7 +98,7 @@ public TwoPhaseIterator twoPhaseIterator() {

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232200711 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExc

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232199647 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExcep

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232196043 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExc

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232193904 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExcep

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232184501 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExcep

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232183517 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExc

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232179449 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softw

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232179098 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232178369 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExc

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232176947 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softw

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-09 Thread cbismuth
Github user cbismuth commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r232176882 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softw

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-08 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r231992930 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-08 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r231986364 --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java --- @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOExcep

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-08 Thread jimczi
Github user jimczi commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/495#discussion_r231992058 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softwar

[GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...

2018-11-08 Thread cbismuth
GitHub user cbismuth opened a pull request: https://github.com/apache/lucene-solr/pull/495 LUCENE-8464: Implement ConstantScoreScorer#setMinCompetitiveScore > We should make it so the iterator returns NO_MORE_DOCS after setMinCompetitiveScore is called with a value that is greater t