Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Sanne Grinovero
Since the release had passed, could we please get further fixes in further micro versions? I'm looking forward for Lucene 5.3.2 for the other fixes it brings already. On 15 January 2016 at 17:03, Yonik Seeley wrote: > On Fri, Jan 15, 2016 at 11:34 AM, Erick Erickson >

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Adrien Grand
Le sam. 16 janv. 2016 à 16:27, Anshum Gupta a écrit : > Any strong opinions here? > I'd like to get more opinions too. In the 5.4 case, it makes me a bit unhappy that we would delay the propagation of a corruption fix to our users.

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Anshum Gupta
Ideally, I'd want to just release something with all possible fixes, unless it takes ages. I think it's not in the best interest of users of deployed software to have a lot of frequent releases but again, if this isn't serious enough, let's just move forward and have a 5.3.3 and 5.4.2 with the

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Michael McCandless
On Sat, Jan 16, 2016 at 8:18 AM, Sanne Grinovero wrote: > Since the release had passed, could we please get further fixes in > further micro versions? +1, and same thing for 5.4.1 ... Mike McCandless http://blog.mikemccandless.com

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Yonik Seeley
On Sat, Jan 16, 2016 at 10:31 AM, Yonik Seeley wrote: > On Sat, Jan 16, 2016 at 10:26 AM, Anshum Gupta wrote: >> Ideally, I'd want to just release something with all possible fixes, unless >> it takes ages. > > +1, and the patch is up. I'll

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Anshum Gupta
I'll respin for 5.3.2. On Sat, Jan 16, 2016 at 7:39 PM, Yonik Seeley wrote: > On Sat, Jan 16, 2016 at 10:31 AM, Yonik Seeley wrote: > > On Sat, Jan 16, 2016 at 10:26 AM, Anshum Gupta > wrote: > >> Ideally, I'd want to just release

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-16 Thread Yonik Seeley
On Sat, Jan 16, 2016 at 10:26 AM, Anshum Gupta wrote: > Ideally, I'd want to just release something with all possible fixes, unless > it takes ages. +1, and the patch is up. I'll commit/backport shortly. Thanks Anshum! -Yonik

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-15 Thread Anshum Gupta
Thanks Adrien and every one else. The vote has passed. I am traveling back to San Francisco (14 hours away) so I will resume the release process as soon as I'm back. On Thu, Jan 14, 2016 at 5:32 PM, Adrien Grand wrote: > +1 SUCCESS! [1:11:11.509082] > > I also tried to run

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-15 Thread Yonik Seeley
On Fri, Jan 15, 2016 at 11:34 AM, Erick Erickson wrote: > Anshum: > > I really hate to ask, but do we know whether > > https://issues.apache.org/jira/browse/SOLR-8496 > (Facet search count numbers are falsified by older document versions) > > is a problem in 5.3.2? It's

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-15 Thread Erick Erickson
Anshum: I really hate to ask, but do we know whether https://issues.apache.org/jira/browse/SOLR-8496 (Facet search count numbers are falsified by older document versions) is a problem in 5.3.2? It's in 5.4.1 and we don't yet know when it was introduced. Yonik thinks this is serious enough to

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-14 Thread Adrien Grand
+1 SUCCESS! [1:11:11.509082] I also tried to run TestBackwardsCompatibility from the 5.4 branch on an index generated by this release candidate, this did not catch problems. Le mer. 13 janv. 2016 à 09:09, Adrien Grand a écrit : > Le mer. 13 janv. 2016 à 07:19, Ryan Ernst

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-13 Thread Adrien Grand
Le mer. 13 janv. 2016 à 07:19, Ryan Ernst a écrit : > While this isn't something we have tests for in TestBackwardsCompatibility > (that only tests every previous version against the current version), we do > have tests in TestVersion for parsing versions that do not have

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Noble Paul
SUCCESS! [1:33:13.315704] java 1.7 On Wed, Jan 13, 2016 at 11:48 AM, Ryan Ernst wrote: > While this isn't something we have tests for in TestBackwardsCompatibility > (that only tests every previous version against the current version), we do > have tests in TestVersion for

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Ryan Ernst
While this isn't something we have tests for in TestBackwardsCompatibility (that only tests every previous version against the current version), we do have tests in TestVersion for parsing versions that do not have constants (see testForwardsCompatibility). Version constants are only shortcuts to

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Noble Paul
I could not run the smoke test. It hangs forever. How did others manage to run it On Wed, Jan 13, 2016 at 2:31 AM, Yonik Seeley wrote: > On Tue, Jan 12, 2016 at 2:23 PM, Adrien Grand wrote: >> While working on the 5.4.1 release I just realized that we would

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Anshum Gupta
Can you svn up the lucene_solr_5_4 branch? I merged the commit from lucene_solr_5_3 branch that fixes this. There were other work arounds though e.g. using "http" or checking out and running the smoke test off local copy using the file:// protocol. You shouldn't need to do any of that now though.

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Anshum Gupta
I am not the best person to comment on weather that would block the release but let me know if you we should. Also, I agree with yonik, we shouldn't have this limitation as it stops us from pushing out bug fix releases for past releases. On Wed, Jan 13, 2016 at 2:31 AM, Yonik Seeley

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Shai Erera
I think that the reason for this release was to offer users who have just upgraded to 5.3 those bug fixes, without requiring them to upgrade to 5.4. On Tue, Jan 12, 2016 at 10:37 AM Adrien Grand wrote: > Hi Anshum, > > Just in case you didn't see the other thread called

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Adrien Grand
That's fine with me, I just wanted to make sure that the fact that 5.4.1 will go out soon does't change our considerations. Le mar. 12 janv. 2016 à 09:39, Shai Erera a écrit : > I think that the reason for this release was to offer users who have just > upgraded to 5.3 those

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Adrien Grand
Hi Anshum, Just in case you didn't see the other thread called "5.4.1 release", we need to do a bugfix release to address a potential corruption that affects Lucene/Solr 5.4.0. Since this 5.4.1 release ought to contain all fixes that are also in 5.3.2, maybe it's not worth releasing 5.3.2

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Anshum Gupta
Hi Adrien, Thanks for informing but I think it still makes sense for us to release a 5.3.2 for users who have decided to be on or are already on 5.3.x. 5.4 might mean a complicated upgrade for those users. On Tue, Jan 12, 2016 at 2:15 PM, Adrien Grand wrote: > That's fine

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Anshum Gupta
I forgot to add my own +1. SUCCESS! [0:36:47.637916] On Tue, Jan 12, 2016 at 2:07 AM, Anshum Gupta wrote: > Please vote for the RC1 release candidate for Lucene/Solr 5.3.2 > > The artifacts can be downloaded from: > >

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread david.w.smi...@gmail.com
+1 SUCCESS! [0:49:17.877825] On Tue, Jan 12, 2016 at 8:21 AM Anshum Gupta wrote: > I forgot to add my own +1. > > SUCCESS! [0:36:47.637916] > > On Tue, Jan 12, 2016 at 2:07 AM, Anshum Gupta > wrote: > >> Please vote for the RC1 release

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Steve Rowe
+1 Docs, changes and javadocs look good. I ran the smoke tester with Java7 and Java8: SUCCESS! [0:48:53.667806] -- Steve www.lucidworks.com > On Jan 12, 2016, at 9:01 AM, david.w.smi...@gmail.com wrote: > > +1 > SUCCESS! [0:49:17.877825] > > > On Tue, Jan 12, 2016 at 8:21 AM Anshum Gupta

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Tomás Fernández Löbbe
+1 SUCCESS! [1:13:10.001165] On Tue, Jan 12, 2016 at 10:50 AM, Anshum Gupta wrote: > Thanks Shalin! > > On Tue, Jan 12, 2016 at 8:42 PM, Shalin Shekhar Mangar < > shalinman...@gmail.com> wrote: > >> Upayavira made some fixes to the smoke tester on the 5.4 branch to >>

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Anshum Gupta
Thanks Shalin! On Tue, Jan 12, 2016 at 8:42 PM, Shalin Shekhar Mangar < shalinman...@gmail.com> wrote: > Upayavira made some fixes to the smoke tester on the 5.4 branch to > correctly handle HTTPS URLs. This change hasn't been backported to 5.3 > branch therefore running the smoke tester from

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Adrien Grand
While working on the 5.4.1 release I just realized that we would not prevent users from upgrading from 5.3.2 to 5.4.0 while it is something that we don't test in TestBackwardsCompatibility (since 5.4.0 is already released) and that Lucene50SegmentInfoFormat would deserialize a version constant

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Yonik Seeley
On Tue, Jan 12, 2016 at 2:23 PM, Adrien Grand wrote: > While working on the 5.4.1 release I just realized that we would not prevent > users from upgrading from 5.3.2 to 5.4.0 while it is something that we don't > test in TestBackwardsCompatibility (since 5.4.0 is already

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Shalin Shekhar Mangar
Upayavira made some fixes to the smoke tester on the 5.4 branch to correctly handle HTTPS URLs. This change hasn't been backported to 5.3 branch therefore running the smoke tester from 5.3 on this artifact will cause the smoke tester to hang indefinitely. Just putting it out there in case someone

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Yonik Seeley
+1 -Yonik On Mon, Jan 11, 2016 at 3:37 PM, Anshum Gupta wrote: > Please vote for the RC1 release candidate for Lucene/Solr 5.3.2 > > The artifacts can be downloaded from: > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.3.2-RC1-rev1723976 > > You can run the

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Mark Miller
+1 SUCCESS! [0:39:46.027802] - mark On Tue, Jan 12, 2016 at 10:12 AM Shalin Shekhar Mangar < shalinman...@gmail.com> wrote: > Upayavira made some fixes to the smoke tester on the 5.4 branch to > correctly handle HTTPS URLs. This change hasn't been backported to 5.3 > branch therefore running

Re: [VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-12 Thread Shalin Shekhar Mangar
+1 SUCCESS! [1:36:07.059099] On Tue, Jan 12, 2016 at 8:45 PM, Mark Miller wrote: > +1 > > SUCCESS! [0:39:46.027802] > > - mark > > On Tue, Jan 12, 2016 at 10:12 AM Shalin Shekhar Mangar > wrote: >> >> Upayavira made some fixes to the smoke tester

[VOTE] Release Lucene/Solr 5.3.2-RC1

2016-01-11 Thread Anshum Gupta
Please vote for the RC1 release candidate for Lucene/Solr 5.3.2 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.3.2-RC1-rev1723976 You can run the smoke tester directly with this command: python3 -u dev-tools/scripts/smokeTestRelease.py