Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Dawid Weiss
> :-) It would be great if we could ever have that, but I don’t think that’s > possible! > Most non-reproducibility in Lucene came from multi-threaded tests where the > different threads interact with > each other... And that cannot be solved in > any case without serial execution. If there are

RE: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Uwe Schindler
> > I mean "reproducibility bugs" where somehow a test doesn't reproduce > > because of bugs in LuceneTestCase :) > > Oh no -- the whole point of all this is so that we have 100% reproducibility > (is > there even a word like that?) or failures saying something like: "this random > shouldn't be s

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Dawid Weiss
> I mean "reproducibility bugs" where somehow a test doesn't reproduce > because of bugs in LuceneTestCase :) Oh no -- the whole point of all this is so that we have 100% reproducibility (is there even a word like that?) or failures saying something like: "this random shouldn't be shared and is, f

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Robert Muir
On Sat, Feb 18, 2012 at 11:41 AM, Dawid Weiss wrote: >> Personally I say 'go for it'. My only concern is that test failures >> reproduce, but this is likely just paranoia from the existing >> code...I'm guessing you have this under control. > > You mean past test failures (with known seeds)? no t

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Dawid Weiss
> Personally I say 'go for it'. My only concern is that test failures > reproduce, but this is likely just paranoia from the existing > code...I'm guessing you have this under control. You mean past test failures (with known seeds)? This won't be possible I'm afraid. Any change to how seeds are pr

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Robert Muir
On Fri, Feb 17, 2012 at 12:56 PM, Dawid Weiss wrote: > > There is a lot of code I already pruned from LuceneTestCase as part of +1: this thing is out of control and not really maintainable from just adding this test-feature and that... And currently nobody 'tests the tester' so we don't know if a

Re: [important] Refactoring of tests infrastructure.

2012-02-17 Thread Simon Willnauer
thanks david for the hard work this is awesome! simon On Fri, Feb 17, 2012 at 11:16 PM, Tommaso Teofili wrote: > Nice improvements! +1 > Tommaso > > > 2012/2/17 Dawid Weiss > >> Hi everyone, >> >> as part of this: >> https://issues.apache.org/jira/browse/LUCENE-3785 >> >> I've been working

Re: [important] Refactoring of tests infrastructure.

2012-02-17 Thread Tommaso Teofili
Nice improvements! +1 Tommaso 2012/2/17 Dawid Weiss > Hi everyone, > > as part of this: > https://issues.apache.org/jira/browse/LUCENE-3785 > > I've been working on moving away from ant-macros to a custom ANT task; > potential benefits are mentioned as part of the issue's description. > > There

Re: [important] Refactoring of tests infrastructure.

2012-02-17 Thread Martijn v Groningen
Nice work! I also like the ant test-help target (I also forget the test options quite often). Are all options going to be specified in there? I don't see the tests.iter option. Martijn On 17 February 2012 20:17, Mark Miller wrote: > Sweet. > > > On Fri, Feb 17, 2012 at 12:56 PM, Dawid Weiss > w

Re: [important] Refactoring of tests infrastructure.

2012-02-17 Thread Mark Miller
Sweet. On Fri, Feb 17, 2012 at 12:56 PM, Dawid Weiss wrote: > Hi everyone, > > as part of this: > https://issues.apache.org/jira/browse/LUCENE-3785 > > I've been working on moving away from ant-macros to a custom ANT task; > potential benefits are mentioned as part of the issue's description. > >

[important] Refactoring of tests infrastructure.

2012-02-17 Thread Dawid Weiss
Hi everyone, as part of this: https://issues.apache.org/jira/browse/LUCENE-3785 I've been working on moving away from ant-macros to a custom ANT task; potential benefits are mentioned as part of the issue's description. There is a lot of code I already pruned from LuceneTestCase as part of this