Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Robert Muir
On Fri, Feb 17, 2012 at 12:56 PM, Dawid Weiss dawid.we...@cs.put.poznan.pl wrote: There is a lot of code I already pruned from LuceneTestCase as part of +1: this thing is out of control and not really maintainable from just adding this test-feature and that... And currently nobody 'tests the

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Dawid Weiss
Personally I say 'go for it'. My only concern is that test failures reproduce, but this is likely just paranoia from the existing code...I'm guessing you have this under control. You mean past test failures (with known seeds)? This won't be possible I'm afraid. Any change to how seeds are

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Robert Muir
On Sat, Feb 18, 2012 at 11:41 AM, Dawid Weiss dawid.we...@cs.put.poznan.pl wrote: Personally I say 'go for it'. My only concern is that test failures reproduce, but this is likely just paranoia from the existing code...I'm guessing you have this under control. You mean past test failures

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Dawid Weiss
I mean reproducibility bugs where somehow a test doesn't reproduce because of bugs in LuceneTestCase :) Oh no -- the whole point of all this is so that we have 100% reproducibility (is there even a word like that?) or failures saying something like: this random shouldn't be shared and is, fix

RE: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Uwe Schindler
I mean reproducibility bugs where somehow a test doesn't reproduce because of bugs in LuceneTestCase :) Oh no -- the whole point of all this is so that we have 100% reproducibility (is there even a word like that?) or failures saying something like: this random shouldn't be shared and

Re: [important] Refactoring of tests infrastructure.

2012-02-18 Thread Dawid Weiss
:-) It would be great if we could ever have that, but I don’t think that’s possible! Most non-reproducibility in Lucene came from multi-threaded tests where the different threads interact with each other... And that cannot be solved in any case without serial execution. If there are race

[important] Refactoring of tests infrastructure.

2012-02-17 Thread Dawid Weiss
Hi everyone, as part of this: https://issues.apache.org/jira/browse/LUCENE-3785 I've been working on moving away from ant-macros to a custom ANT task; potential benefits are mentioned as part of the issue's description. There is a lot of code I already pruned from LuceneTestCase as part of this

Re: [important] Refactoring of tests infrastructure.

2012-02-17 Thread Tommaso Teofili
Nice improvements! +1 Tommaso 2012/2/17 Dawid Weiss dawid.we...@cs.put.poznan.pl Hi everyone, as part of this: https://issues.apache.org/jira/browse/LUCENE-3785 I've been working on moving away from ant-macros to a custom ANT task; potential benefits are mentioned as part of the issue's

Re: [important] Refactoring of tests infrastructure.

2012-02-17 Thread Simon Willnauer
thanks david for the hard work this is awesome! simon On Fri, Feb 17, 2012 at 11:16 PM, Tommaso Teofili tommaso.teof...@gmail.com wrote: Nice improvements! +1 Tommaso 2012/2/17 Dawid Weiss dawid.we...@cs.put.poznan.pl Hi everyone, as part of this: