[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-26 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011711#comment-13011711 ] Chris Male commented on LUCENE-2995: +1 > factor out a shared spellchecking module >

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-26 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011746#comment-13011746 ] Simon Willnauer commented on LUCENE-2995: - Robert, thanks for starting this and p

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011785#comment-13011785 ] Robert Muir commented on LUCENE-2995: - I think so? This issue just moves the code aro

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-27 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011792#comment-13011792 ] Michael McCandless commented on LUCENE-2995: This is awesome Robert! Spell c

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-27 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011835#comment-13011835 ] Dawid Weiss commented on LUCENE-2995: - Ok, great. I'll look into this this week. > f

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011836#comment-13011836 ] Robert Muir commented on LUCENE-2995: - well there's no rush on this issue, i just wan

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012461#comment-13012461 ] Grant Ingersoll commented on LUCENE-2995: - See also SOLR-2080. Spell checking, s

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012473#comment-13012473 ] Robert Muir commented on LUCENE-2995: - Grant should we call the module suggestor or s

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Andrzej Bialecki (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012476#comment-13012476 ] Andrzej Bialecki commented on LUCENE-2995: --- +1 for a "suggester" module. > fa

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012524#comment-13012524 ] Grant Ingersoll commented on LUCENE-2995: - yeah, I like suggestions or suggester

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012569#comment-13012569 ] Hoss Man commented on LUCENE-2995: -- i don't really have any better suggestions (ack, i h

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012577#comment-13012577 ] Steven Rowe commented on LUCENE-2995: - bq. maybe "query-suggester" or "term-suggester

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012596#comment-13012596 ] Steven Rowe commented on LUCENE-2995: - Or maybe "did-you-mean" or "instead"? > facto

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012600#comment-13012600 ] Michael McCandless commented on LUCENE-2995: How about just "suggest"? I don

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-03-29 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012609#comment-13012609 ] Grant Ingersoll commented on LUCENE-2995: - bq. if that's in the scope for what yo

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-04-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024887#comment-13024887 ] Michael McCandless commented on LUCENE-2995: Is this ready to go in? > f

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-04-26 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025147#comment-13025147 ] Dawid Weiss commented on LUCENE-2995: - The patch probably won't apply after I added t

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-04-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025315#comment-13025315 ] Yonik Seeley commented on LUCENE-2995: -- -1 to this for now. The interpretation of wh

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-04-26 Thread Greg Stein (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025421#comment-13025421 ] Greg Stein commented on LUCENE-2995: Yonik: that is an improper veto, and does not st

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-04-26 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025423#comment-13025423 ] Steven Rowe commented on LUCENE-2995: - bq. Yonik: that is an improper veto, and does

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-04-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025427#comment-13025427 ] Yonik Seeley commented on LUCENE-2995: -- I understand Greg's objection - given that t

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-05-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038096#comment-13038096 ] Robert Muir commented on LUCENE-2995: - these patches go completely out of date fast..

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-05-23 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038163#comment-13038163 ] Simon Willnauer commented on LUCENE-2995: - bq. I'd like to commit this one before

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-05-23 Thread Greg Stein (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038170#comment-13038170 ] Greg Stein commented on LUCENE-2995: Or rather than revert... just iterate it forward

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-05-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038198#comment-13038198 ] Robert Muir commented on LUCENE-2995: - I agree, I would much rather iterate forward i

[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module

2011-05-23 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038205#comment-13038205 ] Mark Miller commented on LUCENE-2995: - {quote}Or rather than revert... just iterate i