[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398325#comment-13398325
]
Nikola Tankovic commented on LUCENE-3312:
-
I like the solution, but we will wait
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398327#comment-13398327
]
Uwe Schindler commented on LUCENE-3312:
---
Chris: The iterator looks generics-wise
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398330#comment-13398330
]
Chris Male commented on LUCENE-3312:
Yes you're right on all accounts.
Taking a look
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398331#comment-13398331
]
Uwe Schindler commented on LUCENE-3312:
---
This is an example how to do it correct
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398348#comment-13398348
]
Nikola Tankovic commented on LUCENE-3312:
-
Can I use something like this?
{code}
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398353#comment-13398353
]
Chris Male commented on LUCENE-3312:
I think we should make it so you can use
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398356#comment-13398356
]
Uwe Schindler commented on LUCENE-3312:
---
The code I sent was just an example. We
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398361#comment-13398361
]
Nikola Tankovic commented on LUCENE-3312:
-
Maybe something like this?
{code}
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398368#comment-13398368
]
Nikola Tankovic commented on LUCENE-3312:
-
OK, so no AbstractIterator then. I
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398429#comment-13398429
]
Nikola Tankovic commented on LUCENE-3312:
-
Let me know if I can further improve
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398432#comment-13398432
]
Uwe Schindler commented on LUCENE-3312:
---
Looks fine, I would disallow remove()
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398435#comment-13398435
]
Chris Male commented on LUCENE-3312:
Why not make this a public class in util.* and
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398438#comment-13398438
]
Uwe Schindler commented on LUCENE-3312:
---
+1
Break out
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398446#comment-13398446
]
Nikola Tankovic commented on LUCENE-3312:
-
I think this is now OK, I'll put in
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13397487#comment-13397487
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
do you have any news or
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292486#comment-13292486
]
Uwe Schindler commented on LUCENE-3312:
---
I think as we have 2 interfaces, we should
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292488#comment-13292488
]
Chris Male commented on LUCENE-3312:
Yeah StoredDocument should only consist of
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292389#comment-13292389
]
Michael McCandless commented on LUCENE-3312:
I think, given the discussions
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292467#comment-13292467
]
Chris Male commented on LUCENE-3312:
Following on from that, I don't think we should
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287987#comment-13287987
]
Michael McCandless commented on LUCENE-3312:
{quote}
Separately, I think even
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287999#comment-13287999
]
Nikola Tankovic commented on LUCENE-3312:
-
bq. Nikola, before you modify any of
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13288003#comment-13288003
]
Uwe Schindler commented on LUCENE-3312:
---
I am back @ office, trying to catch up.
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287213#comment-13287213
]
Eks Dev commented on LUCENE-3312:
-
bq. My assumption is that StoredField-s will never be
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287267#comment-13287267
]
Andrzej Bialecki commented on LUCENE-3312:
---
bq. We already have Document and
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287294#comment-13287294
]
Chris Male commented on LUCENE-3312:
bq. With the Field class implementing
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287364#comment-13287364
]
Michael McCandless commented on LUCENE-3312:
I think I like this decoupling
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287380#comment-13287380
]
Chris Male commented on LUCENE-3312:
I am all for the decoupling too, just want to
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286909#comment-13286909
]
Andrzej Bialecki commented on LUCENE-3312:
---
Comments to patch 04:
*
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287136#comment-13287136
]
Chris Male commented on LUCENE-3312:
bq. index.Document is an interface, I think for
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284717#comment-13284717
]
Michael McCandless commented on LUCENE-3312:
Patch looks great!
I'm not sure
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284719#comment-13284719
]
Chris Male commented on LUCENE-3312:
{quote}
I'm not sure IndexableField should
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284721#comment-13284721
]
Nikola Tankovic commented on LUCENE-3312:
-
OK, I agree with decoupling. Can I
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284724#comment-13284724
]
Chris Male commented on LUCENE-3312:
I'm not sure that's needed. In the end
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284726#comment-13284726
]
Nikola Tankovic commented on LUCENE-3312:
-
OK, thank you! I was not sure about
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279979#comment-13279979
]
Uwe Schindler commented on LUCENE-3312:
---
Robert, I agree about that! I am just
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279704#comment-13279704
]
Uwe Schindler commented on LUCENE-3312:
---
While at the Lucene Revolution Conference,
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279786#comment-13279786
]
Yonik Seeley commented on LUCENE-3312:
--
I'd argue that TopDocs is also expert level
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279793#comment-13279793
]
Uwe Schindler commented on LUCENE-3312:
---
The TopDocs class is what
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279799#comment-13279799
]
Yonik Seeley commented on LUCENE-3312:
--
bq. The TopDocs class is what
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279810#comment-13279810
]
Uwe Schindler commented on LUCENE-3312:
---
My intention wa snot to remove it
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279811#comment-13279811
]
Robert Muir commented on LUCENE-3312:
-
But its wrong now to put an IndexSearcher in
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263826#comment-13263826
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
what's the plan to start with?
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259939#comment-13259939
]
Nikola Tankovic commented on LUCENE-3312:
-
I want to thank you guys for the
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259960#comment-13259960
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Nikola,
I am glad to work with you this
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253716#comment-13253716
]
Uwe Schindler commented on LUCENE-3312:
---
Hi Michael,
I would take the mentorship.
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246424#comment-13246424
]
Nikola Tankovic commented on LUCENE-3312:
-
Hi guys,
I submited first draft of
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241286#comment-13241286
]
Nikola Tankovic commented on LUCENE-3312:
-
Hi folks,
I think this one could be
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241354#comment-13241354
]
Michael McCandless commented on LUCENE-3312:
Hi Nikola,
I think this plus
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113984#comment-13113984
]
Chris Male commented on LUCENE-3312:
Back on this wagon for a bit.
Just wondering
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093483#comment-13093483
]
Chris Male commented on LUCENE-3312:
I'm almost done getting an initial patch for
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093499#comment-13093499
]
Simon Willnauer commented on LUCENE-3312:
-
bq. I'm almost done getting an initial
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093513#comment-13093513
]
Chris Male commented on LUCENE-3312:
Just for clarification, Packed refers to the
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093520#comment-13093520
]
Simon Willnauer commented on LUCENE-3312:
-
bq. Just for clarification, Packed
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093525#comment-13093525
]
Chris Male commented on LUCENE-3312:
Given what you say about the similarities
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093698#comment-13093698
]
Chris Male commented on LUCENE-3312:
{quote}
Good question... I think the userland
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093802#comment-13093802
]
Chris Male commented on LUCENE-3312:
So one thought would be to have a different
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093818#comment-13093818
]
Michael McCandless commented on LUCENE-3312:
I agree DocValues seem both
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093825#comment-13093825
]
Michael McCandless commented on LUCENE-3312:
bq. So one thought would be to
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092948#comment-13092948
]
Michael McCandless commented on LUCENE-3312:
bq. Due to the fact that
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093406#comment-13093406
]
Chris Male commented on LUCENE-3312:
{quote}
Good question... I think the userland
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092625#comment-13092625
]
Chris Male commented on LUCENE-3312:
With LUCENE-2308 out of the way, I've started
[
https://issues.apache.org/jira/browse/LUCENE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065180#comment-13065180
]
Simon Willnauer commented on LUCENE-3312:
-
once we are on this here we should
101 - 162 of 162 matches
Mail list logo
