[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281171#comment-15281171
]
Steve Rowe commented on LUCENE-6993:
Hi Mike, my review of your latest patch:
* All
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271376#comment-15271376
]
Steve Rowe commented on LUCENE-6993:
Thanks for persisting Mike.
I (and other JFle
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271363#comment-15271363
]
Mike Drob commented on LUCENE-6993:
---
[~steve_rowe] - I see no movement coming from the
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232236#comment-15232236
]
Steve Rowe commented on LUCENE-6993:
Hi Mike, sorry I haven't had the bandwidth to en
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232225#comment-15232225
]
Mike Drob commented on LUCENE-6993:
---
[~steve_rowe] - I pinged the jflex list about gett
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207199#comment-15207199
]
Mike Drob commented on LUCENE-6993:
---
Any updates here? I'm not sure if there is anythin
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193824#comment-15193824
]
Robert Muir commented on LUCENE-6993:
-
My mistake. thanks for the reminder. I have be
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193818#comment-15193818
]
Mike Drob commented on LUCENE-6993:
---
[~rcmuir] - did you get a chance to look at this?
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181701#comment-15181701
]
Robert Muir commented on LUCENE-6993:
-
OK, thanks for the work! I will try to review
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180171#comment-15180171
]
Mike Drob commented on LUCENE-6993:
---
There's a clean-jflex-legacy target that takes car
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180161#comment-15180161
]
Robert Muir commented on LUCENE-6993:
-
sorry, that just affects the cleaning part. Bu
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180146#comment-15180146
]
Robert Muir commented on LUCENE-6993:
-
I don't understand this change:
{code}
-
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179311#comment-15179311
]
Robert Muir commented on LUCENE-6993:
-
If that test really took 50 minutes, there may
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178886#comment-15178886
]
Steve Rowe commented on LUCENE-6993:
Mike, can you please exclude generated files fro
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178765#comment-15178765
]
Robert Muir commented on LUCENE-6993:
-
{quote}
Had issues with TestUAX29URLEmailToken
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176520#comment-15176520
]
Robert Muir commented on LUCENE-6993:
-
I wouldnt change any of the ClassicTokenizer r
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172324#comment-15172324
]
Mike Drob commented on LUCENE-6993:
---
I think I am getting to a good place here, just a
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169658#comment-15169658
]
Robert Muir commented on LUCENE-6993:
-
Yeah its tricky. I kinda view classictokenizer
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169638#comment-15169638
]
Steve Rowe commented on LUCENE-6993:
{{ClassicTokenizer}} does have direct Unicode ve
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169499#comment-15169499
]
Mike Drob commented on LUCENE-6993:
---
Yea, Uwe understood my question. I wasn't planning
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169481#comment-15169481
]
Uwe Schindler commented on LUCENE-6993:
---
bq. Uwe Schindler has written that he stil
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168956#comment-15168956
]
Steve Rowe commented on LUCENE-6993:
bq. Steve, did you get a chance to look at the b
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167852#comment-15167852
]
Mike Drob commented on LUCENE-6993:
---
Steve, did you get a chance to look at the buffer
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155160#comment-15155160
]
Steve Rowe commented on LUCENE-6993:
Yeah, the generated code underwent some changes
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155154#comment-15155154
]
Mike Drob commented on LUCENE-6993:
---
Using newer version of jflex breaks our existing m
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155062#comment-15155062
]
Steve Rowe commented on LUCENE-6993:
+1
> Update UAX29URLEmailTokenizer TLDs to late
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155035#comment-15155035
]
Robert Muir commented on LUCENE-6993:
-
I think we should be ok. As far as i understan
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154949#comment-15154949
]
Mike Drob commented on LUCENE-6993:
---
bq. I think we need to regenerate still, because t
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154936#comment-15154936
]
Mike Drob commented on LUCENE-6993:
---
Question about what is proper behaviour in terms o
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154933#comment-15154933
]
Robert Muir commented on LUCENE-6993:
-
I think we need to regenerate still, because t
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153306#comment-15153306
]
Steve Rowe commented on LUCENE-6993:
I think you're right, Mike, I don't see any defa
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153258#comment-15153258
]
Mike Drob commented on LUCENE-6993:
---
Looking at http://unicode.org/reports/tr29/#Modifi
[
https://issues.apache.org/jira/browse/LUCENE-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153209#comment-15153209
]
Steve Rowe commented on LUCENE-6993:
[~mdrob], I haven't looked at your patch yet but
33 matches
Mail list logo
