[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438608#comment-15438608
]
ASF subversion and git services commented on LUCENE-7416:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438605#comment-15438605
]
Uwe Schindler commented on LUCENE-7416:
---
OK :-) I will commit in a minute.
> Boole
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438604#comment-15438604
]
Uwe Schindler commented on LUCENE-7416:
---
OK :-) I will commit in a minute.
> Boole
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438601#comment-15438601
]
Uwe Schindler commented on LUCENE-7416:
---
[~jpountz]: did you see my latest patch? S
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438602#comment-15438602
]
Adrien Grand commented on LUCENE-7416:
--
[~thetaphi] Your change makes sense to me!
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438585#comment-15438585
]
Adrien Grand commented on LUCENE-7416:
--
bq. Well my primary concern is on 6.x (where
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438583#comment-15438583
]
ASF subversion and git services commented on LUCENE-7416:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438580#comment-15438580
]
ASF subversion and git services commented on LUCENE-7416:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437290#comment-15437290
]
Uwe Schindler commented on LUCENE-7416:
---
The inverse (any required clause is a Matc
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437246#comment-15437246
]
Uwe Schindler commented on LUCENE-7416:
---
bq. I'm not sure about these rules in part
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437186#comment-15437186
]
Uwe Schindler commented on LUCENE-7416:
---
bq. The part that rewrites boolean queries
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437161#comment-15437161
]
Robert Muir commented on LUCENE-7416:
-
Well my primary concern is on 6.x (where the t
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437152#comment-15437152
]
Adrien Grand commented on LUCENE-7416:
--
bq. I am concerned about us making the wrong
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437122#comment-15437122
]
ASF subversion and git services commented on LUCENE-7416:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437120#comment-15437120
]
Adrien Grand commented on LUCENE-7416:
--
The part that rewrites boolean queries into
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437057#comment-15437057
]
Uwe Schindler commented on LUCENE-7416:
---
I'd also think we should inverse the check
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437029#comment-15437029
]
Uwe Schindler commented on LUCENE-7416:
---
Yeah. Remove the distinct() and done.
> B
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437023#comment-15437023
]
David Smiley commented on LUCENE-7416:
--
Nice bit of Java Streams API there Uwe. But
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436951#comment-15436951
]
Uwe Schindler commented on LUCENE-7416:
---
bq. I suspect the change is safe for maste
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436926#comment-15436926
]
Robert Muir commented on LUCENE-7416:
-
Here is the fail I see on 6.x:
{noformat}
[
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436906#comment-15436906
]
Robert Muir commented on LUCENE-7416:
-
This seems to break testrandom?
I am concern
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436883#comment-15436883
]
Adrien Grand commented on LUCENE-7416:
--
Merged, thanks!
> BooleanQuery rewrite opti
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436881#comment-15436881
]
ASF subversion and git services commented on LUCENE-7416:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436879#comment-15436879
]
ASF subversion and git services commented on LUCENE-7416:
-
Commit
24 matches
Mail list logo
