[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981103#comment-15981103
]
David Smiley commented on LUCENE-7585:
--
I'm looking over this patch again.
* CONSUME_ALL_TOKENS is
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15758938#comment-15758938
]
Ahmet Arslan commented on LUCENE-7585:
--
I tried adding javadocs to fields in the interface, but it
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749577#comment-15749577
]
Ahmet Arslan commented on LUCENE-7585:
--
By saying inconsistency, I mean the strategy to retrieve
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739000#comment-15739000
]
David Smiley commented on LUCENE-7585:
--
RE documentation-lint: It appears they need javadocs then.
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737593#comment-15737593
]
Ahmet Arslan commented on LUCENE-7585:
--
Here is an excerpt from {{documentation-lint}}
{code}
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736501#comment-15736501
]
Ahmet Arslan commented on LUCENE-7585:
--
Thank you for looking into this. Initially, I was planning
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1574#comment-1574
]
Steve Rowe commented on LUCENE-7585:
The patch appears to be against a non-existent version of
[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732930#comment-15732930
]
David Smiley commented on LUCENE-7585:
--
+1 LGTM. The only thing I'd change is
