[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504577#comment-16504577
]
Alan Woodward commented on LUCENE-8273:
---
I'll let RandomChains stew for another 24 hours, but I
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504576#comment-16504576
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504575#comment-16504575
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504560#comment-16504560
]
Alan Woodward commented on LUCENE-8273:
---
Yeah, it's the same issue as LUCENE-4170. I'll add it to
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504554#comment-16504554
]
Robert Muir commented on LUCENE-8273:
-
If shinglefilter is the buggy one it should be banned from
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504540#comment-16504540
]
Alan Woodward commented on LUCENE-8273:
---
Both of these failures are due to ShingleFilter not
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504369#comment-16504369
]
Alan Woodward commented on LUCENE-8273:
---
A couple more failing seeds:
{code}
Suite:
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493678#comment-16493678
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493674#comment-16493674
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491222#comment-16491222
]
Steve Rowe commented on LUCENE-8273:
Not sure if this is the same sort of problem you already know
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489903#comment-16489903
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489904#comment-16489904
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486886#comment-16486886
]
Alan Woodward commented on LUCENE-8273:
---
The elastic CI has found some reproducing seeds in
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483624#comment-16483624
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483625#comment-16483625
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482583#comment-16482583
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482582#comment-16482582
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482085#comment-16482085
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482084#comment-16482084
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482079#comment-16482079
]
Steve Rowe commented on LUCENE-8273:
Attached remaining parts from my -rebased patch. Tests and
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480717#comment-16480717
]
Steve Rowe commented on LUCENE-8273:
{quote}
Would you like me to make a new patch from the other
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480712#comment-16480712
]
Alan Woodward commented on LUCENE-8273:
---
bq. Would you like me to make a new patch from the other
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480698#comment-16480698
]
Steve Rowe commented on LUCENE-8273:
bq. Attached is a patch that includes Steve Rowe's test
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480594#comment-16480594
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480595#comment-16480595
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480574#comment-16480574
]
Alan Woodward commented on LUCENE-8273:
---
Nope, that's a relic from a failed attempt to fix
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480559#comment-16480559
]
Robert Muir commented on LUCENE-8273:
-
is the TokenBuffer class in the patch actually used?
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480549#comment-16480549
]
Alan Woodward commented on LUCENE-8273:
---
I think I have now chased down the last failures, all
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478208#comment-16478208
]
Robert Muir commented on LUCENE-8273:
-
{quote}
In {{TestConditionalFilter}}, converted most
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478177#comment-16478177
]
Steve Rowe commented on LUCENE-8273:
bq. I'm attaching my latest patch, which includes the failing
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478105#comment-16478105
]
Steve Rowe commented on LUCENE-8273:
bq. Every time I think I have this fixed, TestRandomChains finds
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477910#comment-16477910
]
Alan Woodward commented on LUCENE-8273:
---
Every time I think I have this fixed, TestRandomChains
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477590#comment-16477590
]
Steve Rowe commented on LUCENE-8273:
Attaching an updated version of my part2 patch. Changes:
*
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477116#comment-16477116
]
Alan Woodward commented on LUCENE-8273:
---
There's a bug in the way that tokens are buffered if the
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475166#comment-16475166
]
Steve Rowe commented on LUCENE-8273:
I stumbled on what looks like a {{ProtectedTermFilter}} bug when
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474120#comment-16474120
]
Steve Rowe commented on LUCENE-8273:
Okay, I'll finish up the remaining work today.
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473985#comment-16473985
]
Alan Woodward commented on LUCENE-8273:
---
Thanks Steve, your patch looks great.
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472873#comment-16472873
]
Steve Rowe commented on LUCENE-8273:
I've belatedly reviewed the changes committed under this issue -
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472733#comment-16472733
]
Robert Muir commented on LUCENE-8273:
-
maybe ConditionalTokenFilter's toString() can be improved
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472709#comment-16472709
]
Alan Woodward commented on LUCENE-8273:
---
Some more failures in testRandomChains:
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472594#comment-16472594
]
Michael McCandless commented on LUCENE-8273:
+1, very cool addition to Lucene!
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472342#comment-16472342
]
Mike Sokolov commented on LUCENE-8273:
--
Yes, thanks [~romseygeek] this is a great addition
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472235#comment-16472235
]
Robert Muir commented on LUCENE-8273:
-
I opened LUCENE-8308, I think we have to work our way through
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472206#comment-16472206
]
Alan Woodward commented on LUCENE-8273:
---
bq. Thanks for debugging the failure
There will be more,
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472184#comment-16472184
]
Robert Muir commented on LUCENE-8273:
-
Thanks for debugging the failure: TestRandomChains is cruel
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471991#comment-16471991
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471992#comment-16471992
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471900#comment-16471900
]
Alan Woodward commented on LUCENE-8273:
---
The elasticsearch CI had some failures due to this:
{code}
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471732#comment-16471732
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471731#comment-16471731
]
ASF subversion and git services commented on LUCENE-8273:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468547#comment-16468547
]
Alan Woodward commented on LUCENE-8273:
---
New patch, {{whenTerm()}} now takes {{Predicate}}, and
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467407#comment-16467407
]
Robert Muir commented on LUCENE-8273:
-
For the new TermExclusionFilterFactory:
{code}
public static
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467353#comment-16467353
]
Alan Woodward commented on LUCENE-8273:
---
Thanks David, I'll do that. Will commit later on if
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466309#comment-16466309
]
David Smiley commented on LUCENE-8273:
--
Looks good Alan.
* Maybe make {{ConditionBuilder
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466012#comment-16466012
]
Alan Woodward commented on LUCENE-8273:
---
Patch, up to date with master and passing all tests and
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459643#comment-16459643
]
Alan Woodward commented on LUCENE-8273:
---
bq. it seems you need to make the
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459564#comment-16459564
]
Alan Woodward commented on LUCENE-8273:
---
Updated patch. {{ConditionalTokenFilterFactory}} is now a
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459103#comment-16459103
]
Steve Rowe commented on LUCENE-8273:
bq. {{if}} is a keyword, unfortunately, so that won't work.
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458569#comment-16458569
]
Robert Muir commented on LUCENE-8273:
-
sounds good. yeah i know the resource stuff/keywork marking is
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458550#comment-16458550
]
Alan Woodward commented on LUCENE-8273:
---
{{if}} is a keyword, unfortunately, so that won't work.
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458507#comment-16458507
]
Robert Muir commented on LUCENE-8273:
-
I'm also curious about common use cases where the condition is
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458501#comment-16458501
]
Robert Muir commented on LUCENE-8273:
-
I like the custom analyzer integration. Can we rename
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458472#comment-16458472
]
Alan Woodward commented on LUCENE-8273:
---
[~msoko...@gmail.com] in that case, the filter would still
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458469#comment-16458469
]
Alan Woodward commented on LUCENE-8273:
---
And here's a patch that integrates it into CustomAnalyzer
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457066#comment-16457066
]
Mike Sokolov commented on LUCENE-8273:
--
Cool! I haven't read the patch carefully, but I looked at
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456717#comment-16456717
]
Alan Woodward commented on LUCENE-8273:
---
I think I fixed it - attached is a patch including a test
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455543#comment-16455543
]
Robert Muir commented on LUCENE-8273:
-
just imaging scenarios more, its probably useful if the thing
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453852#comment-16453852
]
Robert Muir commented on LUCENE-8273:
-
I feel like the OneTimeWrapper you have is close, it just
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453818#comment-16453818
]
Robert Muir commented on LUCENE-8273:
-
i mean in the worst case, you could make it "correct" by using
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453814#comment-16453814
]
Robert Muir commented on LUCENE-8273:
-
ok i get it, so basically the filter switches between two
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453807#comment-16453807
]
Alan Woodward commented on LUCENE-8273:
---
Yes, exactly that.
> Add a ConditionalTokenFilter
>
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453806#comment-16453806
]
Robert Muir commented on LUCENE-8273:
-
So you mean that the problem is not related to buffering
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452676#comment-16452676
]
Alan Woodward commented on LUCENE-8273:
---
bq. You mean any filter that uses captureState?
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452431#comment-16452431
]
Mike Sokolov commented on LUCENE-8273:
--
Hmm right. Well you might be able to use that idea to detect
[
https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452428#comment-16452428
]
Robert Muir commented on LUCENE-8273:
-
{quote}
This latter one is a bit clunky, as this TokenFilter
75 matches
Mail list logo
