[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620376#comment-16620376
]
ASF subversion and git services commented on LUCENE-8352:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619493#comment-16619493
]
David Smiley commented on LUCENE-8352:
--
Looks good Alan. Thanks for the CC.
> Make
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619349#comment-16619349
]
Alan Woodward commented on LUCENE-8352:
---
Patch with fixed javadocs. I ended up having to change
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619046#comment-16619046
]
Adrien Grand commented on LUCENE-8352:
--
Oops indeed. I was considering deprecating it to make
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619038#comment-16619038
]
Alan Woodward commented on LUCENE-8352:
---
> keep the ctor that takes a Tokenizer on 7.x but make
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619000#comment-16619000
]
Alan Woodward commented on LUCENE-8352:
---
Here's a patch implementing [~jpountz]'s idea. I renamed
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618834#comment-16618834
]
Adrien Grand commented on LUCENE-8352:
--
+1 Great to see that the patch is simpler than I expected.
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509726#comment-16509726
]
Mike Sokolov commented on LUCENE-8352:
--
bq So maybe we could remove this setReader method, make
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509635#comment-16509635
]
Mark Harwood commented on LUCENE-8352:
--
My use case was a bit special. I had a custom reader that
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509601#comment-16509601
]
Adrien Grand commented on LUCENE-8352:
--
Good catch [~markharw...@yahoo.co.uk]. I agree this is a
[
https://issues.apache.org/jira/browse/LUCENE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509545#comment-16509545
]
Mike Sokolov commented on LUCENE-8352:
--
I'm currently relying on a custom TokenStreamComponents,
11 matches
Mail list logo