[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602433#comment-16602433
]
ASF subversion and git services commented on LUCENE-8422:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602432#comment-16602432
]
ASF subversion and git services commented on LUCENE-8422:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602273#comment-16602273
]
Adrien Grand commented on LUCENE-8422:
--
+1
> Add Matches iteration to interval queries
>
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602241#comment-16602241
]
Alan Woodward commented on LUCENE-8422:
---
Updated patch, moving the various helper functions to
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602199#comment-16602199
]
Alan Woodward commented on LUCENE-8422:
---
+1 to MatchesUtils, there are a couple of static
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602180#comment-16602180
]
Adrien Grand commented on LUCENE-8422:
--
I was thinking of something like having a MatchesUtils
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602173#comment-16602173
]
Alan Woodward commented on LUCENE-8422:
---
MatchesIterator#disjunction could move to Matches, maybe?
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602123#comment-16602123
]
Adrien Grand commented on LUCENE-8422:
--
bq. All sources return null from MatchesIterator#getQuery()
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602118#comment-16602118
]
Adrien Grand commented on LUCENE-8422:
--
+1 to the patch in general, only two minor comments:
-
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598475#comment-16598475
]
Alan Woodward commented on LUCENE-8422:
---
Here's a patch that adds IntervalsSource#matches instead.
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591393#comment-16591393
]
Adrien Grand commented on LUCENE-8422:
--
I see how putting the logic in IntervalIterator makes
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587714#comment-16587714
]
Alan Woodward commented on LUCENE-8422:
---
If we didn't need to worry about submatches, then
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559870#comment-16559870
]
Adrien Grand commented on LUCENE-8422:
--
I'm curious whether you considered adding eg.
[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552585#comment-16552585
]
Alan Woodward commented on LUCENE-8422:
---
Here is a patch that adds a collection interface to
14 matches
Mail list logo
