[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723186#comment-16723186
]
Nicholas Knize commented on LUCENE-8581:
{quote}I got you, new patch rotates edg
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723189#comment-16723189
]
Adrien Grand commented on LUCENE-8581:
--
Then let's also rename constants so that th
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723224#comment-16723224
]
Nicholas Knize commented on LUCENE-8581:
{quote}Then let's also rename constants
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723352#comment-16723352
]
Nicholas Knize commented on LUCENE-8581:
Everything's looking good. +1 to merge
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724178#comment-16724178
]
Nicholas Knize commented on LUCENE-8581:
Thanks for all of your work on this [~i
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724186#comment-16724186
]
Adrien Grand commented on LUCENE-8581:
--
+1
> Change LatLonShape encoding to use 4
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724781#comment-16724781
]
Adrien Grand commented on LUCENE-8581:
--
According to luceneutil this change gives 8
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725086#comment-16725086
]
David Smiley commented on LUCENE-8581:
--
Great work!
I was looking through the code
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726112#comment-16726112
]
Adrien Grand commented on LUCENE-8581:
--
bq. Why is Rectangle2D referring to LatLonS
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726177#comment-16726177
]
David Smiley commented on LUCENE-8581:
--
It may be that there is some logic/encoding
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734770#comment-16734770
]
David Smiley commented on LUCENE-8581:
--
I attached a patch about this.
> Change La
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744792#comment-16744792
]
Adrien Grand commented on LUCENE-8581:
--
+1
> Change LatLonShape encoding to use 4
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745072#comment-16745072
]
ASF subversion and git services commented on LUCENE-8581:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745080#comment-16745080
]
ASF subversion and git services commented on LUCENE-8581:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745085#comment-16745085
]
ASF subversion and git services commented on LUCENE-8581:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708434#comment-16708434
]
Ignacio Vera commented on LUCENE-8581:
--
{quote}I think it would be good to keep the
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708520#comment-16708520
]
Adrien Grand commented on LUCENE-8581:
--
It seems that giving all triangles the same
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1670#comment-1670
]
Ignacio Vera commented on LUCENE-8581:
--
{quote}it seems that giving all triangles
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709022#comment-16709022
]
Nicholas Knize commented on LUCENE-8581:
{quote}Just for my curiosity. when crea
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710425#comment-16710425
]
Lucene/Solr QA commented on LUCENE-8581:
| (x) *{color:red}-1 overall{color}* |
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718189#comment-16718189
]
Lucene/Solr QA commented on LUCENE-8581:
| (/) *{color:green}+1 overall{color}*
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719097#comment-16719097
]
Adrien Grand commented on LUCENE-8581:
--
bq. The last thing remaining is which orien
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721336#comment-16721336
]
Adrien Grand commented on LUCENE-8581:
--
+1 Let's get [~nknize]'s opinion about whet
[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707612#comment-16707612
]
Nicholas Knize commented on LUCENE-8581:
Thanks [~ivera]
{{setTriangleValue((a
24 matches
Mail list logo
