[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548398#comment-16548398
]
ASF subversion and git services commented on SOLR-11453:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548394#comment-16548394
]
ASF subversion and git services commented on SOLR-11453:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508118#comment-16508118
]
Varun Thacker commented on SOLR-11453:
--
Good catch! Yeah I didn't remember that there was a ref
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508109#comment-16508109
]
Cassandra Targett commented on SOLR-11453:
--
[~elyograg], [~varunthacker] - There was no Ref
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502578#comment-16502578
]
ASF subversion and git services commented on SOLR-11453:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502573#comment-16502573
]
ASF subversion and git services commented on SOLR-11453:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499110#comment-16499110
]
Shawn Heisey commented on SOLR-11453:
-
I've got too much happening today, or I would have just taken
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499106#comment-16499106
]
Varun Thacker commented on SOLR-11453:
--
Hi Shawn,
Thanks for pointing it out. Do you want to just
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499102#comment-16499102
]
Shawn Heisey commented on SOLR-11453:
-
There's a tiny problem in CHANGES.txt ... in the "Upgrade
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492915#comment-16492915
]
ASF subversion and git services commented on SOLR-11453:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492917#comment-16492917
]
ASF subversion and git services commented on SOLR-11453:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492888#comment-16492888
]
Varun Thacker commented on SOLR-11453:
--
Updated patch folding in changes from Shawn's patch. Running
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484356#comment-16484356
]
Shawn Heisey commented on SOLR-11453:
-
I have been having a severe lack of free time lately. Haven't
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484153#comment-16484153
]
Varun Thacker commented on SOLR-11453:
--
Hi Shawn,
Do you want me to pick this up and commit it or is
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470668#comment-16470668
]
Atita Arora commented on SOLR-11453:
Agreed [~elyograg] I think that was the initial requirement we
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470647#comment-16470647
]
Varun Thacker commented on SOLR-11453:
--
Fair enough. We can also call it out in the release notes.
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470628#comment-16470628
]
Shawn Heisey commented on SOLR-11453:
-
bq. We can do that on master? For 7.x I think it's a good idea
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469963#comment-16469963
]
Varun Thacker commented on SOLR-11453:
--
{quote}For the log4j2.xml config, are you thinking of
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469780#comment-16469780
]
Shawn Heisey commented on SOLR-11453:
-
Having a separate logfile for slow requests turned on by
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469732#comment-16469732
]
Shawn Heisey commented on SOLR-11453:
-
A separate issue for sysprop usage would be a good idea.
Also
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469332#comment-16469332
]
Varun Thacker commented on SOLR-11453:
--
Hi [~elyograg]
Just wanted to know what's the plan here?
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468332#comment-16468332
]
Shawn Heisey commented on SOLR-11453:
-
That's a good question on the sysprop. I have no idea how many
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468324#comment-16468324
]
Shawn Heisey commented on SOLR-11453:
-
Looks like I didn't get the last of the changes actually saved
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468319#comment-16468319
]
Varun Thacker commented on SOLR-11453:
--
{quote}I have plans to try and create a log4j config that
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468316#comment-16468316
]
Shawn Heisey commented on SOLR-11453:
-
New version of the informational patch. Summary of things
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468265#comment-16468265
]
Varun Thacker commented on SOLR-11453:
--
Hi Shawn,
Thanks for working on the patch. Few things I
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465259#comment-16465259
]
Ralph Goers commented on SOLR-11453:
The Log4j ScriptManager makes the Log4j Configuration and
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465231#comment-16465231
]
Shawn Heisey commented on SOLR-11453:
-
[~ralph.go...@dslextreme.com], thanks for the docs. There is a
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465224#comment-16465224
]
Shawn Heisey commented on SOLR-11453:
-
[~varunthacker], I'm going to attach the code patch I was
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464860#comment-16464860
]
Varun Thacker commented on SOLR-11453:
--
Quick patch , where we create a new solr_slow_requests.log
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464852#comment-16464852
]
Ralph Goers commented on SOLR-11453:
Yes, as the implementation of those shows, it is entirely
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464834#comment-16464834
]
Shawn Heisey commented on SOLR-11453:
-
Those appenders look very interesting. Sounds like we could
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464689#comment-16464689
]
Ralph Goers commented on SOLR-11453:
If you want to have a configuration that is only enabled under
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464534#comment-16464534
]
Shawn Heisey commented on SOLR-11453:
-
The rollover size value in the default config used to be 4MB,
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464499#comment-16464499
]
Remko Popma commented on SOLR-11453:
[~elyograg] Thanks for showing the full config. I notice that
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464476#comment-16464476
]
Shawn Heisey commented on SOLR-11453:
-
Should we keep the slow query logging at WARN? Initial thought
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464473#comment-16464473
]
Shawn Heisey commented on SOLR-11453:
-
This is the log4j2 config that Solr 7.4 will have out of the
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464452#comment-16464452
]
Remko Popma commented on SOLR-11453:
It may be easier to discuss here rather than on the log4j mailing
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464433#comment-16464433
]
Shawn Heisey commented on SOLR-11453:
-
I have revived the thread on the log4j mailing list to learn
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464166#comment-16464166
]
Varun Thacker commented on SOLR-11453:
--
Hi Shawn,
Is this still on your radar. Now that we have
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198983#comment-16198983
]
Shawn Heisey commented on SOLR-11453:
-
Linking to the log4j upgrade.
> Create separate logger for
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198978#comment-16198978
]
Shawn Heisey commented on SOLR-11453:
-
The log4j response basically was "you're using an end of life
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197727#comment-16197727
]
Shawn Heisey commented on SOLR-11453:
-
I haven't been able to figure out how to get it logging to a
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197486#comment-16197486
]
Erick Erickson commented on SOLR-11453:
---
bq: I should put some commented lines in log4j.properties
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197414#comment-16197414
]
Uwe Schindler commented on SOLR-11453:
--
I agree with the code change. This makes it easier to filter
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197411#comment-16197411
]
Shawn Heisey commented on SOLR-11453:
-
Along with the code change, I should put some commented lines
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197409#comment-16197409
]
Tomás Fernández Löbbe commented on SOLR-11453:
--
bq. SlowRequest logger won't need the "slow:
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197405#comment-16197405
]
Shawn Heisey commented on SOLR-11453:
-
bq. Before going here can't you configure specific classes to
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197403#comment-16197403
]
Mike Drob commented on SOLR-11453:
--
SlowRequest logger won't need the "slow: " log prefix, I think.
[
https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197390#comment-16197390
]
Erick Erickson commented on SOLR-11453:
---
Before going here can't you configure specific classes to
50 matches
Mail list logo
