[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs and set Buffer to "false"

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856998#comment-16856998 ] Christine Poerschke commented on SOLR-11718: Hello. Could we confirm here if

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs and set Buffer to "false"

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642466#comment-16642466 ] Amrit Sarkar commented on SOLR-11718: - Thanks Varun for reviewing. The patch is good,

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs and set Buffer to "false"

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637776#comment-16637776 ] Lucene/Solr QA commented on SOLR-11718: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs and set Buffer to "false"

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637469#comment-16637469 ] Varun Thacker commented on SOLR-11718: -- Thanks Amrit!  I've gone and made some more

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs and set Buffer to "false"

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626881#comment-16626881 ] Lucene/Solr QA commented on SOLR-11718: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527286#comment-16527286 ] Amrit Sarkar commented on SOLR-11718: - Was looking into the patch and why Buffer is i

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525868#comment-16525868 ] Lucene/Solr QA commented on SOLR-11718: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443297#comment-16443297 ] Lucene/Solr QA commented on SOLR-11718: --- | (x) *{color:red}-1 overall{color}* | \\ \

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437032#comment-16437032 ] Amrit Sarkar commented on SOLR-11718: - Patch uploaded to the master. > Deprecate CDCR

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337871#comment-16337871 ] Amrit Sarkar commented on SOLR-11718: - Patch uploaded with minor corrections. > Depre

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327087#comment-16327087 ] Amrit Sarkar commented on SOLR-11718: - Patch attached considering all the above points

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326644#comment-16326644 ] Amrit Sarkar commented on SOLR-11718: - [~varunthacker], bq. We should remove the chec

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326630#comment-16326630 ] Varun Thacker commented on SOLR-11718: -- Hi Amrit, I'm looking at the v3 version of y

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323498#comment-16323498 ] Amrit Sarkar commented on SOLR-11718: - Modified patch with Varun's recommendation: {{S

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322103#comment-16322103 ] Amrit Sarkar commented on SOLR-11718: - [~varunthacker] Thank you for the feedback. b

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321269#comment-16321269 ] Varun Thacker commented on SOLR-11718: -- Hi Amrit, Thanks for picking up this Jira F

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316209#comment-16316209 ] Amrit Sarkar commented on SOLR-11718: - PFA updated SOLR-11718.patch which takes care f

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312936#comment-16312936 ] Amrit Sarkar commented on SOLR-11718: - Patch attached with documentation changes but {

[jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs

[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283114#comment-16283114 ] Varun Thacker commented on SOLR-11718: -- We should do the following here : - remove t