[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-10-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637182#comment-16637182 ] ASF subversion and git services commented on SOLR-12767: Commit

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-10-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637180#comment-16637180 ] ASF subversion and git services commented on SOLR-12767: Commit

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-28 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632608#comment-16632608 ] Anshum Gupta commented on SOLR-12767: - Looks good to me. Here are a few minor (nit-pick?)

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-26 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629211#comment-16629211 ] Tomás Fernández Löbbe commented on SOLR-12767: -- Thanks for the feedback, I'll do that. I'll

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629122#comment-16629122 ] Mark Miller commented on SOLR-12767: Patch looks good. I'd also enter this in CHANGES as a bug

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-25 Thread Anshum Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628146#comment-16628146 ] Anshum Gupta commented on SOLR-12767: - I haven't looked at the patch but I like the idea. min_rf

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-25 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628055#comment-16628055 ] Mark Miller commented on SOLR-12767: I had a vision for min_rf and it seems to me the current

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-25 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628051#comment-16628051 ] Tomás Fernández Löbbe commented on SOLR-12767: -- The patch attached doesn't add much of a

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-13 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613410#comment-16613410 ] David Smiley commented on SOLR-12767: - Cool. I'm reminded of my comment about being confused by

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2018-09-12 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613036#comment-16613036 ] Erick Erickson commented on SOLR-12767: --- Ah, ok. I vaguely remember being in that code at one point