[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193155#comment-13193155
]
Jan Høydahl commented on SOLR-2202:
---
Greg, I'm gonna look at this again and try to prepar
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193208#comment-13193208
]
Greg Fodor commented on SOLR-2202:
--
Hey Jan, I can try to take a crack at it this week. Th
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193467#comment-13193467
]
Jan Høydahl commented on SOLR-2202:
---
My biggest wish is human-friendly decimal support e.
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193512#comment-13193512
]
Ryan McKinley commented on SOLR-2202:
-
bq. My biggest wish is human-friendly decimal su
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195393#comment-13195393
]
Greg Fodor commented on SOLR-2202:
--
Hey Jan, I took a crack at making your proposed change
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195400#comment-13195400
]
Greg Fodor commented on SOLR-2202:
--
Success! I was calling parse() twice in the call chain
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195405#comment-13195405
]
Greg Fodor commented on SOLR-2202:
--
Wiki updated
> Money FieldType
>
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195477#comment-13195477
]
Jan Høydahl commented on SOLR-2202:
---
This is great! I'll see if I can test it a bit more
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199198#comment-13199198
]
Greg Fodor commented on SOLR-2202:
--
I have no problems with renaming it -- at the time I s
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199231#comment-13199231
]
Jan Høydahl commented on SOLR-2202:
---
Other opinions on the naming? Or other blockers for
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210538#comment-13210538
]
Greg Fodor commented on SOLR-2202:
--
Any updates on this?
> Money FieldTy
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210893#comment-13210893
]
Jan Høydahl commented on SOLR-2202:
---
Had no chance to get back to this yet. Afraid I won'
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215607#comment-13215607
]
Erik Hatcher commented on SOLR-2202:
d) CurrencyField - that's more consistent with the
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225493#comment-13225493
]
Hoss Man commented on SOLR-2202:
a) CurrencyField (and by extension "CurrencyValue") gets m
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225595#comment-13225595
]
Jan Høydahl commented on SOLR-2202:
---
Andrew, please see SOLR-3218 for faceting support.
I
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051955#comment-13051955
]
Jan Høydahl commented on SOLR-2202:
---
Any interest in reviving this and work towards commi
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115375#comment-13115375
]
Jan Høydahl commented on SOLR-2202:
---
Greg, do you have an updatet patch for this one? We'
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115803#comment-13115803
]
Greg Fodor commented on SOLR-2202:
--
Hey Jan, awesome! The latest patch is the implementati
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115807#comment-13115807
]
Greg Fodor commented on SOLR-2202:
--
I will actually take a crack at merging this into Solr
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115837#comment-13115837
]
Steven Rowe commented on SOLR-2202:
---
Greg, there have been structural changes since your
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116269#comment-13116269
]
Greg Fodor commented on SOLR-2202:
--
Yeah, this patch is a total mess now. I will see if ot
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116290#comment-13116290
]
Greg Fodor commented on SOLR-2202:
--
I decided to roll up my sleeves, wasn't as bad as I th
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116638#comment-13116638
]
Greg Fodor commented on SOLR-2202:
--
Hey Jan, thanks for cleaning things up!
To answer you
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116647#comment-13116647
]
Greg Fodor commented on SOLR-2202:
--
I noticed a reference to currency.xml.drift.properties
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116664#comment-13116664
]
Greg Fodor commented on SOLR-2202:
--
wiki updated to reflect the answers above
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116722#comment-13116722
]
Simon Rosenthal commented on SOLR-2202:
---
bq. One enhancement we are likely to make i
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116735#comment-13116735
]
Greg Fodor commented on SOLR-2202:
--
This is excellent news! Thanks a bunch. This is an iss
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116897#comment-13116897
]
Lance Norskog commented on SOLR-2202:
-
+1 on getting this in. It's a cool feature that
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117090#comment-13117090
]
Jan Høydahl commented on SOLR-2202:
---
Greg,
bq. Can you explain in a bit more detail what
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117387#comment-13117387
]
Greg Fodor commented on SOLR-2202:
--
Hm. It could be tricky to allow decimal input, no? Rig
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117639#comment-13117639
]
Jan Høydahl commented on SOLR-2202:
---
I'm no currency expert, but it feels wrong to put th
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117648#comment-13117648
]
Greg Fodor commented on SOLR-2202:
--
Actually that makes sense. I was getting my wires cros
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925338#action_12925338
]
Robert Muir commented on SOLR-2202:
---
Hello, taking a look at the code, is there any specif
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925340#action_12925340
]
Uwe Schindler commented on SOLR-2202:
-
The other question is, why you don't use NumericF
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925342#action_12925342
]
Uwe Schindler commented on SOLR-2202:
-
Here some infos, why it's wrong to use double/flo
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925344#action_12925344
]
Robert Muir commented on SOLR-2202:
---
bq. Here some infos, why it's wrong to use double/flo
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925471#action_12925471
]
Uwe Schindler commented on SOLR-2202:
-
bq. Looking further I'm not really sure I underst
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925473#action_12925473
]
Robert Muir commented on SOLR-2202:
---
Hi Greg, these are excellent questions... I'll reply
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925475#action_12925475
]
Robert Muir commented on SOLR-2202:
---
Sorry for editing my response above, i just wanted to
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925488#action_12925488
]
Greg Fodor commented on SOLR-2202:
--
Uwe: apologies if I'm missing something, but I'm still
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925493#action_12925493
]
Greg Fodor commented on SOLR-2202:
--
I guess I should clarify my comment re: TrieField. I gu
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925494#action_12925494
]
Robert Muir commented on SOLR-2202:
---
bq. However, I think including the currency code as p
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925501#action_12925501
]
Greg Fodor commented on SOLR-2202:
--
I think the fact that we *do* have a locale-independent
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925504#action_12925504
]
Robert Muir commented on SOLR-2202:
---
bq. It's not pretty to look at, but it at least would
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925511#action_12925511
]
Uwe Schindler commented on SOLR-2202:
-
bq. I guess I should clarify my comment re: TrieF
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925514#action_12925514
]
Greg Fodor commented on SOLR-2202:
--
Ok, great, thanks Uwe. I will make a pass to incorporat
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925560#action_12925560
]
Greg Fodor commented on SOLR-2202:
--
I've attached an updated patch. In the process of remov
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926221#action_12926221
]
Lance Norskog commented on SOLR-2202:
-
This is a really interesting concept. Do other se
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926974#action_12926974
]
Robert Muir commented on SOLR-2202:
---
Greg, one more nitpick:
I think the reloadCurrencyCo
[
https://issues.apache.org/jira/browse/SOLR-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971386#action_12971386
]
Greg Fodor commented on SOLR-2202:
--
Etsy has been running this patch in production for a li
50 matches
Mail list logo
