[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038993#comment-13038993 ] Simon Willnauer commented on SOLR-2530: --- bq. I am backporting this to 3.x now not nee

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038875#comment-13038875 ] Simon Willnauer commented on SOLR-2530: --- I am backporting this to 3.x now > Remove N

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038852#comment-13038852 ] Simon Willnauer commented on SOLR-2530: --- bq. I've looked into this in the past - its

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038817#comment-13038817 ] Mark Miller commented on SOLR-2530: --- bq. nocommit in SimpleFacets with a TODO. I've look

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038784#comment-13038784 ] Simon Willnauer commented on SOLR-2530: --- yeah I wonder if yonik could look at this no

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038777#comment-13038777 ] Robert Muir commented on SOLR-2530: --- bq. I think this is ready though, all tests pass. L

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037631#comment-13037631 ] Simon Willnauer commented on SOLR-2530: --- bq. I think its probably best to avoid this

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037607#comment-13037607 ] Robert Muir commented on SOLR-2530: --- Also, it seems in a few places in Solr, there was a

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036851#comment-13036851 ] Simon Willnauer commented on SOLR-2530: --- seem like CharsRef is not in the patch... I

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036240#comment-13036240 ] Yonik Seeley commented on SOLR-2530: Minor nit: renaming bigTerm to UnicodeUtil.BIG_UTF

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036224#comment-13036224 ] Robert Muir commented on SOLR-2530: --- My recommendation: add CharsRef. We already have Byt

[jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType

[ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036219#comment-13036219 ] Yonik Seeley commented on SOLR-2530: There are some efficiency losses here: - A reusabl