[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780615#comment-15780615
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764246#comment-15764246
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763710#comment-15763710
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761261#comment-15761261
]
Shalin Shekhar Mangar commented on SOLR-4735:
-
[~dsmiley] - I didn't know that commits to
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761133#comment-15761133
]
Andrzej Bialecki commented on SOLR-4735:
-
Wilco. Sorry about that, I was wondering why this is so
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761126#comment-15761126
]
David Smiley commented on SOLR-4735:
In the future, please create branches named SOLR- (or
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761083#comment-15761083
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761049#comment-15761049
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754834#comment-15754834
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745982#comment-15745982
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745981#comment-15745981
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743325#comment-15743325
]
Jeff Wartes commented on SOLR-4735:
---
Understood, and not all cores are part of a collection. But if it
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743223#comment-15743223
]
Andrzej Bialecki commented on SOLR-4735:
-
Hmm, not blindly, you could have a collection named
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743207#comment-15743207
]
Jeff Wartes commented on SOLR-4735:
---
That's almost perfect. Can we replace those underscores with dots?
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743201#comment-15743201
]
Jeff Wartes commented on SOLR-4735:
---
Oh, one thing just occurred to me though. There are essentially two
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743199#comment-15743199
]
Andrzej Bialecki commented on SOLR-4735:
-
Metric names already contain collection name in their
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743174#comment-15743174
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742740#comment-15742740
]
Jeff Wartes commented on SOLR-4735:
---
I've fallen behind keeping up with your changes, but for what it's
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742676#comment-15742676
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742673#comment-15742673
]
Andrzej Bialecki commented on SOLR-4735:
-
After discussing this with Shalin I came to conclusion
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741835#comment-15741835
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737567#comment-15737567
]
Andrzej Bialecki commented on SOLR-4735:
-
There is one important issue that is still unsolved in
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733233#comment-15733233
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731828#comment-15731828
]
Shalin Shekhar Mangar commented on SOLR-4735:
-
bq. Didn't Shalin already add a /admin/metrics
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731809#comment-15731809
]
Ramkumar Aiyengar commented on SOLR-4735:
-
Didn't Shalin already add a /admin/metrics endpoint for
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729770#comment-15729770
]
Andrzej Bialecki commented on SOLR-4735:
-
Brief summary of the current state on the branch:
*
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729588#comment-15729588
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728672#comment-15728672
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722085#comment-15722085
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716772#comment-15716772
]
Jeff Wartes commented on SOLR-4735:
---
That seems pretty viable too. As I mentioned, the memory overhead of
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716698#comment-15716698
]
Kelvin Wong commented on SOLR-4735:
---
Hmm wouldn't these aggregate registries defeat the point of keeping
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716247#comment-15716247
]
Jeff Wartes commented on SOLR-4735:
---
Yeah, I get that. I like this line of thought because it means we
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715972#comment-15715972
]
Andrzej Bialecki commented on SOLR-4735:
-
bq. `MetricRegistry` is really just a bunch of
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715931#comment-15715931
]
Andrzej Bialecki commented on SOLR-4735:
-
bq. Will we be instantiating separate reporters for each
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715880#comment-15715880
]
Jeff Wartes commented on SOLR-4735:
---
`MetricRegistry` is really just a bunch of convenience methods and
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715107#comment-15715107
]
Kelvin Wong commented on SOLR-4735:
---
Hi Andrzej,
{quote}
I added a notion of "group" of metrics, which
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712011#comment-15712011
]
Andrzej Bialecki commented on SOLR-4735:
-
Thanks Kelvin for creating the new tests! You beat me to
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711969#comment-15711969
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709559#comment-15709559
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709129#comment-15709129
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709123#comment-15709123
]
Andrzej Bialecki commented on SOLR-4735:
-
Ad 1. Indeed, there is some inconsistency here. I think
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708742#comment-15708742
]
Shalin Shekhar Mangar commented on SOLR-4735:
-
I built Solr from the feature/metric branch and
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708517#comment-15708517
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708347#comment-15708347
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708101#comment-15708101
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707955#comment-15707955
]
Andrzej Bialecki commented on SOLR-4735:
-
Ouch! Yeah, let's keep the discussion here.
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707000#comment-15707000
]
Jeff Wartes commented on SOLR-4735:
---
Heh, I wondered whether something like that would happen if I
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706995#comment-15706995
]
ASF GitHub Bot commented on SOLR-4735:
--
Github user randomstatistic commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705963#comment-15705963
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705871#comment-15705871
]
ASF subversion and git services commented on SOLR-4735:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705370#comment-15705370
]
ASF GitHub Bot commented on SOLR-4735:
--
GitHub user sigram opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705358#comment-15705358
]
ASF GitHub Bot commented on SOLR-4735:
--
Github user sigram commented on the issue:
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705357#comment-15705357
]
ASF GitHub Bot commented on SOLR-4735:
--
Github user sigram closed the pull request at:
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702044#comment-15702044
]
Andrzej Bialecki commented on SOLR-4735:
-
[~jwartes] thanks for the pointer to your PR, I borrowed
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701901#comment-15701901
]
Shalin Shekhar Mangar commented on SOLR-4735:
-
I have created a new branch called
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696479#comment-15696479
]
Jeff Wartes commented on SOLR-4735:
---
I had a scheme for collapsable namespaced registries in my original
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695829#comment-15695829
]
Andrzej Bialecki commented on SOLR-4735:
-
bq. Right now, each producer creates/manages its own set
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695483#comment-15695483
]
Kelvin Wong commented on SOLR-4735:
---
{quote}
Having a reload reset stats is a bad idea. We can provide an
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693874#comment-15693874
]
Jeff Wartes commented on SOLR-4735:
---
>From what I see, SolrMetricManager only needs the SolrCore for the
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693809#comment-15693809
]
Shalin Shekhar Mangar commented on SOLR-4735:
-
bq. I share Jeff's concern though that we need
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693560#comment-15693560
]
ASF GitHub Bot commented on SOLR-4735:
--
GitHub user sigram opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693048#comment-15693048
]
Andrzej Bialecki commented on SOLR-4735:
-
I'm interested in getting this issue resolved, so I'd be
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693036#comment-15693036
]
Kelvin Wong commented on SOLR-4735:
---
Thanks Jeff.
The attached patch really just piggybacks off of
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690992#comment-15690992
]
Jeff Wartes commented on SOLR-4735:
---
For what it's worth, this looks like really great stuff to me.
I'm
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626442#comment-15626442
]
Jeff Wartes commented on SOLR-4735:
---
I have, and am, by instantiating a SharedMetricRegistry and
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626331#comment-15626331
]
Walter Underwood commented on SOLR-4735:
Anybody using the CodaHale
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1459#comment-1459
]
Ramkumar Aiyengar commented on SOLR-4735:
-
[~romseygeek], still quite interested in
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222807#comment-14222807
]
Alan Woodward commented on SOLR-4735:
-
I did some thinking on this over the weekend.
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222847#comment-14222847
]
Shalin Shekhar Mangar commented on SOLR-4735:
-
That sounds like a reasonable
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223572#comment-14223572
]
Alan Woodward commented on SOLR-4735:
-
re introspection and discovery, each
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216504#comment-14216504
]
Mark Miller commented on SOLR-4735:
---
bq. feel free to gut what we have in Solr5
We
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959230#comment-13959230
]
Timothy Potter commented on SOLR-4735:
--
I have some interest in working on this idea
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959253#comment-13959253
]
Alan Woodward commented on SOLR-4735:
-
The patch that's here is pretty out-of-date, and
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959290#comment-13959290
]
Hoss Man commented on SOLR-4735:
Tim: see also SOLR-5095 which points out some anoying
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642969#comment-13642969
]
Alan Woodward commented on SOLR-4735:
-
That's a nice idea. The MetricsReporters would
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642139#comment-13642139
]
Ryan McKinley commented on SOLR-4735:
-
This looks like it creates a new registry for
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642148#comment-13642148
]
Ryan McKinley commented on SOLR-4735:
-
ideally CoreContainer could have a function
77 matches
Mail list logo
