[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631272#comment-16631272
]
ASF subversion and git services commented on SOLR-5163:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630966#comment-16630966
]
ASF subversion and git services commented on SOLR-5163:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628705#comment-16628705
]
Charles Sanders commented on SOLR-5163:
---
[~dsmiley] I ran 'ant clean test' on the code before
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628675#comment-16628675
]
David Smiley commented on SOLR-5163:
Looks pretty good. Though I don't think you tested this change?
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628186#comment-16628186
]
Lucene/Solr QA commented on SOLR-5163:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627215#comment-16627215
]
Charles Sanders commented on SOLR-5163:
---
Added a new patch. This one accounts for query field
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624711#comment-16624711
]
Lucene/Solr QA commented on SOLR-5163:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623639#comment-16623639
]
Charles Sanders commented on SOLR-5163:
---
[~dsmiley] Yes you are correct about aliases. I should
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621998#comment-16621998
]
David Smiley commented on SOLR-5163:
Aliases can refer to other aliases and it's resolved recursively.
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621982#comment-16621982
]
Edward Ribeiro commented on SOLR-5163:
--
If [~dsmiley] agreed then it's hands down the solution. Go
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621953#comment-16621953
]
David Smiley commented on SOLR-5163:
Ah; thanks for explaining why you placed the code here; makes
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621903#comment-16621903
]
Charles Sanders commented on SOLR-5163:
---
[~eribeiro] Initially I put the check in
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621372#comment-16621372
]
Edward Ribeiro commented on SOLR-5163:
--
Hey, [~Charles Sanders], you could simplify things a bit
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620991#comment-16620991
]
Charles Sanders commented on SOLR-5163:
---
Attached a new patch file. The first attempt did not take
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617834#comment-16617834
]
Charles Sanders commented on SOLR-5163:
---
[~eribeiro] Yes I am planning to get back to this. Been
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615578#comment-16615578
]
Edward Ribeiro commented on SOLR-5163:
--
Hi [~Charles Sanders], are you still working on this issue?
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595370#comment-16595370
]
Edward Ribeiro commented on SOLR-5163:
--
Hi [~Charles Sanders], a couple of questions about your patch
The waiting for cores to close can be because you make a call to something
like coreContaimer.getCore but don't call close, perhaps in a finally
block. Shot in the dark.
On Tue, Aug 28, 2018, 08:26 David Smiley (JIRA) wrote:
>
> [
>
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595133#comment-16595133
]
David Smiley commented on SOLR-5163:
Thanks for contributing!
I took a brief look at your patch.
* I
[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595117#comment-16595117
]
Charles Sanders commented on SOLR-5163:
---
I'm new to the project and this is my first contribution,
20 matches
Mail list logo
