[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985349#action_12985349
]
Doron Cohen commented on LUCENE-2236:
-
Robert, thanks for renaming back to Similarity.
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985364#action_12985364
]
Doron Cohen commented on LUCENE-2236:
-
note: with last patch both tests fail -
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985401#action_12985401
]
Doron Cohen commented on LUCENE-2236:
-
OK with java 6 all tests passed.
Similarity
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985403#action_12985403
]
Robert Muir commented on LUCENE-2236:
-
Hi Doron, thanks for the cleanups here!
bq.
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12985415#action_12985415
]
Doron Cohen commented on LUCENE-2236:
-
Hi Robert,
{quote}
I can update the javadocs
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982635#action_12982635
]
Robert Muir commented on LUCENE-2236:
-
bq. Is that too bad?
well my concern about the
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982872#action_12982872
]
Doron Cohen commented on LUCENE-2236:
-
{quote}
well my concern about the deprecated
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982888#action_12982888
]
Robert Muir commented on LUCENE-2236:
-
bq. So let's keep that name (Similarity)
OK,
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982254#action_12982254
]
Robert Muir commented on LUCENE-2236:
-
also, i removed Similarity.get/setDefault in
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982279#action_12982279
]
Simon Willnauer commented on LUCENE-2236:
-
Nice work robert, while I only looked
[
https://issues.apache.org/jira/browse/LUCENE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982299#action_12982299
]
Robert Muir commented on LUCENE-2236:
-
bq. I wonder why SimilarityProvider is an
11 matches
Mail list logo