[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-12-02 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966272#action_12966272 ] Grant Ingersoll commented on SOLR-1568: --- FYI, I believe I have backported this to 3.x

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12916652#action_12916652 ] Yonik Seeley commented on SOLR-1568: Hmmm, I just discovered that our LatLon type

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-29 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12916203#action_12916203 ] Yonik Seeley commented on SOLR-1568: committed, w/ additional javadoc updates.

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-28 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915768#action_12915768 ] Grant Ingersoll commented on SOLR-1568: --- I could go for gfilt and gdist or llfilt and

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-28 Thread Lance Norskog (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915920#action_12915920 ] Lance Norskog commented on SOLR-1568: - 1- There are no unit tests. One thing that has

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-28 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915922#action_12915922 ] Yonik Seeley commented on SOLR-1568: bq. 1- There are no unit tests. What's missing

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-28 Thread Lance Norskog (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915930#action_12915930 ] Lance Norskog commented on SOLR-1568: - I made a mistake in my text search, never mind.

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-28 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915968#action_12915968 ] Yonik Seeley commented on SOLR-1568: bq. All I can find are nits about comparing doubles

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-24 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914410#action_12914410 ] Chris Male commented on SOLR-1568: -- Yeah it is a nice page, and its math I think we should

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-24 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914411#action_12914411 ] Grant Ingersoll commented on SOLR-1568: --- Yonik, you are right on the equator and 0

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914319#action_12914319 ] Yonik Seeley commented on SOLR-1568: Hmmm, I'm not understanding the purpose of the

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914321#action_12914321 ] Yonik Seeley commented on SOLR-1568: I'm further confused by the following: {code}

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914324#action_12914324 ] Yonik Seeley commented on SOLR-1568: FYI, I'm in the middle of refactoring this code, so

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-23 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914326#action_12914326 ] Chris Male commented on SOLR-1568: -- Yonik, I recommend you glance over

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914340#action_12914340 ] Yonik Seeley commented on SOLR-1568: bq. I recommend we follow the behaviour that he

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-21 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912955#action_12912955 ] Grant Ingersoll commented on SOLR-1568: --- bq. Default is the Earth's mean radius in

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-21 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912968#action_12912968 ] Yonik Seeley commented on SOLR-1568: Didn't fix things (it was just a pole check) - the

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-09-20 Thread Bill Bell (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912780#action_12912780 ] Bill Bell commented on SOLR-1568: - The calculations of distance appears to be off. Note:

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-30 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12884032#action_12884032 ] Grant Ingersoll commented on SOLR-1568: --- FYI: after committing, I intend to

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12884028#action_12884028 ] Yonik Seeley commented on SOLR-1568: Configurable units may look like a convenience at

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-28 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883177#action_12883177 ] Grant Ingersoll commented on SOLR-1568: --- OK, here's my take on dealing w/ the poles.

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-28 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883181#action_12883181 ] Grant Ingersoll commented on SOLR-1568: --- So, the correct name for approach 2 above is

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-28 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883241#action_12883241 ] Grant Ingersoll commented on SOLR-1568: --- Note, this bowl approach also has benefits

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-28 Thread Lance Norskog (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883290#action_12883290 ] Lance Norskog commented on SOLR-1568: - Use quaternions:

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-28 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883312#action_12883312 ] Uwe Schindler commented on SOLR-1568: - Grant: Spherical Cap is the way almost all

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876279#action_12876279 ] David Smiley commented on SOLR-1568: I have been testing the capabilities of this patch

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-06-07 Thread Darren Govoni (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876527#action_12876527 ] Darren Govoni commented on SOLR-1568: - Yeah, I brought this issue up on the mailing

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-05-10 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865942#action_12865942 ] Grant Ingersoll commented on SOLR-1568: --- Sorry for the confusion. The tests for this

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-05-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865154#action_12865154 ] David Smiley commented on SOLR-1568: I've finally tried this out successfully. But I

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-13 Thread Brainski (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12856411#action_12856411 ] Brainski commented on SOLR-1568: Hi I tested the last patch. I was able to apply it to the

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853369#action_12853369 ] Chris Male commented on SOLR-1568: -- Hi, I have taken a look at the latest patch and it

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853376#action_12853376 ] Grant Ingersoll commented on SOLR-1568: --- bq. changing SpatialOptions w/o breaking back

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853377#action_12853377 ] Yonik Seeley commented on SOLR-1568: bq. I wonder if we shouldn't also pass along the

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853380#action_12853380 ] Grant Ingersoll commented on SOLR-1568: --- even better. Patch soon Implement Spatial

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853401#action_12853401 ] Yonik Seeley commented on SOLR-1568: bq. even better. Patch soon I meant, you already

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853406#action_12853406 ] Grant Ingersoll commented on SOLR-1568: --- No, you are right. I wasn't thinking

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-04-05 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853556#action_12853556 ] Chris A. Mattmann commented on SOLR-1568: - +1 on the latest patch with the following

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-03-31 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852009#action_12852009 ] Grant Ingersoll commented on SOLR-1568: --- Thanks for the thorough feedback, Yonik.

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-03-30 Thread Lance Norskog (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851726#action_12851726 ] Lance Norskog commented on SOLR-1568: - Dublin Core includes conventions for encoding

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-03-29 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851154#action_12851154 ] Yonik Seeley commented on SOLR-1568: Things are looking good! I like the

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-03-10 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12843883#action_12843883 ] Chris A. Mattmann commented on SOLR-1568: - Hey Grant: I'll take a look at your

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-02-18 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12835347#action_12835347 ] Yonik Seeley commented on SOLR-1568: I'm not a fan of optional units... I think we

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-02-09 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831611#action_12831611 ] Grant Ingersoll commented on SOLR-1568: --- Actually, in thinking some more about this,

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-02-08 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12831140#action_12831140 ] Grant Ingersoll commented on SOLR-1568: --- So, one of the things I'm not sure on here is

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-25 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804759#action_12804759 ] Grant Ingersoll commented on SOLR-1568: --- bq. And how would that be specified out of

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796249#action_12796249 ] Grant Ingersoll commented on SOLR-1568: --- Here's the thing I keep coming back to with

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796280#action_12796280 ] Ryan McKinley commented on SOLR-1568: - I'm torn on this also... The function query

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796282#action_12796282 ] Grant Ingersoll commented on SOLR-1568: --- Keep in mind distance functions are about

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796289#action_12796289 ] Yonik Seeley commented on SOLR-1568: The examples are not of equivalent power. What

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796299#action_12796299 ] Grant Ingersoll commented on SOLR-1568: --- bq. Are we filtering by bounding box or by

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796308#action_12796308 ] Grant Ingersoll commented on SOLR-1568: --- Also, in all of these proposals, how do we

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796348#action_12796348 ] Yonik Seeley commented on SOLR-1568: bq. Also, in all of these proposals, how do we

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796352#action_12796352 ] Ryan McKinley commented on SOLR-1568: - {quote} could be written as {code} fq={!sfilt

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796457#action_12796457 ] Yonik Seeley commented on SOLR-1568: bq. since if we use the FunctionRangeQParser, it's

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796476#action_12796476 ] Grant Ingersoll commented on SOLR-1568: --- {code} fq={!frange l=0 u=400}hsin(0.57, -1.3,

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796478#action_12796478 ] Yonik Seeley commented on SOLR-1568: While it's nice that this works (to double-check

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796485#action_12796485 ] Grant Ingersoll commented on SOLR-1568: --- For those who only want pure radial search,

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796491#action_12796491 ] Yonik Seeley commented on SOLR-1568: bq. For those who only want pure radial search, it

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2010-01-04 Thread patrick o'leary (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796524#action_12796524 ] patrick o'leary commented on SOLR-1568: --- bq. A smart spatial filter, at a minimum,

[jira] Commented: (SOLR-1568) Implement Spatial Filter

2009-12-28 Thread patrick o'leary (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12795014#action_12795014 ] patrick o'leary commented on SOLR-1568: --- I would be concerned that this starts making