Accessibility of CollectedSearchGroup's state

2021-10-14 Thread Chris Hegarty
In an effort to prepare Elasticsearch for modularization, we are investigating and eliminating split packages. The situation has improved through recent refactoring in Lucene 9.0 [1], but a number of split packages still remain. This message identifies one such so that it can be discussed in isolat

Re: Accessibility of CollectedSearchGroup's state

2021-10-14 Thread Adrien Grand
I feel sorry for increasing the scope of all these requests for changes that you make, but the way Elasticsearch overrides this collector feels wrong to me as any change in the implementation details of this collector would probably break Elasticsearch's collector too. In my opinion, CollectedSearc

Re: Accessibility of CollectedSearchGroup's state

2021-10-14 Thread jim ferenczi
I agree, we should have a SinglePassGroupingCollector in Elasticsearch and reduce the visibility of these expert classes in Lucene. As it stands today, the FirstPassGroupingCollector could be a final class imo. Le jeu. 14 oct. 2021 à 18:42, Adrien Grand a écrit : > I feel sorry for increasing t

Re: Accessibility of CollectedSearchGroup's state

2021-10-15 Thread Chris Hegarty
Hi Adrien, Jim, First, thank you for your time and insightful comments. They are very much appreciated, and will no doubt lead to the best solution. I will reimplement the elasticsearch collector as suggested, and then circle back here with a proposal for the reduction in accessibility most app