Re: Do we need the MODIFYCOLLECTION Api?

2018-06-19 Thread Varun Thacker
Thanks everyone! I've created SOLR-12498 and linked it to this mailing list thread On Tue, Jun 19, 2018 at 8:14 AM, Shalin Shekhar Mangar < shalinman...@gmail.com> wrote: > > > On Fri, Jun 15, 2018 at 7:47 PM Varun Thacker wrote: > >> >> >> On Fri, Jun 15, 2018 at 2:44 PM, David Smiley >> wrote

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-18 Thread Shalin Shekhar Mangar
On Fri, Jun 15, 2018 at 7:47 PM Varun Thacker wrote: > > > On Fri, Jun 15, 2018 at 2:44 PM, David Smiley > wrote: > >> +1 to get rid of #1, #2, #3, #7. >> >> Maybe I'm mistaken but I thought "policy" was a part of the auto scaling >> framework? >> > > Yeah. And > http://lucene.apache.org/solr/gu

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread Varun Thacker
So let's keep *collection.configName* and *replicationFactor*. If we were to think of this API today , would MODIFYCOLLECTION be where we still put it? It almost feels like a collection setting. Maybe Collection Properties ( SOLR-11960 ) is where it should live? On Fri, Jun 15, 2018 at 4:58 PM,

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread Erick Erickson
re: collection.configName bq. Right and then basically we are giving a way for users to shoot themselves in the foot :) They can also delete their index files Seriously though, what if I have a bunch of collections sharing a configset then I need to specialize only one by _adding_ fields? I'

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread Varun Thacker
Hi Jan, I agree with how your thinking of replicationFactor as basically being a equivalent to nrtReplicas . Let's not change that. so the is #7 the real only use for this API? On Fri, Jun 15, 2018 at 1:46 PM, Jan Høydahl wrote: > Do we have a v2 API for CREATE and MODIFYCOLLECTION? E.g. > > P

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread Varun Thacker
On Fri, Jun 15, 2018 at 2:44 PM, David Smiley wrote: > +1 to get rid of #1, #2, #3, #7. > > Maybe I'm mistaken but I thought "policy" was a part of the auto scaling > framework? > Yeah. And http://lucene.apache.org/solr/guide/solrcloud-autoscaling-api.html#create-and-modify-cluster-policies seem

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread David Smiley
+1 to get rid of #1, #2, #3, #7. Maybe I'm mistaken but I thought "policy" was a part of the auto scaling framework? Maybe the capability for autoAddReplicas should be considered an aspect of the auto scaling framework instead of a collection setting, and thus we could remove it here? I think th

Re: Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread Jan Høydahl
Do we have a v2 API for CREATE and MODIFYCOLLECTION? E.g. POST http://localhost:8983/api/c { modify-collection: { replicationFactor: 3 } } Perhaps we should focus on a decent v2 API and deprecate the old confusing one? wrt. replicationFactor / nrtReplica / pullRepl

Do we need the MODIFYCOLLECTION Api?

2018-06-15 Thread Varun Thacker
Today the Modify Collection supports the following properties to be modified 1. maxShardsPerNode 2. rule 3. snitch 4. policy 5. collection.configName 6. autoAddReplicas 7. replicationFactor 1-4 seems something we should get rid of because we have the AutoScaling Policy framew