Re: Do we want 'nocommit' to fail the commit?

2010-12-18 Thread Michael McCandless
+1 this would be great :) Mike On Fri, Dec 17, 2010 at 10:45 PM, Shai Erera ser...@gmail.com wrote: Hi Out of curiosity, I searched if we can have a nocommit comment in the code fail the commit. As far as I see, we try to avoid accidental commits (of say debug messages) by putting a nocommit

Re: Do we want 'nocommit' to fail the commit?

2010-12-18 Thread Earwin Burrfoot
But. Er. What if we happen to have nocommit in a string, or in some docs, or as a name of variable? On Sat, Dec 18, 2010 at 12:47, Michael McCandless luc...@mikemccandless.com wrote: +1 this would be great :) Mike On Fri, Dec 17, 2010 at 10:45 PM, Shai Erera ser...@gmail.com wrote: Hi Out

Re: Do we want 'nocommit' to fail the commit?

2010-12-18 Thread Uwe Schindler
I like this idea, too. But I think we have no control on this, it would be as complicated as the mergeprops... What we have: Hudson halfly hour builds fail when svn contains commits, so you see it latest 30 Min later. Uwe Shai Erera ser...@gmail.com schrieb: Hi Out of curiosity, I

Re: Do we want 'nocommit' to fail the commit?

2010-12-18 Thread Shai Erera
I haven't seen nocommit in the code, neither as String nor as member. But we can decide that we do @nocommit@ or something, which is less likely to be contained in code :). Uwe, I didn't understand your response - do you mean that if the code contains a 'nocommit' in any of the .java files,

Do we want 'nocommit' to fail the commit?

2010-12-17 Thread Shai Erera
Hi Out of curiosity, I searched if we can have a nocommit comment in the code fail the commit. As far as I see, we try to avoid accidental commits (of say debug messages) by putting a nocommit comment, but I don't know if svn ci would fail in the presence of such comment - I guess not because