Re: Improve testing

2024-05-25 Thread Stefan Vodita
Some useful documentation on the gradlew commands: https://github.com/apache/lucene/blob/main/help/workflow.txt On Sat, 25 May 2024 at 19:38, Stefan Vodita wrote: > I'll add a step in between 1 and 2 that I often forget: ./gradlew tidy > This refactors your code to the style the project uses,

Re: Improve testing

2024-05-25 Thread Stefan Vodita
I'll add a step in between 1 and 2 that I often forget: ./gradlew tidy This refactors your code to the style the project uses, which we have checks for. On Sat, 25 May 2024 at 00:53, Michael Froh wrote: > Is your new test uncommitted? > > The Gradle check will fail if you have uncommitted

Re: Improve testing

2024-05-24 Thread Michael Froh
Is your new test uncommitted? The Gradle check will fail if you have uncommitted files, to avoid the situation where it "works on my machine (because of a file that I forgot to commit)". The rough workflow is: 1. Develop stuff (code and/or tests). 2. Commit it. 3. Gradle check. 4. If Gradle

Re: Improve testing

2024-05-24 Thread Chang Hank
After I added the new test case, I failed the ./gradlew check and it seems like the check failed because I added the new test case. Is there anything I need to do before executing ./gradlew check? Best, Hank > On May 24, 2024, at 12:53 PM, Chang Hank wrote: > > Hi Robert, > > Thanks for

Re: Improve testing

2024-05-24 Thread Chang Hank
Hi Robert, Thanks for your advice, will look into it!! Best, Hank > On May 24, 2024, at 12:46 PM, Robert Muir wrote: > > On Fri, May 24, 2024 at 2:33 PM Chang Hank wrote: >> >> Hi all, >> >> I want to improve the code coverage for Lucene, which package would you >> recommend testing to do

Re: Improve testing

2024-05-24 Thread Robert Muir
On Fri, May 24, 2024 at 2:33 PM Chang Hank wrote: > > Hi all, > > I want to improve the code coverage for Lucene, which package would you > recommend testing to do so? Do we need more coverage in the Core package? > Hello, I'd recommend looking at the help/tests.txt file, you can generate the

Improve testing

2024-05-24 Thread Chang Hank
Hi all, I want to improve the code coverage for Lucene, which package would you recommend testing to do so? Do we need more coverage in the Core package? Best, Hank - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org

[jira] [Commented] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-08-02 Thread Yury Kats (JIRA)
persistence. See SOLR-2691. Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331 URL: https://issues.apache.org/jira/browse/SOLR-2331 Project

[jira] [Resolved] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-07-08 Thread Mark Miller (JIRA)
come in further issues. Noble has a great one going to factor out zookeeper parts as well. Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331 URL: https

[jira] [Issue Comment Edited] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-07-08 Thread Mark Miller (JIRA)
, but it can come in further issues. Noble has a great one going to factor out zookeeper parts as well. Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331

[jira] [Updated] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-07-07 Thread Steven Rowe (JIRA)
contents are printed out. I plan to commit this later tonight. Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331 URL: https://issues.apache.org/jira

[jira] [Updated] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-07-07 Thread Steven Rowe (JIRA)
the persisted core config printing to STDOUT in an {{if (VERBOSE)}} block. Committing shortly. Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331 URL: https

[jira] [Commented] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-07-07 Thread Steven Rowe (JIRA)
and closes it after the file contents are printed out [and] wraps the persisted core config printing to STDOUT in an {{if (VERBOSE)}} block. Committed in r1144088. Refactor CoreContainer's SolrXML serialization code and improve testing

[jira] [Commented] (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-07-05 Thread Mark Miller (JIRA)
functionality Yeah, I think the idea is good. I think some of the 'load' code could also be pulled up into the SolrXMLSerializer. If no one objects, I'd like to commit this part soon though - then tackle the load side later. Refactor CoreContainer's SolrXML serialization code and improve testing

[jira] Created: (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-01-23 Thread Mark Miller (JIRA)
Refactor CoreContainer's SolrXML serialization code and improve testing --- Key: SOLR-2331 URL: https://issues.apache.org/jira/browse/SOLR-2331 Project: Solr Issue Type

[jira] Updated: (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-01-23 Thread Mark Miller (JIRA)
serialization code and improve testing --- Key: SOLR-2331 URL: https://issues.apache.org/jira/browse/SOLR-2331 Project: Solr Issue Type: Improvement Components

[jira] Commented: (SOLR-2331) Refactor CoreContainer's SolrXML serialization code and improve testing

2011-01-23 Thread Chris Male (JIRA)
and improve testing --- Key: SOLR-2331 URL: https://issues.apache.org/jira/browse/SOLR-2331 Project: Solr Issue Type: Improvement Components: multicore