On Fri, Nov 30, 2012 at 1:08 PM, Shai Erera wrote:
>> Hmm prepareCommit() really should somehow pass true: this API is only
>> invoked by the app, not by IW internally during close.
>
>
> Currently, the app can call prepareCommit() or prepareCommint(data), the
> former calls ensureOpen(true), the
>
> Hmm prepareCommit() really should somehow pass true: this API is only
> invoked by the app, not by IW internally during close.
Currently, the app can call prepareCommit() or prepareCommint(data), the
former calls ensureOpen(true), the latter ensureOpen(false).
The problem is that the latter
On Fri, Nov 30, 2012 at 8:29 AM, Michael McCandless <
luc...@mikemccandless.com> wrote:
>
> > 2) Could you perhaps clarify the use of the second argument in the
> javadocs?
> > Maybe also rename it to something like "fail if closing"? The name
> > "includePendingClose" is vague perhaps consider*?)
On Fri, Nov 30, 2012 at 7:13 AM, Shai Erera wrote:
> I see. So two questions:
>
> 1) Is it ok for prepareCommit() to call ensureOpen(false)? In LUCENE-4575 I
> consolidate the two prepCommit() and this is the only way it would work ...
Hmm prepareCommit() really should somehow pass true: this API
I see. So two questions:
1) Is it ok for prepareCommit() to call ensureOpen(false)? In LUCENE-4575 I
consolidate the two prepCommit() and this is the only way it would work ...
2) Could you perhaps clarify the use of the second argument in the
javadocs? Maybe also rename it to something like "fai
On Thu, Nov 29, 2012 at 3:31 PM, Shai Erera wrote:
>
> Hi
>
> While working on LUCENE-4575 I noticed what I thought was an inconsistency
> between prepareCommit() and prepareCommit(commitData).
> The former called ensureOpen(true) and the latter ensureOpen(false). At first
> I thought that this
Hi
While working on LUCENE-4575 I noticed what I thought was an inconsistency
between prepareCommit() and prepareCommit(commitData).
The former called ensureOpen(true) and the latter ensureOpen(false). At
first I thought that this is a bug, so I fixed both to call
ensureOpen(true),
especially now
