Re: InterruptedException handling between solr->zk interactions

2018-04-14 Thread Mikhail Khludnev
Ok. I've found my fix for the expired /autoscaling.json spin in OTT diff --git a/solr/core/src/java/org/apache/solr/cloud/autoscaling/OverseerTriggerThread.java b/solr/core/src/java/org/apache/solr/cloud/autoscaling/OverseerTriggerThread.java index ece4c4c..6fe2057 100644 --- a/solr/core/src/java/

Re: InterruptedException handling between solr->zk interactions

2018-04-13 Thread Tomás Fernández Löbbe
Yes, I've seen these issues too. The right thing to do is to close all resources (in some cases finish anything that can't be left in a bad state) and exit. In this particular case I'd think the InterruptedException is swallowed unintentionally because of the catch (Exception ). I suspect for the O

Re: InterruptedException handling between solr->zk interactions

2018-04-13 Thread Varun Thacker
Hi Mikhail, My checkout already has that commit when i ran into this issue. I'll reply on SOLR-7736 with some more details. On Fri, Apr 13, 2018 at 3:02 PM, Mikhail Khludnev wrote: > Hello, Varun. > > If you are bothered with > --- Thousands of "Session expired for /autoscaling.json" messages

Re: InterruptedException handling between solr->zk interactions

2018-04-13 Thread Mikhail Khludnev
Hello, Varun. If you are bothered with --- Thousands of "Session expired for /autoscaling.json" messages before I had to manually kill the test run it should be resolved by https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=commitdiff;h=a4789db On Sat, Apr 14, 2018 at 12:31 AM, Varun Th

InterruptedException handling between solr->zk interactions

2018-04-13 Thread Varun Thacker
Is there a general strategy on how to deal with InterruptedException while issues a zookeeper call from solr? Here's a more concrete example which I am unsure if it's doing the right thing or not: https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/cloud/OverseerT