Re: Opening up FieldCacheImpl

2013-03-26 Thread Alan Woodward
/apache-solr-3-enterprise-search-server/book -- View this message in context: http://lucene.472066.n3.nabble.com/Opening-up-FieldCacheImpl-tp4050537p4051217.html Sent from the Lucene - Java Developer mailing list archive at Nabble.com

Re: Opening up FieldCacheImpl

2013-03-26 Thread Alan Woodward
://lucene.472066.n3.nabble.com/Opening-up-FieldCacheImpl-tp4050537p4051217.html Sent from the Lucene - Java Developer mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional

Re: Opening up FieldCacheImpl

2013-03-25 Thread David Smiley (@MITRE.org)
- Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book -- View this message in context: http://lucene.472066.n3.nabble.com/Opening-up-FieldCacheImpl-tp4050537p4051217.html Sent from the Lucene - Java Developer mailing list archive at Nabble.com

Re: Opening up FieldCacheImpl

2013-03-25 Thread Robert Muir
: dev-unsubscribe@.apache For additional commands, e-mail: dev-help@.apache - Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book -- View this message in context: http://lucene.472066.n3.nabble.com/Opening-up-FieldCacheImpl-tp4050537p4051217.html Sent

Re: Opening up FieldCacheImpl

2013-03-23 Thread Alan Woodward
I think instead FieldCache should actually be completely package private and hidden behind a UninvertingFilterReader and accessible via the existing AtomicReader docValues methods. Aha, right, because SegmentCoreReaders already caches XXXDocValues instances (without using WeakReferences or

Re: Opening up FieldCacheImpl

2013-03-23 Thread Robert Muir
On Sat, Mar 23, 2013 at 7:25 AM, Alan Woodward a...@flax.co.uk wrote: I think instead FieldCache should actually be completely package private and hidden behind a UninvertingFilterReader and accessible via the existing AtomicReader docValues methods. Aha, right, because SegmentCoreReaders

Opening up FieldCacheImpl

2013-03-22 Thread Alan Woodward
I'm looking at exposing data held externally to an index via a ValueSource, and it would be nice to reuse the machinery in FieldCacheImpl to cache the data per-segment. However, it's package-private at the moment, which means I can't extend it nicely. Is there a reason for this? Or should I

Re: Opening up FieldCacheImpl

2013-03-22 Thread David Smiley (@MITRE.org)
it nicely. Is there a reason for this? Or should I put up a JIRA to make it public? Alan Woodward www.flax.co.uk - Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book -- View this message in context: http://lucene.472066.n3.nabble.com/Opening-up-FieldCacheImpl

Re: Opening up FieldCacheImpl

2013-03-22 Thread Yonik Seeley
The ability to cache stuff w/o resorting to weak references would be even nicer! Caches right on the segment readers? -Yonik http://lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional

Re: Opening up FieldCacheImpl

2013-03-22 Thread Robert Muir
Note that what fieldcache does is not special, it just has a map and calls the public SegmentReader.addCoreClosedListener method so that it gets notifications when something is no longer needed. I'm not sure we should make fieldcacheimpl public if thats the real logic you want to reuse. On Fri,

Re: Opening up FieldCacheImpl

2013-03-22 Thread Alan Woodward
Actually this would be really nice, wouldn't it. Add a getFieldCache(String field) method to AtomicReader. You'd have to be able to determine what to return depending on the field though - uninverted field, or docvalues, or another cached source. FieldCache and DocValues seem like they

Re: Opening up FieldCacheImpl

2013-03-22 Thread Robert Muir
On Fri, Mar 22, 2013 at 6:26 PM, Alan Woodward a...@flax.co.uk wrote: Actually this would be really nice, wouldn't it. Add a getFieldCache(String field) method to AtomicReader. You'd have to be able to determine what to return depending on the field though - uninverted field, or docvalues, or